src/tests/dolphinmainwindowtest.cpp

   1 /***************************************************************************
   2  *   Copyright (C) 2017 by Elvis Angelaccio <elvis.angelaccio@kde.org>     *
   3  *                                                                         *
   4  *   This program is free software; you can redistribute it and/or modify  *
   5  *   it under the terms of the GNU General Public License as published by  *
   6  *   the Free Software Foundation; either version 2 of the License, or     *
   7  *   (at your option) any later version.                                   *
   8  *                                                                         *
   9  *   This program is distributed in the hope that it will be useful,       *
  10  *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
  11  *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
  12  *   GNU General Public License for more details.                          *
  13  *                                                                         *
  14  *   You should have received a copy of the GNU General Public License     *
  15  *   along with this program; if not, write to the                         *
  16  *   Free Software Foundation, Inc.,                                       *
  17  *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA            *
  18  ***************************************************************************/
  19
  20 #include "dolphinmainwindow.h"
  21 #include "dolphintabpage.h"
  22 #include "dolphintabwidget.h"
  23 #include "dolphinviewcontainer.h"
  24
  25 #include <KActionCollection>
  26
  27 #include <QSignalSpy>
  28 #include <QStandardPaths>
  29 #include <QTest>
  30
  31 class DolphinMainWindowTest : public QObject
  32 {
  33     Q_OBJECT
  34
  35 private slots:
  36     void initTestCase();
  37     void init();
  38     void testClosingTabsWithSearchBoxVisible();
  39     void testActiveViewAfterClosingSplitView_data();
  40     void testActiveViewAfterClosingSplitView();
  41     void testUpdateWindowTitleAfterClosingSplitView();
  42
  43 private:
  44     QScopedPointer<DolphinMainWindow> m_mainWindow;
  45 };
  46
  47 void DolphinMainWindowTest::initTestCase()
  48 {
  49     QStandardPaths::setTestModeEnabled(true);
  50 }
  51
  52 void DolphinMainWindowTest::init()
  53 {
  54     m_mainWindow.reset(new DolphinMainWindow());
  55 }
  56
  57 // See https://bugs.kde.org/show_bug.cgi?id=379135
  58 void DolphinMainWindowTest::testClosingTabsWithSearchBoxVisible()
  59 {
  60     m_mainWindow->openDirectories({ QUrl::fromLocalFile(QDir::homePath()) }, false);
  61     m_mainWindow->show();
  62     // Without this call the searchbox doesn't get FocusIn events.
  63     QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data()));
  64     QVERIFY(m_mainWindow->isVisible());
  65
  66     auto tabWidget = m_mainWindow->findChild<DolphinTabWidget*>("tabWidget");
  67     QVERIFY(tabWidget);
  68
  69     // Show search box on first tab.
  70     tabWidget->currentTabPage()->activeViewContainer()->setSearchModeEnabled(true);
  71
  72     tabWidget->openNewActivatedTab(QUrl::fromLocalFile(QDir::homePath()));
  73     QCOMPARE(tabWidget->count(), 2);
  74
  75     // Triggers the crash in bug #379135.
  76     tabWidget->closeTab();
  77     QCOMPARE(tabWidget->count(), 1);
  78 }
  79
  80 void DolphinMainWindowTest::testActiveViewAfterClosingSplitView_data()
  81 {
  82     QTest::addColumn<bool>("closeLeftView");
  83
  84     QTest::newRow("close left view") << true;
  85     QTest::newRow("close right view") << false;
  86 }
  87
  88 void DolphinMainWindowTest::testActiveViewAfterClosingSplitView()
  89 {
  90     m_mainWindow->openDirectories({ QUrl::fromLocalFile(QDir::homePath()) }, false);
  91     m_mainWindow->show();
  92     QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data()));
  93     QVERIFY(m_mainWindow->isVisible());
  94
  95     auto tabWidget = m_mainWindow->findChild<DolphinTabWidget*>("tabWidget");
  96     QVERIFY(tabWidget);
  97     QVERIFY(tabWidget->currentTabPage()->primaryViewContainer());
  98     QVERIFY(!tabWidget->currentTabPage()->secondaryViewContainer());
  99
 100     // Open split view.
 101     m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger();
 102     QVERIFY(tabWidget->currentTabPage()->splitViewEnabled());
 103     QVERIFY(tabWidget->currentTabPage()->secondaryViewContainer());
 104
 105     // Make sure the right view is the active one.
 106     auto leftViewContainer = tabWidget->currentTabPage()->primaryViewContainer();
 107     auto rightViewContainer = tabWidget->currentTabPage()->secondaryViewContainer();
 108     QVERIFY(!leftViewContainer->isActive());
 109     QVERIFY(rightViewContainer->isActive());
 110
 111     QFETCH(bool, closeLeftView);
 112     if (closeLeftView) {
 113         // Activate left view.
 114         leftViewContainer->setActive(true);
 115         QVERIFY(leftViewContainer->isActive());
 116         QVERIFY(!rightViewContainer->isActive());
 117
 118         // Close left view. The secondary view (which was on the right) will become the primary one and must be active.
 119         m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger();
 120         QVERIFY(!leftViewContainer->isActive());
 121         QVERIFY(rightViewContainer->isActive());
 122         QCOMPARE(rightViewContainer, tabWidget->currentTabPage()->activeViewContainer());
 123     } else {
 124         // Close right view. The left view will become active.
 125         m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger();
 126         QVERIFY(leftViewContainer->isActive());
 127         QVERIFY(!rightViewContainer->isActive());
 128         QCOMPARE(leftViewContainer, tabWidget->currentTabPage()->activeViewContainer());
 129     }
 130 }
 131
 132 // Test case for bug #385111
 133 void DolphinMainWindowTest::testUpdateWindowTitleAfterClosingSplitView()
 134 {
 135     m_mainWindow->openDirectories({ QUrl::fromLocalFile(QDir::homePath()) }, false);
 136     m_mainWindow->show();
 137     QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data()));
 138     QVERIFY(m_mainWindow->isVisible());
 139
 140     auto tabWidget = m_mainWindow->findChild<DolphinTabWidget*>("tabWidget");
 141     QVERIFY(tabWidget);
 142     QVERIFY(tabWidget->currentTabPage()->primaryViewContainer());
 143     QVERIFY(!tabWidget->currentTabPage()->secondaryViewContainer());
 144
 145     // Open split view.
 146     m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger();
 147     QVERIFY(tabWidget->currentTabPage()->splitViewEnabled());
 148     QVERIFY(tabWidget->currentTabPage()->secondaryViewContainer());
 149
 150     // Make sure the right view is the active one.
 151     auto leftViewContainer = tabWidget->currentTabPage()->primaryViewContainer();
 152     auto rightViewContainer = tabWidget->currentTabPage()->secondaryViewContainer();
 153     QVERIFY(!leftViewContainer->isActive());
 154     QVERIFY(rightViewContainer->isActive());
 155
 156     // Activate left view.
 157     leftViewContainer->setActive(true);
 158     QVERIFY(leftViewContainer->isActive());
 159     QVERIFY(!rightViewContainer->isActive());
 160
 161     // Close split view. The secondary view (which was on the right) will become the primary one and must be active.
 162     m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger();
 163     QVERIFY(!leftViewContainer->isActive());
 164     QVERIFY(rightViewContainer->isActive());
 165     QCOMPARE(rightViewContainer, tabWidget->currentTabPage()->activeViewContainer());
 166
 167     // Change URL and make sure we emit the currentUrlChanged signal (which triggers the window title update).
 168     QSignalSpy currentUrlChangedSpy(tabWidget, &DolphinTabWidget::currentUrlChanged);
 169     tabWidget->currentTabPage()->activeViewContainer()->setUrl(QUrl::fromLocalFile(QDir::rootPath()));
 170     QCOMPARE(currentUrlChangedSpy.count(), 1);
 171 }
 172
 173 QTEST_MAIN(DolphinMainWindowTest)
 174
 175 #include "dolphinmainwindowtest.moc"