]> cloud.milkyroute.net Git - dolphin.git/commit
Update window title after closing split view
authorRobert Jennings <rjennings.kde@gmail.com>
Wed, 25 Apr 2018 10:35:29 +0000 (12:35 +0200)
committerElvis Angelaccio <elvis.angelaccio@kde.org>
Wed, 25 Apr 2018 10:37:28 +0000 (12:37 +0200)
commit78c8b36dd84a94916835d702ea4a9e8eda65e8ef
treede7a6f762d49f4149bd7b7062cad2a8ff8a73c2c
parent74c2d4ea2d256183dc1f869a78ee5b1b79888330
Update window title after closing split view

Summary:

In dolphintabpage.cpp:

Through the connections set up in createViewContainer(), m_primaryViewContainer->setActive(true), at line 98,
ends up triggering slotViewActivated().

Because m_primaryViewActive is true, oldActiveView is not set to the view needed in this particular situation.
Both oldActiveView and newActiveView end up pointing to the same view and the connections are not set up.

BUG: 385111
FIXED-IN: 18.04.1

Test Plan:
1. Open split view
2. Make left panel active
3. Close split view
4. Navigate to various directories

Window title now updates to show current directory

Also tried with multiple tabs/combinations

Reviewers: #dolphin, ngraham

Reviewed By: #dolphin, ngraham

Subscribers: elvisangelaccio, ngraham

Differential Revision: https://phabricator.kde.org/D12446
src/dolphintabpage.cpp