]> cloud.milkyroute.net Git - dolphin.git/commit
Build TerminalPanel also on Windows
authorElvis Angelaccio <elvis.angelaccio@kde.org>
Sun, 21 Jan 2018 11:18:21 +0000 (12:18 +0100)
committerElvis Angelaccio <elvis.angelaccio@kde.org>
Sat, 10 Feb 2018 18:40:15 +0000 (19:40 +0100)
commit87e8d0ba5f80f53a62a3951537b60a24e72e8460
tree902623094659c880fe2a29c8632464490e3a9d13
parent9fbf7a0b624aee6b116efdf69462e73f0275fab6
Build TerminalPanel also on Windows

Summary:
terminalpanel.cpp *should* compile on Windows, so there is no reason to
remove it from the build and use tons of #ifdefs in dolphinmainwindow.

We still keep the terminal panel disabled on Windows
(i.e. the two remaining #ifndef Q_OS_WIN in dolphinmainwindow),
because it is probably not functional.

But at least we won't break the Windows CI every time
someone touches the terminal panel code (see e.g. 2e942237c9).

Test Plan: Builds on Linux, someone on Windows should test this patch if possible.

Reviewers: #dolphin, #craft

Differential Revision: https://phabricator.kde.org/D10006
src/CMakeLists.txt
src/dolphinmainwindow.cpp
src/dolphinmainwindow.h