Only actually change the resource if tags were changed.

svn path=/trunk/KDE/kdebase/apps/; revision=914234

diff --git a/src/panels/information/resourcetaggingwidget.cpp b/src/panels/information/resourcetaggingwidget.cpp
index 3a4da3ea99fe29a79efa4be3534676526119d95e..34892f30c76da7421b7d6cbbef151542ec9434af 100644 (file)
--- a/src/panels/information/resourcetaggingwidget.cpp
+++ b/src/panels/information/resourcetaggingwidget.cpp
@@ -48,6 +48,8 @@ public:
 
     QList<Tag> resourceTags;
 
 
     QList<Tag> resourceTags;
 

+    bool tagsChanged;
+

     void showTaggingPopup( const QPoint& );
     void _k_slotShowTaggingPopup();
     void _k_metadataUpdateDone();
     void showTaggingPopup( const QPoint& );
     void _k_slotShowTaggingPopup();
     void _k_metadataUpdateDone();


@@ -65,13 +67,16 @@ void Nepomuk::ResourceTaggingWidget::Private::showTaggingPopup( const QPoint& po
         popup->setTagSelected( tag, true );
     }
 
         popup->setTagSelected( tag, true );
     }
 

+    tagsChanged = false;

     popup->exec( pos );
 
     popup->exec( pos );
 

-    MassUpdateJob* job = MassUpdateJob::tagResources( resources, resourceTags );
-    connect( job, SIGNAL( result( KJob* ) ),
-             q, SLOT( _k_metadataUpdateDone() ) );
-    q->setEnabled( false ); // no updates during execution
-    job->start();
+    if( tagsChanged ) {
+        MassUpdateJob* job = MassUpdateJob::tagResources( resources, resourceTags );
+        connect( job, SIGNAL( result( KJob* ) ),
+                 q, SLOT( _k_metadataUpdateDone() ) );
+        q->setEnabled( false ); // no updates during execution
+        job->start();
+    }

 
     resourceTagCloud->showTags( resourceTags );
 }
 
     resourceTagCloud->showTags( resourceTags );
 }


@@ -167,6 +172,7 @@ void Nepomuk::ResourceTaggingWidget::slotTagToggled( const Nepomuk::Tag& tag, bo
     else {
         d->resourceTags.removeAll( tag );
     }
     else {
         d->resourceTags.removeAll( tag );
     }

+    d->tagsChanged = true;

     d->popup->hide();
 }
 
     d->popup->hide();
 }