]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Remove last traces of KFileMetaDataWidget from information panel
authorStefan Brüns <stefan.bruens@rwth-aachen.de>
Sun, 14 Apr 2019 12:46:51 +0000 (14:46 +0200)
committerStefan Brüns <stefan.bruens@rwth-aachen.de>
Sun, 14 Apr 2019 12:59:00 +0000 (14:59 +0200)
Summary:
The whole information panel is not included when Baloo is not found,
so there is no need for the HAVE_BALOO guards.
KFileMetaDataWidget and KFileMetaDataConfigurationWidget were never part
of KF5, see https://git.reviewboard.kde.org/r/113153/

Test Plan: ctest

Reviewers: #frameworks, apol, ngraham, #dolphin, elvisangelaccio

Reviewed By: #dolphin, elvisangelaccio

Subscribers: elvisangelaccio, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D20513

src/panels/information/filemetadataconfigurationdialog.h
src/panels/information/informationpanelcontent.h

index 04357783c324c1eb96b776063d6d96250e5dc6de..0a57cf29fdb9b16fa987a19d5a00945ec6654b9d 100644 (file)
 
 #include <KFileItem>
 #include <config-baloo.h>
-#ifndef HAVE_BALOO
-class KFileMetaDataConfigurationWidget;
-#else
 namespace Baloo {
     class FileMetaDataConfigWidget;
 }
-#endif
 
 class QLabel;
 
 /**
  * @brief Dialog which allows to configure which meta data should be shown
- *        in the KFileMetaDataWidget.
+ *        in the Baloo:FileMetaDataWidget.
  */
 class FileMetaDataConfigurationDialog : public QDialog
 {
index 83fb3d80babad03faa86de1f36112d2685eab8e5..4f88b597ed034ad0287ac2c05d67a626f5acd4b3 100644 (file)
@@ -40,13 +40,9 @@ namespace KIO {
   class PreviewJob;
 }
 
-#ifndef HAVE_BALOO
-class KFileMetaDataWidget;
-#else
 namespace Baloo {
     class FileMetaDataWidget;
 }
-#endif
 
 /**
  * @brief Manages the widgets that display the meta information
@@ -138,11 +134,7 @@ private:
     PixmapViewer* m_preview;
     PhononWidget* m_phononWidget;
     QLabel* m_nameLabel;
-#ifndef HAVE_BALOO
-    KFileMetaDataWidget* m_metaDataWidget;
-#else
     Baloo::FileMetaDataWidget* m_metaDataWidget;
-#endif
     QScrollArea* m_metaDataArea;
 
     PlacesItemModel* m_placesItemModel;