]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Use a saner check for multimedia files in infopanel.
authorMartin Sandsmark <martin.sandsmark@kde.org>
Thu, 9 Aug 2012 01:27:11 +0000 (03:27 +0200)
committerJekyll Wu <adaptee@gmail.com>
Thu, 9 Aug 2012 02:44:14 +0000 (10:44 +0800)
Don't rely on the reported supported mimetypes from Phonon,
Phonon supports more than just video and audio, but if it is
video or audio there's a very good chance Phonon supports it.

(If the mime type isn't in the list returned by Phonon there's
still a good chance it supports it, because mime types are stupid.)

BUG: 252539
FIXED-IN: 4.9.1

(cherry picked from commit 2fb4419de053c43a0a70ffb21920db687fa87b6e)

src/panels/information/informationpanelcontent.cpp

index c03a5a4e2497cc29591c016a91dfa7c923aaebe1..39ed1d2bdc52a5f70f087820390ba06f6fe06713 100644 (file)
@@ -197,9 +197,7 @@ void InformationPanelContent::showItem(const KFileItem& item)
 
     if (InformationPanelSettings::previewsShown()) {
         const QString mimeType = item.mimetype();
-        const bool usePhonon = Phonon::BackendCapabilities::isMimeTypeAvailable(mimeType) &&
-                               (mimeType != "image/png");  // TODO: workaround, as Phonon
-                                                           // thinks it supports PNG images
+        const bool usePhonon = mimeType.startsWith("audio/") || mimeType.startsWith("video/");
         if (usePhonon) {
             m_phononWidget->show();
             m_phononWidget->setUrl(item.targetUrl());