]> cloud.milkyroute.net Git - dolphin.git/commitdiff
[DolphinContextMenu] Fix excluding ourself from Open With menu
authorKai Uwe Broulik <kde@privat.broulik.de>
Wed, 21 Mar 2018 14:53:59 +0000 (15:53 +0100)
committerElvis Angelaccio <elvis.angelaccio@kde.org>
Sat, 24 Mar 2018 10:24:24 +0000 (11:24 +0100)
The desktop file name changed to org.kde.dolphin a long time ago. To avoid this breaking again, just use qApp->desktopFileName()

BUG: 391997

Differential Revision: https://phabricator.kde.org/D11540

src/dolphincontextmenu.cpp

index 4801aa3afc517aeaaa1ab87d9dd317dd657913a4..bedc835c2af7e04c3d9c139956d6f401de26fa7a 100644 (file)
@@ -474,7 +474,7 @@ void DolphinContextMenu::addServiceActions(KFileItemActions& fileItemActions)
     fileItemActions.setParentWidget(m_mainWindow);
 
     // insert 'Open With...' action or sub menu
-    fileItemActions.addOpenWithActionsTo(this, QStringLiteral("DesktopEntryName != 'dolphin'"));
+    fileItemActions.addOpenWithActionsTo(this, QStringLiteral("DesktopEntryName != '%1'").arg(qApp->desktopFileName()));
 
     // insert 'Actions' sub menu
     fileItemActions.addServiceActionsTo(this);