More logic fixes

svn path=/trunk/KDE/kdebase/apps/; revision=744490

diff --git a/src/dolphinsortfilterproxymodel.cpp b/src/dolphinsortfilterproxymodel.cpp
index ed84ef8f6861e46a5d6a0ea954ee24cc45adfe23..95fb3854d7f516c4ca89e70f14b890857351e982 100644 (file)
--- a/src/dolphinsortfilterproxymodel.cpp
+++ b/src/dolphinsortfilterproxymodel.cpp
@@ -105,9 +105,9 @@ int DolphinSortFilterProxyModel::compareCategories(const QModelIndex &left,
     switch (left.column()) {
 
     case DolphinView::SortByRating: {
     switch (left.column()) {
 
     case DolphinView::SortByRating: {

-        const quint32 leftRating = DolphinModel::ratingForIndex(left);
-        const quint32 rightRating = DolphinModel::ratingForIndex(right);
-        return leftRating > rightRating;
+        const qint32 leftRating = DolphinModel::ratingForIndex(left);
+        const qint32 rightRating = DolphinModel::ratingForIndex(right);
+        return leftRating - rightRating;

     }
 
     case DolphinView::SortByTags: {
     }
 
     case DolphinView::SortByTags: {


@@ -115,9 +115,9 @@ int DolphinSortFilterProxyModel::compareCategories(const QModelIndex &left,
         const QString rightTags = DolphinModel::tagsForIndex(right);
 
         if (leftTags.isEmpty() && !rightTags.isEmpty())
         const QString rightTags = DolphinModel::tagsForIndex(right);
 
         if (leftTags.isEmpty() && !rightTags.isEmpty())

-            return false;
+            return -1;

         else if (!leftTags.isEmpty() && rightTags.isEmpty())
         else if (!leftTags.isEmpty() && rightTags.isEmpty())

-            return true;
+            return 1;

 
         return naturalCompare(DolphinModel::tagsForIndex(left), DolphinModel::tagsForIndex(right)) < 0;
     }
 
         return naturalCompare(DolphinModel::tagsForIndex(left), DolphinModel::tagsForIndex(right)) < 0;
     }