]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Fix missing update of file name label in information panel without preview
authorStefan Brüns <stefan.bruens@rwth-aachen.de>
Thu, 18 Apr 2019 12:37:09 +0000 (14:37 +0200)
committerElvis Angelaccio <elvis.angelaccio@kde.org>
Sat, 20 Apr 2019 11:10:28 +0000 (13:10 +0200)
Summary:
The file name label was only updated when the preview was shown, after
the function was moved into a conditional section. This is a regression
caused by commit 405aa4878f75 ("[InformationPanel] Hide the video when the
preview is disabled, avoid computing the preview when it is disabled").

Test Plan:
Hide the preview in dolphin's information panel
Hover different files, the name label reflects the hovered file again

Reviewers: #dolphin, elvisangelaccio, meven, ngraham

Reviewed By: meven

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D20660

src/panels/information/informationpanelcontent.cpp

index e2b90dcc894da300810b0b6c250e3afe61c4765f..0eaa125f11906ce015180fd89be0aee882ba5177 100644 (file)
@@ -154,12 +154,12 @@ void InformationPanelContent::refreshPreview() {
         m_previewJob->kill();
     }
 
+    setNameLabelText(m_item.text());
     if (InformationPanelSettings::previewsShown()) {
         m_preview->show();
 
         const QUrl itemUrl = m_item.url();
         const bool isSearchUrl = itemUrl.scheme().contains(QStringLiteral("search")) && m_item.localPath().isEmpty();
-        setNameLabelText(m_item.text());
         if (isSearchUrl) {
             // in the case of a search-URL the URL is not readable for humans
             // (at least not useful to show in the Information Panel)