]> cloud.milkyroute.net Git - dolphin.git/commitdiff
settings: Fix memory leak in PanelSettingsPage constructor
authorlzwind lzwind <liuzheng@uniontech.com>
Tue, 29 Jul 2025 13:18:25 +0000 (13:18 +0000)
committerMéven Car <meven@kde.org>
Tue, 29 Jul 2025 13:18:25 +0000 (13:18 +0000)
Replace heap-allocated KFormat objects with stack-allocated formatter.
No functionality change.

src/settings/interface/panelsettingspage.cpp

index 3cd153656dd42acc5a29468f1e827e8a92482ed3..efa41e6c5c2ca37fed3844ad6c5e43d505dd5f0f 100644 (file)
@@ -28,8 +28,9 @@ PanelSettingsPage::PanelSettingsPage(QWidget *parent)
 {
     QFormLayout *topLayout = new QFormLayout(this);
 
 {
     QFormLayout *topLayout = new QFormLayout(this);
 
-    QString m_longDateTime = (new KFormat)->formatRelativeDateTime(QDateTime(QDate(2024, 02, 28), QTime(10, 0)), QLocale::LongFormat);
-    QString m_shortDateTime = (new KFormat)->formatRelativeDateTime(QDateTime(QDate(2024, 02, 28), QTime(10, 0)), QLocale::ShortFormat);
+    KFormat formatter;
+    QString m_longDateTime = formatter.formatRelativeDateTime(QDateTime(QDate(2024, 02, 28), QTime(10, 0)), QLocale::LongFormat);
+    QString m_shortDateTime = formatter.formatRelativeDateTime(QDateTime(QDate(2024, 02, 28), QTime(10, 0)), QLocale::ShortFormat);
 
     m_showPreview = new QCheckBox(i18nc("@option:check", "Show previews"), this);
     m_autoPlayMedia = new QCheckBox(i18nc("@option:check", "Auto-play media files"), this);
 
     m_showPreview = new QCheckBox(i18nc("@option:check", "Show previews"), this);
     m_autoPlayMedia = new QCheckBox(i18nc("@option:check", "Auto-play media files"), this);