Add const

diff --git a/src/settings/contextmenu/contextmenusettingspage.cpp b/src/settings/contextmenu/contextmenusettingspage.cpp
index 21929d56984e54d50162810806fd23eed61ada17..0723fee2ec52a2e282ebfeda9280c825c51fec2f 100644 (file)
--- a/src/settings/contextmenu/contextmenusettingspage.cpp
+++ b/src/settings/contextmenu/contextmenusettingspage.cpp
@@ -38,8 +38,8 @@ namespace
 }
 
 ContextMenuSettingsPage::ContextMenuSettingsPage(QWidget* parent,
 }
 
 ContextMenuSettingsPage::ContextMenuSettingsPage(QWidget* parent,

-                                                 KActionCollection* actions,
-                                                 QStringList actionIds) :
+                                                 const KActionCollection* actions,
+                                                 const QStringList& actionIds) :

     SettingsPageBase(parent),
     m_initialized(false),
     m_serviceModel(nullptr),
     SettingsPageBase(parent),
     m_initialized(false),
     m_serviceModel(nullptr),


@@ -230,8 +230,8 @@ void ContextMenuSettingsPage::showEvent(QShowEvent* event)
                ContextMenuSettings::showCopyMoveMenu());
 
         // Add other built-in actions
                ContextMenuSettings::showCopyMoveMenu());
 
         // Add other built-in actions

-        for (const QString& id : qAsConst(m_actionIds)) {
-            QAction* action = m_actions->action(id);
+        for (const QString& id : m_actionIds) {
+            const QAction* action = m_actions->action(id);

             if (action) {
                 addRow(action->icon().name(), action->text(), id, entryVisible(id));
             }
             if (action) {
                 addRow(action->icon().name(), action->text(), id, entryVisible(id));
             }

diff --git a/src/settings/contextmenu/contextmenusettingspage.h b/src/settings/contextmenu/contextmenusettingspage.h
index c35528935a8c006098ca486358eafbd43109f684..88b42770fbccf7cf36737005c04be3dcd9a7d3e3 100644 (file)
--- a/src/settings/contextmenu/contextmenusettingspage.h
+++ b/src/settings/contextmenu/contextmenusettingspage.h
@@ -25,7 +25,9 @@ class ContextMenuSettingsPage : public SettingsPageBase
     Q_OBJECT
 
 public:
     Q_OBJECT
 
 public:

-    explicit ContextMenuSettingsPage(QWidget* parent, KActionCollection* actions, QStringList actionIds);
+    explicit ContextMenuSettingsPage(QWidget* parent,
+                                     const KActionCollection* actions,
+                                     const QStringList& actionIds);

     ~ContextMenuSettingsPage() override;
 
     /** @see SettingsPageBase::applySettings() */
     ~ContextMenuSettingsPage() override;
 
     /** @see SettingsPageBase::applySettings() */


@@ -68,8 +70,8 @@ private:
     QListView* m_listView;
     QLineEdit *m_searchLineEdit;
     QStringList m_enabledVcsPlugins;
     QListView* m_listView;
     QLineEdit *m_searchLineEdit;
     QStringList m_enabledVcsPlugins;

-    KActionCollection* m_actions;
-    QStringList m_actionIds;
+    const KActionCollection* m_actions;
+    const QStringList m_actionIds;

 };
 
 #endif
 };
 
 #endif