]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Fix rubberband selection on icon in icon view mode
authorFelix Ernst <felixernst@kde.org>
Mon, 23 Oct 2023 14:26:52 +0000 (14:26 +0000)
committerFelix Ernst <felixernst@kde.org>
Mon, 23 Oct 2023 14:26:52 +0000 (14:26 +0000)
As an unintended side-effect of d9a18b04ea0b1b4e427f45083fdc0cdec87cbbfd
items would no longer be selected in icon view mode when the selection
rectangle intersected with the item's icon. This commit fixes this.

src/kitemviews/kitemlistcontroller.cpp

index 0016bb22aeb4fdf27f4c999ff3d6b7719a287ec1..5abf1830be349f2bd397e302920ffbfb3beef259 100644 (file)
@@ -1299,7 +1299,8 @@ void KItemListController::slotRubberBandChanged()
         if (widgetRect.intersects(rubberBandRect)) {
             // Select the full row intersecting with the rubberband rectangle
             const QRectF selectionRect = widget->selectionRect().translated(widgetRect.topLeft());
-            if (selectionRect.intersects(rubberBandRect)) {
+            const QRectF iconRect = widget->iconRect().translated(widgetRect.topLeft());
+            if (selectionRect.intersects(rubberBandRect) || iconRect.intersects(rubberBandRect)) {
                 selectedItems.insert(index);
             }
         }