]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Fix crash caused by a out-of-bounds access in KItemListViewAccessible::cell
authorEmmanuel Pescosta <emmanuelpescosta099@gmail.com>
Wed, 16 Mar 2016 20:16:44 +0000 (21:16 +0100)
committerEmmanuel Pescosta <emmanuelpescosta099@gmail.com>
Sat, 9 Apr 2016 12:08:53 +0000 (14:08 +0200)
BUG: 359738
FIXED-IN: 16.04.0
REVIEW: 127397

src/kitemviews/kitemlistviewaccessible.cpp

index f8630218f905a40fd538669ac2786cd1e2b37377..6f06e243e3ef0ac77360f806bcb57c763e6f9a07 100644 (file)
@@ -73,8 +73,10 @@ QAccessibleInterface* KItemListViewAccessible::cell(int index) const
         return 0;
     }
 
         return 0;
     }
 
-    if (m_cells.size() < index - 1)
+    if (m_cells.size() <= index) {
         m_cells.resize(childCount());
         m_cells.resize(childCount());
+    }
+    Q_ASSERT(index < m_cells.size());
 
     QAccessibleInterface* child = m_cells.at(index);
     if (!child) {
 
     QAccessibleInterface* child = m_cells.at(index);
     if (!child) {