]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Revert "Adapt autotest to new expected "Space" key behaviour"
authorFelix Ernst <fe.a.ernst@gmail.com>
Tue, 25 Apr 2023 13:13:43 +0000 (15:13 +0200)
committerFelix Ernst <fe.a.ernst@gmail.com>
Tue, 25 Apr 2023 13:19:09 +0000 (15:19 +0200)
This reverts commit df5cf6fe851021a73159fdd3487fe629c1ea8376.

The autotest was orginally changed to adapt to new behaviour when
the Space key is pressed. This change used to be implemented in
KItemListController which meant that the KItemListControllerTest
needed changing, but this is no longer the case.
Instead the new behaviour when the Space key is pressed is now
implemented further up the hierarchy, so the KItemListController
change could be reverted in
7b6a67e520c04f56b4b05fa26b252177398df6df and as such we can also
revert this autotest change.

src/tests/kitemlistcontrollertest.cpp

index a7842475a25e69476fa1e65d7952e969b9f30f15..d1a9cfc7c7980cee961f42f3ce3d2e013e8cc4b8 100644 (file)
@@ -321,8 +321,7 @@ void KItemListControllerTest::testKeyboardNavigation_data()
                              << qMakePair(KeyPress(Qt::Key_Enter), ViewState(0, KItemSet(), true))
                              << qMakePair(KeyPress(Qt::Key_Space, Qt::ControlModifier), ViewState(0, KItemSet() << 0))
                              << qMakePair(KeyPress(Qt::Key_Space, Qt::ControlModifier), ViewState(0, KItemSet()))
-                             << qMakePair(KeyPress(Qt::Key_Space), ViewState(0, KItemSet())) // This used to select, but we are now using it to trigger either
-                             // selection mode or "QuickLook". Ctrl+Space still works for selecting as expected.
+                             << qMakePair(KeyPress(Qt::Key_Space), ViewState(0, KItemSet() << 0))
                              << qMakePair(KeyPress(Qt::Key_E), ViewState(13, KItemSet() << 13))
                              << qMakePair(KeyPress(Qt::Key_Space), ViewState(14, KItemSet() << 14))
                              << qMakePair(KeyPress(Qt::Key_3), ViewState(15, KItemSet() << 15))