]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Change window title when searching
authorJulian Schraner <juliquadrat@gmail.com>
Sun, 3 Dec 2017 14:58:02 +0000 (07:58 -0700)
committerNathaniel Graham <pointedstick@zoho.com>
Sun, 3 Dec 2017 15:00:22 +0000 (08:00 -0700)
Summary:
When you search for a file (e.g. "hello world") the window title of Dolphin will now change to "Search for [input]" instead of "baloosearch - /".

BUG: 321575

Test Plan:
  - Disables it iself after search bar is hidden
  - Works with multiple word searches

Reviewers: #dolphin, ngraham, elvisangelaccio

Reviewed By: #dolphin, ngraham, elvisangelaccio

Subscribers: anthonyfieroni, elvisangelaccio, rkflx, emmanuelp, ngraham, #dolphin

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D8273

src/dolphinmainwindow.cpp
src/dolphinviewcontainer.cpp
src/dolphinviewcontainer.h

index de43bab4c2ca86f148a480d0d1cd58c87e5f497c..067d4a6e1d176d038f1dab966d8e4c14ad546d68 100644 (file)
@@ -1001,6 +1001,16 @@ void DolphinMainWindow::setUrlAsCaption(const QUrl& url)
         fileName = '/';
     }
 
+    if (m_activeViewContainer->isSearchModeEnabled()) {
+        if(m_activeViewContainer->currentSearchText().isEmpty()){
+            setWindowTitle(i18n("Empty Search"));
+        } else {
+            const auto searchText = i18n("Search for %1", m_activeViewContainer->currentSearchText());
+            setWindowTitle(searchText);
+        }
+        return;
+    }
+
     setWindowTitle(schemePrefix + fileName);
 }
 
index 36959a871e07c6fe08d6ea18678db5f6f3f4f51c..83b9f4343778235f303f6893324e4d288c28a5c2 100644 (file)
@@ -245,6 +245,11 @@ bool DolphinViewContainer::autoGrabFocus() const
     return m_autoGrabFocus;
 }
 
+QString DolphinViewContainer::currentSearchText() const
+{
+     return m_searchBox->text();
+}
+
 const DolphinStatusBar* DolphinViewContainer::statusBar() const
 {
     return m_statusBar;
index 877089e4c709dc23e69995c11f609b64092f694a..837b168d704c4fe1a939d068023274d59115e688 100644 (file)
@@ -93,6 +93,8 @@ public:
     void setAutoGrabFocus(bool grab);
     bool autoGrabFocus() const;
 
+    QString currentSearchText() const;
+
     const DolphinStatusBar* statusBar() const;
     DolphinStatusBar* statusBar();