Forward port: Don't grab the focus if the view did not have the focus already.

CCBUG: 261147
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1210659

diff --git a/src/views/dolphindetailsview.cpp b/src/views/dolphindetailsview.cpp
index dcde4b49676a631a99d229f6498f8237433a4cc5..12a2ba348f512d3c107e434639ad61e30171bb5a 100644 (file)
--- a/src/views/dolphindetailsview.cpp
+++ b/src/views/dolphindetailsview.cpp
@@ -158,9 +158,6 @@ DolphinDetailsView::DolphinDetailsView(QWidget* parent,
 
     KDirLister *dirLister = qobject_cast<KDirModel*>(proxyModel->sourceModel())->dirLister();
     connect(dirLister, SIGNAL(newItems(KFileItemList)), this, SLOT(resizeColumns()));
-
-    // setFocus() must be called after m_extensionsFactory is initialised (see bug 240374).
-    setFocus();
 }
 
 DolphinDetailsView::~DolphinDetailsView()

diff --git a/src/views/dolphiniconsview.cpp b/src/views/dolphiniconsview.cpp
index 522a9078779ba6b00d18ce5d209d00d5dbe9cca9..4abcad3db675b3de30a38667f7d14cdb4b87f1ee 100644 (file)
--- a/src/views/dolphiniconsview.cpp
+++ b/src/views/dolphiniconsview.cpp
@@ -126,9 +126,6 @@ DolphinIconsView::DolphinIconsView(QWidget* parent,
 
     updateGridSize(view->showPreview(), 0);
     m_extensionsFactory = new ViewExtensionsFactory(this, dolphinViewController, viewModeController);
-
-    // setFocus() must be called after m_extensionsFactory is initialised (see bug 240374).
-    setFocus();
 }
 
 DolphinIconsView::~DolphinIconsView()

diff --git a/src/views/dolphinview.cpp b/src/views/dolphinview.cpp
index 1e97d6864930adca8d65edd8249c776fdf9dc185..b02f794b313992cf2d837625ea2867e914664d74 100644 (file)
--- a/src/views/dolphinview.cpp
+++ b/src/views/dolphinview.cpp
@@ -1231,12 +1231,14 @@ void DolphinView::deleteView()
     if (view != 0) {
         disconnectViewAccessor();
 
-        // It's important to set the keyboard focus to the parent
-        // before deleting the view: Otherwise when having a split
-        // view the other view will get the focus and will request
-        // an activation (see DolphinView::eventFilter()).
-        setFocusProxy(0);
-        setFocus();
+        if (hasFocus()) {
+            // It's important to set the keyboard focus to the parent
+            // before deleting the view: Otherwise when having a split
+            // view the other view will get the focus and will request
+            // an activation (see DolphinView::eventFilter()).
+            setFocusProxy(0);
+            setFocus();
+        }
 
         m_viewModeController->disconnect(view);