]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Don't add trashSettingsPage to m_pages if null
authorKai Uwe Broulik <kde@privat.broulik.de>
Mon, 13 Feb 2017 12:51:05 +0000 (13:51 +0100)
committerKai Uwe Broulik <kde@privat.broulik.de>
Mon, 13 Feb 2017 12:51:05 +0000 (13:51 +0100)
Otherwise we might crash in applySettings() or restoreDefaults()

src/settings/dolphinsettingsdialog.cpp

index 5314c24ed845727b16d086629b2d02eacc1d70f4..50fd41e4c6b42bbfd5a2906e1bd1011a70f6d88f 100644 (file)
@@ -105,7 +105,9 @@ DolphinSettingsDialog::DolphinSettingsDialog(const QUrl& url, QWidget* parent) :
     m_pages.append(viewSettingsPage);
     m_pages.append(navigationSettingsPage);
     m_pages.append(servicesSettingsPage);
-    m_pages.append(trashSettingsPage);
+    if (trashSettingsPage) {
+        m_pages.append(trashSettingsPage);
+    }
     m_pages.append(generalSettingsPage);
 
     const KConfigGroup dialogConfig(KSharedConfig::openConfig(QStringLiteral("dolphinrc")), "SettingsDialog");