]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Remove unneeded code for toggeling dockwidget visibility
authorNicolas Fella <nicolas.fella@gmx.de>
Fri, 8 Mar 2024 17:46:32 +0000 (18:46 +0100)
committerMéven Car <meven.car@kdemail.net>
Fri, 8 Mar 2024 18:29:46 +0000 (18:29 +0000)
QDockWidget::toggleViewAction::toggled is emitted when minimizing
the application window on X11 (https://bugreports.qt.io/browse/QTBUG-48161
potentially related). This will cause the dockwidget to be hidden when
minimizing the window.

We don't actually seem to need that connection, triggering the action
(via shortcut or menu) seems to correctly show/hide the dockwidget
without it

BUG: 481952

src/dolphinmainwindow.cpp

index 03486a9cf69de0c570a0c2fc53483976d869ef55..1f4de8869ca8d8607994a3c012aa946b90c6a263 100644 (file)
@@ -2619,8 +2619,6 @@ void DolphinMainWindow::createPanelAction(const QIcon &icon, const QKeySequence
 
     QAction *panelAction = actionCollection()->addAction(actionName, dockAction);
     actionCollection()->setDefaultShortcut(panelAction, shortcut);
-
-    connect(panelAction, &QAction::toggled, dockWidget, &QWidget::setVisible);
 }
 // clang-format off
 void DolphinMainWindow::setupWhatsThis()