]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Replaced the ItemState structure with QPair<KFileItem, KVersionControlPlugin2::ItemVe...
authorEmmanuel Pescosta <emmanuelpescosta099@gmail.com>
Wed, 15 Oct 2014 15:42:42 +0000 (17:42 +0200)
committerEmmanuel Pescosta <emmanuelpescosta099@gmail.com>
Wed, 15 Oct 2014 15:42:42 +0000 (17:42 +0200)
src/views/versioncontrol/updateitemstatesthread.cpp
src/views/versioncontrol/versioncontrolobserver.cpp
src/views/versioncontrol/versioncontrolobserver.h

index 7b806a5926cc14b0f8d265bbfe551acf39af939b..4f0122e0f1db1431391dbca0e85c88bc19dcf74c 100644 (file)
@@ -57,12 +57,15 @@ void UpdateItemStatesThread::run()
             KVersionControlPlugin2* pluginV2 = qobject_cast<KVersionControlPlugin2*>(m_plugin);
             if (pluginV2) {
                 for (int i = 0; i < count; ++i) {
-                    items[i].version = pluginV2->itemVersion(items[i].item);
+                    const KFileItem& item = items.at(i).first;
+                    const KVersionControlPlugin2::ItemVersion version = pluginV2->itemVersion(item);
+                    items[i].second = version;
                 }
             } else {
                 for (int i = 0; i < count; ++i) {
-                    const KVersionControlPlugin::VersionState state = m_plugin->versionState(items[i].item);
-                    items[i].version = static_cast<KVersionControlPlugin2::ItemVersion>(state);
+                    const KFileItem& item = items.at(i).first;
+                    const KVersionControlPlugin::VersionState state = m_plugin->versionState(item);
+                    items[i].second = static_cast<KVersionControlPlugin2::ItemVersion>(state);
                 }
             }
         }
index c41803c161cab573ffffab9409bcedcf260fbafe..c7677de53dfccb9be5f9b283786c14d54a84d840 100644 (file)
@@ -205,9 +205,11 @@ void VersionControlObserver::slotThreadFinished()
         const QVector<ItemState>& items = it.value();
 
         foreach (const ItemState& item, items) {
+            const KFileItem& fileItem = item.first;
+            const KVersionControlPlugin2::ItemVersion version = item.second;
             QHash<QByteArray, QVariant> values;
-            values.insert("version", QVariant(item.version));
-            m_model->setData(m_model->index(item.item), values);
+            values.insert("version", QVariant(version));
+            m_model->setData(m_model->index(fileItem), values);
         }
     }
 
@@ -266,8 +268,8 @@ int VersionControlObserver::createItemStatesList(QMap<QString, QVector<ItemState
 
         if (expansionLevel == currentExpansionLevel) {
             ItemState itemState;
-            itemState.item = m_model->fileItem(index);
-            itemState.version = KVersionControlPlugin2::UnversionedVersion;
+            itemState.first = m_model->fileItem(index);
+            itemState.second = KVersionControlPlugin2::UnversionedVersion;
 
             items.append(itemState);
         } else if (expansionLevel > currentExpansionLevel) {
@@ -279,7 +281,7 @@ int VersionControlObserver::createItemStatesList(QMap<QString, QVector<ItemState
     }
 
     if (items.count() > 0) {
-        const KUrl& url = items.first().item.url();
+        const KUrl& url = items.first().first.url();
         itemStates.insert(url.directory(KUrl::AppendTrailingSlash), items);
     }
 
index 2c07b0614f1a8c376262e6f316083b47ad486dc4..562a599d2515ce1e97ab906f3cf144fc975b123c 100644 (file)
@@ -101,11 +101,7 @@ private slots:
     void slotThreadFinished();
 
 private:
-    struct ItemState
-    {
-        KFileItem item;
-        KVersionControlPlugin2::ItemVersion version;
-    };
+    typedef QPair<KFileItem, KVersionControlPlugin2::ItemVersion> ItemState;
 
     void updateItemStates();