]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Get rid of -Wdeprecated-copy warning
authorIsmael Asensio <isma.af@gmail.com>
Sun, 22 Dec 2019 16:46:48 +0000 (17:46 +0100)
committerIsmael Asensio <isma.af@gmail.com>
Sun, 12 Jan 2020 18:00:25 +0000 (19:00 +0100)
Summary:
Remove the explicit copy constructor of `KItemListStyleOption`, since it does not
add any logic to what the implicit copy constructor does, but triggers a compiler
warning if we don't overload `operator=` too.

Test Plan:
Compiles without `-Wdeprecated-copy` warning
No behavior changes

Reviewers: elvisangelaccio, #dolphin

Reviewed By: elvisangelaccio, #dolphin

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D26585

src/kitemviews/kitemliststyleoption.cpp
src/kitemviews/kitemliststyleoption.h

index bcfb86064b39182175d0234ed5d414efb87e4d49..84054aaacc0051c572ecfbaef4c327b6fd92980f 100644 (file)
@@ -35,21 +35,6 @@ KItemListStyleOption::KItemListStyleOption() :
 {
 }
 
-KItemListStyleOption::KItemListStyleOption(const KItemListStyleOption& other) :
-    rect(other.rect),
-    font(other.font),
-    fontMetrics(other.fontMetrics),
-    palette(other.palette),
-    padding(other.padding),
-    horizontalMargin(other.horizontalMargin),
-    verticalMargin(other.verticalMargin),
-    iconSize(other.iconSize),
-    extendedSelectionRegion(other.extendedSelectionRegion),
-    maxTextLines(other.maxTextLines),
-    maxTextWidth(other.maxTextWidth)
-{
-}
-
 KItemListStyleOption::~KItemListStyleOption()
 {
 }
index 93aafac1f53a9b3c027c97f0f68c47f572ec2eb8..381f4bbe50430c96776ea664834402d1abc6b638 100644 (file)
@@ -31,7 +31,6 @@ class DOLPHIN_EXPORT KItemListStyleOption
 {
 public:
     KItemListStyleOption();
-    KItemListStyleOption(const KItemListStyleOption& other);
     virtual ~KItemListStyleOption();
 
     QRect rect;
@@ -48,8 +47,6 @@ public:
 
     bool operator==(const KItemListStyleOption& other) const;
     bool operator!=(const KItemListStyleOption& other) const;
-
-
 };
 #endif