Allow moving items to trash also for non-local files

See bug 188032 for an ongoing discussion. In case if this behavior
is really not wanted by users (the feedback on bugs.kde.org will
show), the review-request
https://git.reviewboard.kde.org/r/104915/ should be merged too
(after adjusting some parts of the code).

diff --git a/src/dolphincontextmenu.cpp b/src/dolphincontextmenu.cpp
index 286d304c5217cf4034fe835b6413c655c2925cdb..670062250a86ba6ea322da1e5a03207d46e2a208 100644 (file)
--- a/src/dolphincontextmenu.cpp
+++ b/src/dolphincontextmenu.cpp
@@ -559,7 +559,7 @@ void DolphinContextMenu::updateRemoveAction()
 
 bool DolphinContextMenu::moveToTrash() const
 {
-    return selectedItemsProperties().isLocal() && !m_shiftPressed;
+    return !m_shiftPressed;
 }
 
 #include "dolphincontextmenu.moc"

diff --git a/src/dolphincontextmenu.h b/src/dolphincontextmenu.h
index 9e8b804cd4937c62a70f7a10347553b419d9a2aa..75a6e35e856dbc8cf55fa871f6d258250c6624a8 100644 (file)
--- a/src/dolphincontextmenu.h
+++ b/src/dolphincontextmenu.h
@@ -176,8 +176,8 @@ private:
     void updateRemoveAction();
 
     /**
-     * @return True if no shift key has been pressed and the selection represents
-     *         only local files.
+     * @return True if a moving to the trash should be done instead of
+     *         deleting the selected items.
      * @see updateRemoveAction(), slotRemoveActionTriggered()
      */
     bool moveToTrash() const;