]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Fixed empty files being erroneously grouped together with folders in "By size" grouping
authorZakhar Afonin <zakharafoniam@gmail.com>
Sat, 22 Jun 2024 12:49:07 +0000 (15:49 +0300)
committerZakhar Afonin <zakharafoniam@gmail.com>
Sat, 22 Jun 2024 12:49:07 +0000 (15:49 +0300)
src/kitemviews/kfileitemmodel.cpp

index 2133eef79e5fc57bc2a67d0184a791d82d7a3d8a..e7afa5288d937eec04f355302ecec6e6a76bb7ee 100644 (file)
@@ -2513,8 +2513,6 @@ KFileItemModel::ItemGroupInfo KFileItemModel::nameRoleGroup(const ItemData *item
 
 KFileItemModel::ItemGroupInfo KFileItemModel::sizeRoleGroup(const ItemData *itemData, bool withString) const
 {
-    static ItemGroupInfo oldGroupInfo;
-    static KIO::filesize_t oldFileSize;
     ItemGroupInfo groupInfo;
     KIO::filesize_t fileSize;
 
@@ -2529,9 +2527,6 @@ KFileItemModel::ItemGroupInfo KFileItemModel::sizeRoleGroup(const ItemData *item
             fileSize = itemData->values.value("size").toULongLong();
         }
     }
-    if (fileSize == oldFileSize) {
-        return oldGroupInfo;
-    }
     if (groupInfo.comparable < 0) {
         if (fileSize < 5 * 1024 * 1024) { // < 5 MB
             groupInfo.comparable = 1; // Small
@@ -2546,8 +2541,6 @@ KFileItemModel::ItemGroupInfo KFileItemModel::sizeRoleGroup(const ItemData *item
         char const *groupNames[] = {"Folders", "Small", "Medium", "Big"};
         groupInfo.text = i18nc("@title:group Size", groupNames[groupInfo.comparable]);
     }
-    oldFileSize = fileSize;
-    oldGroupInfo = groupInfo;
     return groupInfo;
 }