]> cloud.milkyroute.net Git - dolphin.git/commitdiff
kio-admin: Update risk dialog result check
authorMisha Vicha <waterpigcz@gmail.com>
Fri, 1 Aug 2025 13:19:53 +0000 (15:19 +0200)
committerMisha Vicha <waterpigcz@gmail.com>
Sat, 9 Aug 2025 14:54:08 +0000 (14:54 +0000)
The check now correctly considers only KMessageDialog::PrimaryAction as confirmation, where before closing the window (4 isn't KMessageDialog::Cancel anymore) would pass through and still ask for the root password even when the prompt was technically cancelled.

Also now correctly uses the Enum instead of a hardcoded integer.

src/admin/workerintegration.cpp

index 0bf6b2890ed4a4523fbcd742824132247caf3797..a6635749807306ae666647ef332fbb7b044a4a9b 100644 (file)
@@ -164,7 +164,7 @@ void WorkerIntegration::toggleActAsAdmin()
                                  KStandardGuiItem::cancel());
         warningDialog.setDontAskAgainText(i18nc("@option:check", "Do not warn me about these risks again"));
 
                                  KStandardGuiItem::cancel());
         warningDialog.setDontAskAgainText(i18nc("@option:check", "Do not warn me about these risks again"));
 
-        risksAccepted = warningDialog.exec() != 4 /* Cancel */;
+        risksAccepted = warningDialog.exec() == KMessageDialog::PrimaryAction;
         if (warningDialog.isDontAskAgainChecked()) {
             KMessageBox::saveDontShowAgainContinue(warningDontShowAgainName);
         }
         if (warningDialog.isDontAskAgainChecked()) {
             KMessageBox::saveDontShowAgainContinue(warningDontShowAgainName);
         }