]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Add a unit test for the basic selection-related functionality of
authorFrank Reininghaus <frank78ac@googlemail.com>
Mon, 29 Nov 2010 21:15:35 +0000 (21:15 +0000)
committerFrank Reininghaus <frank78ac@googlemail.com>
Mon, 29 Nov 2010 21:15:35 +0000 (21:15 +0000)
DolphinView. The main testing code is inside an abstract base
class. Three classes inherit this base class and do the actual testing
in one view mode each.

svn path=/trunk/KDE/kdebase/apps/; revision=1202157

src/tests/CMakeLists.txt
src/tests/dolphinviewtest_allviewmodes.cpp [new file with mode: 0644]
src/tests/dolphinviewtest_allviewmodes.h [new file with mode: 0644]
src/tests/dolphinviewtest_columns.cpp [new file with mode: 0644]
src/tests/dolphinviewtest_details.cpp [new file with mode: 0644]
src/tests/dolphinviewtest_icons.cpp [new file with mode: 0644]

index 0bf57665b91a741426b38a74ebdbf245a0416630..2dde5df81d8dacb05b777769e42f3ca8a76d161a 100644 (file)
@@ -6,3 +6,12 @@ target_link_libraries(dolphintreeviewtest dolphinprivate ${KDE4_KDEUI_LIBS} ${QT
 
 kde4_add_unit_test(dolphindetailsviewtest TEST dolphindetailsviewtest.cpp testbase.cpp ../views/zoomlevelinfo.cpp)
 target_link_libraries(dolphindetailsviewtest dolphinprivate ${KDE4_KIO_LIBS} ${QT_QTTEST_LIBRARY})
+
+kde4_add_unit_test(dolphinviewtest_icons TEST dolphinviewtest_icons.cpp dolphinviewtest_allviewmodes.cpp testbase.cpp)
+target_link_libraries(dolphinviewtest_icons dolphinprivate ${KDE4_KDEUI_LIBS} ${QT_QTTEST_LIBRARY})
+
+kde4_add_unit_test(dolphinviewtest_details TEST dolphinviewtest_details.cpp dolphinviewtest_allviewmodes.cpp testbase.cpp)
+target_link_libraries(dolphinviewtest_details dolphinprivate ${KDE4_KDEUI_LIBS} ${QT_QTTEST_LIBRARY})
+
+kde4_add_unit_test(dolphinviewtest_columns TEST dolphinviewtest_columns.cpp dolphinviewtest_allviewmodes.cpp testbase.cpp)
+target_link_libraries(dolphinviewtest_columns dolphinprivate ${KDE4_KDEUI_LIBS} ${QT_QTTEST_LIBRARY})
diff --git a/src/tests/dolphinviewtest_allviewmodes.cpp b/src/tests/dolphinviewtest_allviewmodes.cpp
new file mode 100644 (file)
index 0000000..710ed9d
--- /dev/null
@@ -0,0 +1,142 @@
+/***************************************************************************
+ *   Copyright (C) 2010 by Frank Reininghaus (frank78ac@googlemail.com)    *
+ *                                                                         *
+ *   This program is free software; you can redistribute it and/or modify  *
+ *   it under the terms of the GNU General Public License as published by  *
+ *   the Free Software Foundation; either version 2 of the License, or     *
+ *   (at your option) any later version.                                   *
+ *                                                                         *
+ *   This program is distributed in the hope that it will be useful,       *
+ *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
+ *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
+ *   GNU General Public License for more details.                          *
+ *                                                                         *
+ *   You should have received a copy of the GNU General Public License     *
+ *   along with this program; if not, write to the                         *
+ *   Free Software Foundation, Inc.,                                       *
+ *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA            *
+ ***************************************************************************/
+
+#include "dolphinviewtest_allviewmodes.h"
+
+#include <qtest_kde.h>
+
+#include "testbase.h"
+
+#include "views/dolphinview.h"
+#include "views/dolphinmodel.h"
+#include "views/dolphindirlister.h"
+#include "views/dolphinsortfilterproxymodel.h"
+
+#include <qtestmouse.h>
+#include <qtestkeyboard.h>
+
+DolphinViewTest_AllViewModes::DolphinViewTest_AllViewModes() {
+    // Need to register KFileItemList for use with QSignalSpy
+    qRegisterMetaType<KFileItemList>("KFileItemList");
+}
+
+void DolphinViewTest_AllViewModes::init() {
+    m_view->setMode(mode());
+    QVERIFY(verifyCorrectViewMode());
+    m_view->resize(200, 300);
+    m_view->show();
+    QTest::qWaitForWindowShown(m_view);
+}
+
+void DolphinViewTest_AllViewModes::cleanup() {
+    m_view->hide();
+    cleanupTestDir();
+}
+
+/**
+ * testSelection() checks the basic selection funtionality of DolphinView, including:
+ *
+ * selectedItems()
+ * selectedItemsCount()
+ * selectAll()
+ * invertSelection()
+ * clearSelection()
+ * hasSelection()
+ *
+ * and the signal selectionChanged(const KFileItemList& selection)
+ */
+
+Q_DECLARE_METATYPE(KFileItemList)
+
+void DolphinViewTest_AllViewModes::testSelection() {
+    const int totalItems = 50;
+
+    for (int i = 0; i < totalItems; i++) {
+        createFile(QString("%1").arg(i));
+    }
+    reloadViewAndWait();
+
+    // Start with an empty selection
+    m_view->clearSelection();
+
+    QCOMPARE(m_view->selectedItems().count(), 0);
+    QCOMPARE(m_view->selectedItemsCount(), 0);
+    QVERIFY(!m_view->hasSelection());
+
+    // First some simple tests where either all or no items are selected
+    m_view->selectAll();
+    verifySelectedItemsCount(totalItems);
+
+    m_view->invertSelection();
+    verifySelectedItemsCount(0);
+
+    m_view->invertSelection();
+    verifySelectedItemsCount(totalItems);
+
+    m_view->clearSelection();
+    verifySelectedItemsCount(0);
+
+    // Now we select individual items using mouse clicks
+    QModelIndex index = itemView()->model()->index(2, 0);
+    itemView()->scrollTo(index);
+    QTest::mouseClick(itemView()->viewport(), Qt::LeftButton, Qt::ControlModifier, itemView()->visualRect(index).center());
+    verifySelectedItemsCount(1);
+
+    index = itemView()->model()->index(45, 0);
+    itemView()->scrollTo(index);
+    QTest::mouseClick(itemView()->viewport(), Qt::LeftButton, Qt::ControlModifier, itemView()->visualRect(index).center());
+    verifySelectedItemsCount(2);
+
+    index = itemView()->model()->index(48, 0);
+    itemView()->scrollTo(index);
+    QTest::mouseClick(itemView()->viewport(), Qt::LeftButton, Qt::ShiftModifier, itemView()->visualRect(index).center());
+    verifySelectedItemsCount(5);
+}
+
+/**
+ * verifySelectedItemsCount(int) waits until the DolphinView's selectionChanged(const KFileItemList&)
+ * signal is received and checks that the selection state of the view is as expected.
+ */
+
+void DolphinViewTest_AllViewModes::verifySelectedItemsCount(int itemsCount) const
+{
+    QSignalSpy spySelectionChanged(m_view, SIGNAL(selectionChanged(const KFileItemList&)));
+    QTest::kWaitForSignal(m_view, SIGNAL(selectionChanged(const KFileItemList&)));
+
+    QCOMPARE(m_view->selectedItems().count(), itemsCount);
+    QCOMPARE(m_view->selectedItemsCount(), itemsCount);
+    QCOMPARE(spySelectionChanged.count(), 1);
+    QCOMPARE(qvariant_cast<KFileItemList>(spySelectionChanged.at(0).at(0)).count(), itemsCount);
+    if (itemsCount != 0) {
+        QVERIFY(m_view->hasSelection());
+    }
+    else {
+        if (mode() == DolphinView::ColumnView &&
+            itemView()->selectionModel()->selectedIndexes().count() == 0 &&
+            itemView()->selectionModel()->hasSelection()) {
+            QEXPECT_FAIL("",
+                         "The selection model's hasSelection() method returns true, but there are no selected indexes. Needs to be investigated.",
+                         Continue);
+        }
+
+        QVERIFY(!m_view->hasSelection());
+    }
+}
+
+#include "dolphinviewtest_allviewmodes.moc"
diff --git a/src/tests/dolphinviewtest_allviewmodes.h b/src/tests/dolphinviewtest_allviewmodes.h
new file mode 100644 (file)
index 0000000..59df22f
--- /dev/null
@@ -0,0 +1,69 @@
+/***************************************************************************
+ *   Copyright (C) 2010 by Frank Reininghaus (frank78ac@googlemail.com)    *
+ *                                                                         *
+ *   This program is free software; you can redistribute it and/or modify  *
+ *   it under the terms of the GNU General Public License as published by  *
+ *   the Free Software Foundation; either version 2 of the License, or     *
+ *   (at your option) any later version.                                   *
+ *                                                                         *
+ *   This program is distributed in the hope that it will be useful,       *
+ *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
+ *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
+ *   GNU General Public License for more details.                          *
+ *                                                                         *
+ *   You should have received a copy of the GNU General Public License     *
+ *   along with this program; if not, write to the                         *
+ *   Free Software Foundation, Inc.,                                       *
+ *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA            *
+ ***************************************************************************/
+
+#ifndef DOLPHINVIEWTEST_ALLVIEWMODES
+#define DOLPHINVIEWTEST_ALLVIEWMODES
+
+#include "testbase.h"
+
+#include "views/dolphinview.h"
+
+/**
+ * DolphinViewTest_AllViewModes is used as a base class for tests that check the
+ * basic functionality of DolphinView in all view modes. The derived classes
+ * have to provide implementations for the virtual methods mode() and verifyCorrectViewMode(),
+ * see below.
+ *
+ * Tests for DolphinView functionality that is specific to a particular view mode or
+ * to switching between different view modes should not be added here, but to another
+ * DolphinView unit test.
+ */
+
+class DolphinViewTest_AllViewModes : public TestBase
+{
+    Q_OBJECT
+
+public:
+
+    DolphinViewTest_AllViewModes();
+
+private slots:
+
+    void init();
+    void cleanup();
+
+    void testSelection();
+
+public:
+
+    /** Returns the view mode (Icons, Details, Columns) to be used in the test. */
+    virtual DolphinView::Mode mode() const = 0;
+
+    /** Should return true if the view mode is correct. */
+    virtual bool verifyCorrectViewMode() const = 0;
+
+    /**
+     * Waits for the DolphinView's selectionChanged(const KFileItemList&) to be emitted
+     * and verifies that the number of selected items is as expected.
+     */
+    void verifySelectedItemsCount(int) const;
+
+};
+
+#endif
diff --git a/src/tests/dolphinviewtest_columns.cpp b/src/tests/dolphinviewtest_columns.cpp
new file mode 100644 (file)
index 0000000..398446f
--- /dev/null
@@ -0,0 +1,42 @@
+/***************************************************************************
+ *   Copyright (C) 2010 by Frank Reininghaus (frank78ac@googlemail.com)    *
+ *                                                                         *
+ *   This program is free software; you can redistribute it and/or modify  *
+ *   it under the terms of the GNU General Public License as published by  *
+ *   the Free Software Foundation; either version 2 of the License, or     *
+ *   (at your option) any later version.                                   *
+ *                                                                         *
+ *   This program is distributed in the hope that it will be useful,       *
+ *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
+ *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
+ *   GNU General Public License for more details.                          *
+ *                                                                         *
+ *   You should have received a copy of the GNU General Public License     *
+ *   along with this program; if not, write to the                         *
+ *   Free Software Foundation, Inc.,                                       *
+ *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA            *
+ ***************************************************************************/
+
+#include <qtest_kde.h>
+
+#include "dolphinviewtest_allviewmodes.h"
+
+class DolphinViewTest_Columns : public DolphinViewTest_AllViewModes
+{
+    Q_OBJECT
+
+public:
+
+    virtual DolphinView::Mode mode() const {
+        return DolphinView::ColumnView;
+    }
+
+    virtual bool verifyCorrectViewMode() const {
+        return (m_view->mode() == DolphinView::ColumnView);
+    }
+
+};
+
+QTEST_KDEMAIN(DolphinViewTest_Columns, GUI)
+
+#include "dolphinviewtest_columns.moc"
diff --git a/src/tests/dolphinviewtest_details.cpp b/src/tests/dolphinviewtest_details.cpp
new file mode 100644 (file)
index 0000000..c3c950a
--- /dev/null
@@ -0,0 +1,42 @@
+/***************************************************************************
+ *   Copyright (C) 2010 by Frank Reininghaus (frank78ac@googlemail.com)    *
+ *                                                                         *
+ *   This program is free software; you can redistribute it and/or modify  *
+ *   it under the terms of the GNU General Public License as published by  *
+ *   the Free Software Foundation; either version 2 of the License, or     *
+ *   (at your option) any later version.                                   *
+ *                                                                         *
+ *   This program is distributed in the hope that it will be useful,       *
+ *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
+ *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
+ *   GNU General Public License for more details.                          *
+ *                                                                         *
+ *   You should have received a copy of the GNU General Public License     *
+ *   along with this program; if not, write to the                         *
+ *   Free Software Foundation, Inc.,                                       *
+ *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA            *
+ ***************************************************************************/
+
+#include <qtest_kde.h>
+
+#include "dolphinviewtest_allviewmodes.h"
+
+class DolphinViewTest_Details : public DolphinViewTest_AllViewModes
+{
+    Q_OBJECT
+
+public:
+
+    virtual DolphinView::Mode mode() const {
+        return DolphinView::DetailsView;
+    }
+
+    virtual bool verifyCorrectViewMode() const {
+        return (m_view->mode() == DolphinView::DetailsView);
+    }
+
+};
+
+QTEST_KDEMAIN(DolphinViewTest_Details, GUI)
+
+#include "dolphinviewtest_details.moc"
diff --git a/src/tests/dolphinviewtest_icons.cpp b/src/tests/dolphinviewtest_icons.cpp
new file mode 100644 (file)
index 0000000..e90e31c
--- /dev/null
@@ -0,0 +1,42 @@
+/***************************************************************************
+ *   Copyright (C) 2010 by Frank Reininghaus (frank78ac@googlemail.com)    *
+ *                                                                         *
+ *   This program is free software; you can redistribute it and/or modify  *
+ *   it under the terms of the GNU General Public License as published by  *
+ *   the Free Software Foundation; either version 2 of the License, or     *
+ *   (at your option) any later version.                                   *
+ *                                                                         *
+ *   This program is distributed in the hope that it will be useful,       *
+ *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
+ *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
+ *   GNU General Public License for more details.                          *
+ *                                                                         *
+ *   You should have received a copy of the GNU General Public License     *
+ *   along with this program; if not, write to the                         *
+ *   Free Software Foundation, Inc.,                                       *
+ *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA            *
+ ***************************************************************************/
+
+#include <qtest_kde.h>
+
+#include "dolphinviewtest_allviewmodes.h"
+
+class DolphinViewTest_Icons : public DolphinViewTest_AllViewModes
+{
+    Q_OBJECT
+
+public:
+
+    virtual DolphinView::Mode mode() const {
+        return DolphinView::IconsView;
+    }
+
+    virtual bool verifyCorrectViewMode() const {
+        return (m_view->mode() == DolphinView::IconsView);
+    }
+
+};
+
+QTEST_KDEMAIN(DolphinViewTest_Icons, GUI)
+
+#include "dolphinviewtest_icons.moc"