]> cloud.milkyroute.net Git - dolphin.git/commitdiff
When the previewed video stops playing (because of the user or because the media...
authorMéven Car <meven29@gmail.com>
Sun, 17 Mar 2019 20:21:33 +0000 (21:21 +0100)
committerMéven Car <meven29@gmail.com>
Sun, 17 Mar 2019 20:22:54 +0000 (21:22 +0100)
Summary:
Bug result after test plan :

{F6698812}

Test Plan:
In dolphin with the information panel
Select a video
Play the video
Disable the preview through the context menu (the video stays playing and visible and this will get fixed in a subsequent review)
Stop the video -> the video preview reappears when it should not

Reviewers: elvisangelaccio

Reviewed By: elvisangelaccio

Subscribers: elvisangelaccio, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D19843

src/panels/information/informationpanelcontent.cpp

index 7704bdf165942d2fe5d1299f923299efc908280a..4b34e55e32b5164d349f8f1d4ea42d9c282413ec 100644 (file)
@@ -300,7 +300,7 @@ KFileItemList InformationPanelContent::items() {
 
 void InformationPanelContent::slotHasVideoChanged(bool hasVideo)
 {
-    m_preview->setVisible(!hasVideo);
+    m_preview->setVisible(InformationPanelSettings::previewsShown() && !hasVideo);
 }
 
 void InformationPanelContent::refreshMetaData()