Fix FIFO usage

`m_propriorityQueue` and `m_queue` are used as FIFO queues, so we need
to use `takeFirst()` instead of `takeLast()` when removing elements
from the queue.

While at it, add a comment so that we will remember these are FIFO
queues.

diff --git a/src/kitemviews/private/kdirectorycontentscounter.cpp b/src/kitemviews/private/kdirectorycontentscounter.cpp
index 05a6ff447465cf69853acf4f364728f2b6c954b8..4d6a4861ca10ef3f3f69b7d0f0696ae18f3640e1 100644 (file)
--- a/src/kitemviews/private/kdirectorycontentscounter.cpp
+++ b/src/kitemviews/private/kdirectorycontentscounter.cpp
@@ -104,7 +104,7 @@ void KDirectoryContentsCounter::slotResult(const QString& path, int count, long
     }
 
     if (!m_priorityQueue.isEmpty()) {
-        startWorker(m_priorityQueue.takeLast());
+        startWorker(m_priorityQueue.takeFirst());
     } else if (!m_queue.isEmpty()) {
         startWorker(m_queue.takeFirst());
     }

diff --git a/src/kitemviews/private/kdirectorycontentscounter.h b/src/kitemviews/private/kdirectorycontentscounter.h
index 01bf3077917138749e5b4782c433093a2110f528..65c4bcb1babc52e19c8012655204824512573d71 100644 (file)
--- a/src/kitemviews/private/kdirectorycontentscounter.h
+++ b/src/kitemviews/private/kdirectorycontentscounter.h
@@ -72,6 +72,7 @@ private:
 private:
     KFileItemModel* m_model;
 
+    // Used as FIFO queues.
     QLinkedList<QString> m_priorityQueue;
     QLinkedList<QString> m_queue;