Fix mouse back/forward buttons

We need to emit mouseButtonPressed (now in the onPress method) before the
check needed to not select items on back/foward mouse button press events.

diff --git a/src/kitemviews/kitemlistcontroller.cpp b/src/kitemviews/kitemlistcontroller.cpp
index 650bf628693f54e9cd238f32461fa6bf9144dee9..1733eeab5fb3b50a405ded9a4f24b6550288e1d0 100644 (file)
--- a/src/kitemviews/kitemlistcontroller.cpp
+++ b/src/kitemviews/kitemlistcontroller.cpp
@@ -550,17 +550,19 @@ bool KItemListController::mousePressEvent(QGraphicsSceneMouseEvent* event, const
     m_pressedMousePos = transform.map(event->pos());
     m_pressedIndex = m_view->itemAt(m_pressedMousePos);
 
     m_pressedMousePos = transform.map(event->pos());
     m_pressedIndex = m_view->itemAt(m_pressedMousePos);
 

-    if (event->buttons() & (Qt::BackButton | Qt::ForwardButton)) {
-        // Do not select items when clicking the back/forward buttons, see
-        // https://bugs.kde.org/show_bug.cgi?id=327412.
-        return true;
-    }
-

     const Qt::MouseButtons buttons = event->buttons();
     const Qt::MouseButtons buttons = event->buttons();

+

     if (!onPress(event->screenPos(), event->pos(), event->modifiers(), buttons)) {
         startRubberBand();
         return false;
     }
     if (!onPress(event->screenPos(), event->pos(), event->modifiers(), buttons)) {
         startRubberBand();
         return false;
     }

+
+    if (buttons & (Qt::BackButton | Qt::ForwardButton)) {
+        // Do not select items when clicking the back/forward buttons, see
+        // https://bugs.kde.org/show_bug.cgi?id=327412.
+        return true;
+    }
+

     return true;
 }
 
     return true;
 }