]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Disable keyboard accelerators for the tabs widget
authorAlex Miranda <amdev1@yandex.com>
Mon, 21 Oct 2019 19:39:30 +0000 (21:39 +0200)
committerElvis Angelaccio <elvis.angelaccio@kde.org>
Mon, 21 Oct 2019 19:39:30 +0000 (21:39 +0200)
Summary:
Now that there are actions for switching to a specific tab with default
Alt + <number> shortcuts, automatically assigned keyboard accelerators
can result in ambiguous shortcuts when using specific tab names
containing numbers.

Not adding any accelerators for the tabs widget ensures the default
shortcuts work reliably regardless of tab names.

Test Plan:
- Verify there are no ambiguous shortcuts when browsing folders with
names containing only numbers
- Verify other keyboard accelerators still work (menu bar, context menu
and others)

Reviewers: #vdg, #dolphin, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D24794

src/dolphintabwidget.cpp

index 0408d7ed47304dfead6ad8a9f35b58124bc20972..9ecc14427a7f944844a465c79d6a5a63b76f259e 100644 (file)
@@ -28,6 +28,7 @@
 #include <KRun>
 #include <KShell>
 #include <kio/global.h>
+#include <KAcceleratorManager>
 
 #include <QApplication>
 #include <QDropEvent>
@@ -37,6 +38,8 @@ DolphinTabWidget::DolphinTabWidget(QWidget* parent) :
     m_placesSelectorVisible(true),
     m_lastViewedTab(0)
 {
+    KAcceleratorManager::setNoAccel(this);
+
     connect(this, &DolphinTabWidget::tabCloseRequested,
             this, QOverload<int>::of(&DolphinTabWidget::closeTab));
     connect(this, &DolphinTabWidget::currentChanged,