]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Allow dolphin to format DateTime at later stage than KBalooRolesProvider
authorMéven Car <meven29@gmail.com>
Tue, 12 Nov 2019 12:48:32 +0000 (13:48 +0100)
committerMéven Car <meven29@gmail.com>
Tue, 12 Nov 2019 12:50:18 +0000 (13:50 +0100)
Summary:
KFileItemListWidgetInformant::roleText expected imageDateTime value to be a QDateTime but KBalooRolesProvider formatted it to QString previously, preventing KFileItemListWidgetInformant::roleText to format properly the imageDateTime

BUG: 411173

Reviewers: #dolphin, ngraham, elvisangelaccio

Reviewed By: #dolphin, ngraham

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D25242

src/kitemviews/private/kbaloorolesprovider.cpp

index 8a2a64b31d5fdce3044cb7f193787fb6c03e09fd..0f7100faae197d6217bf700d90d82ca149e4bf1c 100644 (file)
@@ -81,7 +81,12 @@ QHash<QByteArray, QVariant> KBalooRolesProvider::roleValues(const Baloo::File& f
             std::for_each(rangeBegin, rangeEnd, [&list](const entry& s) { list.append(s.second); });
             values.insert(role, propertyInfo.formatAsDisplayString(list));
         } else {
-            values.insert(role, propertyInfo.formatAsDisplayString((*rangeBegin).second));
+            if (propertyInfo.valueType() == QVariant::DateTime) {
+                // Let dolphin format later Dates
+                values.insert(role, (*rangeBegin).second);
+            } else {
+                values.insert(role, propertyInfo.formatAsDisplayString((*rangeBegin).second));
+            }
         }
         rangeBegin = rangeEnd;
     }