]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Do not build KNS installer and KNS button on Windows
authorAlexander Lohnau <alexander.lohnau@gmx.de>
Wed, 26 Aug 2020 07:59:26 +0000 (09:59 +0200)
committerElvis Angelaccio <elvis.angelaccio@kde.org>
Mon, 31 Aug 2020 16:57:03 +0000 (16:57 +0000)
src/CMakeLists.txt
src/settings/services/servicessettingspage.cpp

index 0708a2a30ac5579b26e27d911d6f635874d5e090..80dbfd042da03674b2641501207506790f286a61 100644 (file)
@@ -391,7 +391,10 @@ install(TARGETS kcm_dolphinnavigation DESTINATION ${KDE_INSTALL_PLUGINDIR} )
 install(TARGETS kcm_dolphinservices DESTINATION ${KDE_INSTALL_PLUGINDIR} )
 install(TARGETS kcm_dolphingeneral DESTINATION ${KDE_INSTALL_PLUGINDIR} )
 
-add_subdirectory(settings/services/servicemenuinstaller)
+if(NOT WIN32)
+    add_subdirectory(settings/services/servicemenuinstaller)
+    install( FILES settings/services/servicemenu.knsrc DESTINATION ${KDE_INSTALL_KNSRCDIR} )
+endif()
 
 ########### install files ###############
 
@@ -415,7 +418,6 @@ install( FILES settings/kcm/kcmdolphinviewmodes.desktop DESTINATION ${KDE_INSTAL
 install( FILES settings/kcm/kcmdolphinnavigation.desktop DESTINATION ${KDE_INSTALL_KSERVICES5DIR} )
 install( FILES settings/kcm/kcmdolphinservices.desktop DESTINATION ${KDE_INSTALL_KSERVICES5DIR} )
 install( FILES settings/kcm/kcmdolphingeneral.desktop DESTINATION ${KDE_INSTALL_KSERVICES5DIR} )
-install( FILES settings/services/servicemenu.knsrc DESTINATION ${KDE_INSTALL_KNSRCDIR} )
 
 if(BUILD_TESTING)
     find_package(Qt5Test ${QT_MIN_VERSION} CONFIG REQUIRED)
index 46810768f29e16e74c922e5018d8f512d1b8e9b2..b7a9624b6a7bf75ac9981d579a542eb83e9fb274 100644 (file)
@@ -69,15 +69,19 @@ ServicesSettingsPage::ServicesSettingsPage(QWidget* parent) :
     m_listView->setVerticalScrollMode(QListView::ScrollPerPixel);
     connect(m_listView, &QListView::clicked, this, &ServicesSettingsPage::changed);
 
+#ifndef Q_OS_WIN
     auto *downloadButton = new KNS3::Button(i18nc("@action:button", "Download New Services..."),
                                                   QStringLiteral("servicemenu.knsrc"),
                                                   this);
     connect(downloadButton, &KNS3::Button::dialogFinished, this, &ServicesSettingsPage::loadServices);
+#endif
 
     topLayout->addWidget(label);
     topLayout->addWidget(m_searchLineEdit);
     topLayout->addWidget(m_listView);
+#ifndef Q_OS_WIN
     topLayout->addWidget(downloadButton);
+#endif
 
     m_enabledVcsPlugins = VersionControlSettings::enabledPlugins();
     std::sort(m_enabledVcsPlugins.begin(), m_enabledVcsPlugins.end());