Fix regression introduced by an obviously untested "krazy fix" (r973284). Setting a

QVariant to QString() is not the same as calling clear on the QVariant (which makes the variant invalid).
(BUG 194502)

svn path=/trunk/KDE/kdebase/apps/; revision=994217

diff --git a/src/dolphinmodel.cpp b/src/dolphinmodel.cpp
index f37452c80dbf938459916f4419876aaa582ecf34..819b37d2a2a52f28655bd9a1d55fd49023bb14bd 100644 (file)
--- a/src/dolphinmodel.cpp
+++ b/src/dolphinmodel.cpp
@@ -411,7 +411,8 @@ QVariant DolphinModel::sortRoleData(const QModelIndex& index) const
 
     case KDirModel::Type:
         if (item.isDir()) {
 
     case KDirModel::Type:
         if (item.isDir()) {

-            retVariant.clear(); // when sorting we want folders to be placed first
+            // when sorting we want folders to be placed first
+            retVariant = QString(); // krazy:exclude=nullstrassign

         } else {
             retVariant = item.mimeComment();
         }
         } else {
             retVariant = item.mimeComment();
         }