Fix all krazy #include warnings

- "include own header first line"
- "put config.h in angle brackets line"
- "do not include QtModule/QtClass line"

`QElapsedTimer` was implicitly included by
kfileitemmodelsortalgorithm.h, now we need to explicitly include it in
kfileitemmodel.cpp.

We also need to explicitly link to `Qt5::Concurrent`, otherwise we
cannot `#include <QtConcurrentRun>`.

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index e1b63358dcf024d08150a2a617514c65aaa984eb..9a8302ff14e83549843c339657e5f6fbed3838c5 100644 (file)
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -137,6 +137,7 @@ generate_export_header(dolphinprivate BASE_NAME dolphin)
 target_link_libraries(
     dolphinprivate PUBLIC
     dolphinvcs
+    Qt5::Concurrent
     Qt5::Gui
     KF5::Crash
     KF5::I18n

diff --git a/src/global.cpp b/src/global.cpp
index 20dee00fa73ed384d53375abb7c39521793bdce6..d0e477bc8d1b3ab22142615fbea8223b3aaf1906 100644 (file)
--- a/src/global.cpp
+++ b/src/global.cpp
@@ -17,16 +17,15 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
-#include <QApplication>
-#include <QIcon>
-
-#include <KRun>
-
 #include "global.h"
 #include "dolphindebug.h"
-
 #include "dolphin_generalsettings.h"
 
+#include <KRun>
+
+#include <QApplication>
+#include <QIcon>
+
 QList<QUrl> Dolphin::validateUris(const QStringList& uriList)
 {
     const QString currentDir = QDir::currentPath();

diff --git a/src/kitemviews/kfileitemmodel.cpp b/src/kitemviews/kfileitemmodel.cpp
index a5422a7bf5280f703002e5979c2cf58ef99c12f8..8c736ccfe50f1425fe590becefc69a70e744e571 100644 (file)
--- a/src/kitemviews/kfileitemmodel.cpp
+++ b/src/kitemviews/kfileitemmodel.cpp
@@ -31,6 +31,7 @@
 #include "private/kfileitemmodelsortalgorithm.h"
 #include "private/kfileitemmodeldirlister.h"
 
+#include <QElapsedTimer>
 #include <QMimeData>
 #include <QTimer>
 #include <QWidget>

diff --git a/src/kitemviews/kitemlistviewaccessible.h b/src/kitemviews/kitemlistviewaccessible.h
index 674d98ee631ef7f889fa307c31ab29eb7fa8dc9f..fdc3ff1a3a73adaeae3854019bd3001e32c5b816 100644 (file)
--- a/src/kitemviews/kitemlistviewaccessible.h
+++ b/src/kitemviews/kitemlistviewaccessible.h
@@ -24,10 +24,10 @@
 
 #include "dolphin_export.h"
 
-#include <QtCore/qpointer.h>
-#include <qaccessible.h>
-#include <qaccessibleobject.h>
-#include <QtWidgets/qaccessiblewidget.h>
+#include <QAccessible>
+#include <QAccessibleObject>
+#include <QAccessibleWidget>
+#include <QPointer>
 
 class KItemListView;
 class KItemListContainer;

diff --git a/src/kitemviews/private/kfileitemmodelsortalgorithm.h b/src/kitemviews/private/kfileitemmodelsortalgorithm.h
index 7c090db91016278e2b64ef8ec3e4fdd7733c3e99..ff484a7e8bbc049fe953f7f03db4db2dc8bb38c8 100644 (file)
--- a/src/kitemviews/private/kfileitemmodelsortalgorithm.h
+++ b/src/kitemviews/private/kfileitemmodelsortalgorithm.h
@@ -22,7 +22,7 @@
 #ifndef KFILEITEMMODELSORTALGORITHM_H
 #define KFILEITEMMODELSORTALGORITHM_H
 
-#include <QtConcurrent/QtConcurrent>
+#include <QtConcurrentRun>
 
 #include <algorithm>
 

diff --git a/src/panels/information/filemetadataconfigurationdialog.h b/src/panels/information/filemetadataconfigurationdialog.h
index 8ca9ef6febf50033f4eafd0de85df6589ee97760..912fadadc07339ae21345921b63c47ad79fc15dc 100644 (file)
--- a/src/panels/information/filemetadataconfigurationdialog.h
+++ b/src/panels/information/filemetadataconfigurationdialog.h
@@ -22,7 +22,7 @@
 
 #include <QDialog>
 #include <KFileItem>
-#include "config-baloo.h"
+#include <config-baloo.h>
 
 #ifndef HAVE_BALOO
 class KFileMetaDataConfigurationWidget;

diff --git a/src/panels/information/informationpanelcontent.h b/src/panels/information/informationpanelcontent.h
index 8b143af1d6f72c903f9b7b1da0e71ab31ef8b5c9..a6c2b56228bfd2edc6bc09da04f7a1b90c2de2b4 100644 (file)
--- a/src/panels/information/informationpanelcontent.h
+++ b/src/panels/information/informationpanelcontent.h
@@ -20,10 +20,11 @@
 #ifndef INFORMATIONPANELCONTENT_H
 #define INFORMATIONPANELCONTENT_H
 
-#include "config-baloo.h"
+#include <config-baloo.h>
+
 #include <KFileItem>
-#include <QUrl>
 
+#include <QUrl>
 #include <QPointer>
 #include <QWidget>
 

diff --git a/src/statusbar/mountpointobserver.cpp b/src/statusbar/mountpointobserver.cpp
index df2a4898fdfa515955b3357ac19687733c28f21c..fa6472c0a7e191618f6a496341a9b271256e90c5 100644 (file)
--- a/src/statusbar/mountpointobserver.cpp
+++ b/src/statusbar/mountpointobserver.cpp
@@ -17,11 +17,11 @@
  *   51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA          *
  ***************************************************************************/
 
-#include <KIO/FileSystemFreeSpaceJob>
-
 #include "mountpointobserver.h"
 #include "mountpointobservercache.h"
 
+#include <KIO/FileSystemFreeSpaceJob>
+
 MountPointObserver::MountPointObserver(const QUrl& url, QObject* parent) :
     QObject(parent),
     m_url(url),

diff --git a/src/views/tooltips/dolphinfilemetadatawidget.h b/src/views/tooltips/dolphinfilemetadatawidget.h
index 3017ef5ced93605decf1ff5ef686e4906f551004..e7459b19722280c4312d43a564a08296599da998 100644 (file)
--- a/src/views/tooltips/dolphinfilemetadatawidget.h
+++ b/src/views/tooltips/dolphinfilemetadatawidget.h
@@ -23,7 +23,7 @@
 #define DOLPHINFILEMETADATAWIDGET_H
 
 #include <QWidget>
-#include "config-baloo.h"
+#include <config-baloo.h>
 
 class KFileItemList;
 class QLabel;