]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Add failing test case for bug #402641
authorElvis Angelaccio <elvis.angelaccio@kde.org>
Sun, 30 Dec 2018 23:21:25 +0000 (00:21 +0100)
committerElvis Angelaccio <elvis.angelaccio@kde.org>
Sun, 30 Dec 2018 23:21:25 +0000 (00:21 +0100)
CCBUG: 402641

src/tests/dolphinmainwindowtest.cpp

index 673bccd4409c9b6bfe84a03c84bd61b4e2fa0c20..d7ff1fb542d836b34a5ab47e4340e17839489730 100644 (file)
@@ -40,6 +40,7 @@ private slots:
     void testActiveViewAfterClosingSplitView_data();
     void testActiveViewAfterClosingSplitView();
     void testUpdateWindowTitleAfterClosingSplitView();
+    void testUpdateWindowTitleAfterChangingSplitView();
     void testOpenInNewTabTitle();
     void testNewFileMenuEnabled_data();
     void testNewFileMenuEnabled();
@@ -175,6 +176,37 @@ void DolphinMainWindowTest::testUpdateWindowTitleAfterClosingSplitView()
     QCOMPARE(currentUrlChangedSpy.count(), 1);
 }
 
+// Test case for bug #402641
+void DolphinMainWindowTest::testUpdateWindowTitleAfterChangingSplitView()
+{
+    m_mainWindow->openDirectories({ QUrl::fromLocalFile(QDir::homePath()) }, false);
+    m_mainWindow->show();
+    QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data()));
+    QVERIFY(m_mainWindow->isVisible());
+
+    auto tabWidget = m_mainWindow->findChild<DolphinTabWidget*>("tabWidget");
+    QVERIFY(tabWidget);
+
+    // Open split view.
+    m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger();
+    QVERIFY(tabWidget->currentTabPage()->splitViewEnabled());
+
+    auto leftViewContainer = tabWidget->currentTabPage()->primaryViewContainer();
+    auto rightViewContainer = tabWidget->currentTabPage()->secondaryViewContainer();
+
+    // Store old window title.
+    const auto oldTitle = m_mainWindow->windowTitle();
+
+    // Change URL in the right view and make sure the title gets updated.
+    rightViewContainer->setUrl(QUrl::fromLocalFile(QDir::rootPath()));
+    QVERIFY(m_mainWindow->windowTitle() != oldTitle);
+
+    // Activate back the left view and check whether the old title gets restored.
+    leftViewContainer->setActive(true);
+    QEXPECT_FAIL("", "Bug #402641", Continue);
+    QCOMPARE(m_mainWindow->windowTitle(), oldTitle);
+}
+
 // Test case for bug #397910
 void DolphinMainWindowTest::testOpenInNewTabTitle()
 {