]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Check the version of the plugins before trying to load them
authorMartin T. H. Sandsmark <martin.sandsmark@kde.org>
Thu, 7 Jan 2021 15:48:43 +0000 (16:48 +0100)
committerElvis Angelaccio <elvis.angelaccio@kde.org>
Mon, 5 Apr 2021 10:38:48 +0000 (10:38 +0000)
src/views/versioncontrol/versioncontrolobserver.cpp

index 9f0933a487be4a74685a5367bd116b89d3f4ec6e..175d362bc5528c5a5e30a79d0c7b45e340550fca 100644 (file)
@@ -304,6 +304,13 @@ void VersionControlObserver::initPlugins()
                 continue;
             }
             if (enabledPlugins.contains((*it)->name())) {
+                KPluginLoader pluginLoader(*(*it));
+                // Need to cast to int, because pluginVersion() returns -1 as
+                // an unsigned int for plugins without versions.
+                if (int(pluginLoader.pluginVersion()) < 2) {
+                    qCWarning(DolphinDebug) << "Can't load old plugin" << (*it)->name();
+                    continue;
+                }
                 KVersionControlPlugin* plugin = (*it)->createInstance<KVersionControlPlugin>(this);
                 if (plugin) {
                     m_plugins.append(plugin);