]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Remove dead code
authorNicolas Fella <nicolas.fella@gmx.de>
Mon, 25 Nov 2019 19:54:08 +0000 (20:54 +0100)
committerNicolas Fella <nicolas.fella@gmx.de>
Mon, 25 Nov 2019 19:54:12 +0000 (20:54 +0100)
Summary: The code appears to do nothing.

Test Plan: builds, bookmarkmenu still works

Reviewers: #dolphin, meven, elvisangelaccio

Reviewed By: #dolphin, meven, elvisangelaccio

Subscribers: meven, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D25347

src/dolphinbookmarkhandler.cpp
src/dolphinbookmarkhandler.h

index bb8f641ec091a13b3e99df0b61a8c78dc6dc0191..ded83d6bb9c87967a95980e1403be1825166201e 100644 (file)
@@ -54,11 +54,6 @@ DolphinBookmarkHandler::~DolphinBookmarkHandler()
 {
 }
 
 {
 }
 
-void DolphinBookmarkHandler::fillControlMenu(QMenu* menu, KActionCollection* collection)
-{
-    m_bookmarkControlMenu.reset(new KBookmarkMenu(m_bookmarkManager, this, menu, collection));
-}
-
 QString DolphinBookmarkHandler::currentTitle() const
 {
     return title(m_mainWindow->activeViewContainer());
 QString DolphinBookmarkHandler::currentTitle() const
 {
     return title(m_mainWindow->activeViewContainer());
index 6fd511d8025f4fba70f2eb4814d819fbcc9cdd97..bafef41f8afc357b22de51deefb1b8e93f772e9a 100644 (file)
@@ -36,7 +36,7 @@ class DolphinBookmarkHandler : public QObject, public KBookmarkOwner
 public:
     DolphinBookmarkHandler(DolphinMainWindow *mainWindow, KActionCollection *collection, QMenu *menu, QObject *parent);
     ~DolphinBookmarkHandler() override;
 public:
     DolphinBookmarkHandler(DolphinMainWindow *mainWindow, KActionCollection *collection, QMenu *menu, QObject *parent);
     ~DolphinBookmarkHandler() override;
-    void fillControlMenu(QMenu *menu, KActionCollection *collection);
+
 private:
     QString currentTitle() const override;
     QUrl currentUrl() const override;
 private:
     QString currentTitle() const override;
     QUrl currentUrl() const override;
@@ -55,7 +55,6 @@ private:
     DolphinMainWindow* m_mainWindow;
     KBookmarkManager *m_bookmarkManager;
     QScopedPointer<KBookmarkMenu> m_bookmarkMenu;
     DolphinMainWindow* m_mainWindow;
     KBookmarkManager *m_bookmarkManager;
     QScopedPointer<KBookmarkMenu> m_bookmarkMenu;
-    QScopedPointer<KBookmarkMenu> m_bookmarkControlMenu;
 };
 
 #endif // DOLPHINBOOKMARKHANDLER_H
 };
 
 #endif // DOLPHINBOOKMARKHANDLER_H