Peter Penz [Sun, 18 Nov 2007 13:33:16 +0000 (13:33 +0000)]
Check whether the shift key is pressed when the "Move to Trash" action is executed. If this is the case, perform the "Delete" action instead (-> works like in Konqi now, thanks to David for the hint)
Peter Penz [Sun, 18 Nov 2007 13:24:43 +0000 (13:24 +0000)]
fix crash for the following use case:
- open a view with no selection
- press SHIFT + right mouse-click on an item
- a context menu will be opened although no item has been selected -> assertion gets triggered later
David Faure [Sat, 17 Nov 2007 00:08:54 +0000 (00:08 +0000)]
Fix "delete" and "move to trash" actions in dolphinpart; moved all logic for those out of konqueror.
Inside dolphin, the usual: moving code to DolphinView.
Pressing shift while clicking on "Move to Trash" in konq (dolphinpart) offers to delete, as in kde3 (this bit of logic might be good for dolphin itself too? see DolphinPart::slotTrashActivated)
CCMAIL: peter.penz@gmx.at
Peter Penz [Thu, 15 Nov 2007 22:20:40 +0000 (22:20 +0000)]
Bypass a layout issue in QListView::visualRect(), where the horizontal position of items might get calculated in a wrong manner when the item name is too long. I'll try create a patch for Qt but as Dolphin must also work with Qt 4.3.0 this workaround must get applied at least for KDE 4.0.
David Faure [Thu, 15 Nov 2007 14:59:02 +0000 (14:59 +0000)]
Implement renaming in dolphinpart.
No more rename action provided by konqueror, the part provides it now.
Had to move a bit of code around in dolphin, as discussed with Peter.
David Faure [Thu, 15 Nov 2007 10:10:42 +0000 (10:10 +0000)]
KonqUndoManager -> KonqFileUndoManager, to prepare for a KonqUndoManager in konqueror,
Taking this opportunity for filename==classname and a .cpp extension, as well.
* Left to Right arrangement
* Elements enough to be needed an horizontal scroll bar with categorized view disabled
* Enable categorized view
* Horizontal scrollbar still visible
Now it is hidden, because the way KCategorizedView shows items is not needed.
David Faure [Sun, 11 Nov 2007 21:03:59 +0000 (21:03 +0000)]
Fix the other bug reported by BCoppens: the tab title was the full path, until switching tabs and back, then it changed to just the dir name (as it should be, in fact).
The logic in KonqView::setCaption was being confused by the part url still being empty; let's do things in the right order here.
+ .rc cleanups
Reverted changes made earlier today - and I added the workaround in the root file as described in kde-buildsystem - please tell me again if this should go somewhere else 3/3
Peter Penz [Wed, 7 Nov 2007 22:55:15 +0000 (22:55 +0000)]
Fixed performance issue in the details-view when showing > 10000 items:
* Resizing the columns takes around 250 ms instead of 2 seconds.
* Opening 10000 items from the disk cache takes 3 seconds instead of 20 seconds.
Peter Penz [Tue, 6 Nov 2007 07:16:23 +0000 (07:16 +0000)]
When switching from e. g. the icons view to the details view, additional information properties like 'Size' and 'Date' are added as default (showing a details-view without details does not make sense as default setting...). This fix assures that the additional information properties are removed again when switching back to the icons view. Only if the user modified the additional information properties by a GUI-interaction (e. g. by adding a 'Type'), this information is persistet also when switching back to the icon-view.
Peter Penz [Tue, 30 Oct 2007 19:44:55 +0000 (19:44 +0000)]
* fixed drag & drop issue in column view (dropping on files was not possible -> handled as viewport now)
* only show the hover-drop-indicator on directories (dropping on file-items is handled like dropping on the viewport)
* simplified signature of drop signal (source widget not required anymore)
Peter Penz [Fri, 26 Oct 2007 19:02:33 +0000 (19:02 +0000)]
Simplify DolphinController: don't remember the show-preview state in the controller and add an unnecessary additional signal; instead just read the state from the DolphinView
Peter Penz [Fri, 26 Oct 2007 18:34:45 +0000 (18:34 +0000)]
Simplify the DolphinController: The "show hidden files" state can be retrieved by the DolphinView, there is no need introducing additional signals + states. Further cleanups will follow...
Peter Penz [Fri, 26 Oct 2007 17:36:16 +0000 (17:36 +0000)]
due to the recent tagging freeze this commit contains several fixes in one:
* the filterbar now also filters directories (works also in the column-view :-))
* The "Additional Information" menu entry now also works for showing/hiding the columns of the details view. This also implies that the columns for the details view can now be adjusted per directory -> we have now a consistent behavior between the icons view and details view. Still open: the view properties dialog must be fixed
* Don't show a "Nepomuk not available" error message when starting Dolphin and Nepomuk is not available.
* Fix issue that the information panel blocked the application because of parsing the full meta data of a huge file.
KConfig* API overhaul. only cosmetics, so don't panic.
KConfigBase:
- remove separator argument from list entry reading/writing functions
- introduce {read,write}XdgListEntry()
- kill readPathListEntry(), add readPathEntry() overload
instead. the default value is not optional any more, as it defines the
return type. this is consistent with the readEntry() functions.
- rename clean() => markAsClean(), remove rollback()
- rename ConfigState => AccessMode, getConfigState() => accessMode()
- rename {entry,group}IsImmutable() => is{Entry,Group}Immutable()
- remove NLS alias to Localized
KConfig:
- remove setGroup() & group()
- reshuffle OpenFlag enum, introduce NoCascade for symmetry
- remove setExtraConfigFiles() alias to addConfigSources()
KConfigGroup:
- inherit KConfigBase::deleteGroup() overloads
- make convertToQVariant() private, it will probably change somehow
- KConfig & KConfigGroup: deprecate entryMap()
- remove bogus declarations: KConfigGroup::setReadDefaults(),
KConfig::readEntryUntranslated()
- apidox
- reshuffle the declarations in the headers
Peter Penz [Tue, 23 Oct 2007 07:10:51 +0000 (07:10 +0000)]
Fixed issue that within Konqueror changing the active column from the column-view is ignored. From the hosts point of view this has to be handled like an URL change.
Matthew Woehlke [Mon, 22 Oct 2007 17:37:56 +0000 (17:37 +0000)]
SVN_SILENT: clean up from previous commit (would be nice to remember to save ;-)); this just removes commented-out code and adds a "what's going on" comment
On the Information panel the further information such as "Date", "Size", "Type" was being cut off if it was being shrinked. That shouldn't happen. This prevents this
information to be hidden or cut off, and so this is always shown.
Albert: I also solved the previous bug you reported (places view not showing selected items at the first click) on a different commit
This fixes the problem that when you click the first time on a place
bookmarked it is not shown as selected, but if you click the second time
it is. Now this is fixed.
Peter Penz [Tue, 16 Oct 2007 22:24:52 +0000 (22:24 +0000)]
polish look of column view:
- don't show a focused border above all columns
- provide a small gap between the columns
- assure that the background of inactive columns works well with more complex styles like Oxygen
The sorting on dolphinview is no more needed, it is done automatically by KCategorizedSortFilterProxyModel when setCategorizedModel is changed.
Bug fixed for the categorized view: Details => Icons (with no categories) => Categorized was resulting in no items in the view or all items in the same position
David Faure [Wed, 10 Oct 2007 23:01:35 +0000 (23:01 +0000)]
DolphinPart: provide a way to switch between view modes in konqueror.
Factorized those actions between dolphinmainwindow and dolphinpart (see new methods in dolphinview), and simplified mainwindow code by using the signal from the action group and the QVariant data of the actions (standard Qt4 solution for a group of actions).
Peter Penz [Tue, 9 Oct 2007 22:32:54 +0000 (22:32 +0000)]
Allow filtering of items also for the column view. A filtering of directories is not done yet, but with the latest updates of the column view this could be added now (but it's more a question whether we really want this...).
Peter Penz [Tue, 9 Oct 2007 21:10:17 +0000 (21:10 +0000)]
column view fixes:
* assure that the history does not get messed up when changing the focus to an existing column
* fix issue that the status bar does not get updated when the focus is changed between the columns
David Faure [Sun, 7 Oct 2007 21:12:46 +0000 (21:12 +0000)]
Extracted the servicemenu code from KonqPopupMenu into KonqMenuActions, and used it from both KonqPopupMenu and DolphinContextMenu.
This isn't the port-to-ktrader yet, this will come later, but at least the code is factorized and the impl can be changed without affecting the dolphin+konqpopupmenu code
Should I also implement the "Open With..." actions in KonqMenuActions? Seems like another bit of similar code duplicated.
CCMAIL: peter.penz@gmx.at, aseigo@kde.org
Removed KonqBookmarkManager (was a two-liner call to KBookmarkManager)
projects / dolphin.git / log