Shaun Reich [Wed, 4 Feb 2009 03:44:13 +0000 (03:44 +0000)]
The Home folder location, when set via loadSettings(), and when set via the 'Use Default Location' button, now will use KUrl::prettyUrl(); Prior to this, saving an address of '/home/user/' would be changed to 'file:///home/user' (on Linux) normally (through applySettings()). However, when the listed methods were called, the text of the line edit would be just '/home/user/'. It will now (basically) be set to 'file:///'... all throughout.
Shaun Reich [Wed, 4 Feb 2009 01:24:38 +0000 (01:24 +0000)]
Added const bools for a few settings that were referenced more than once. Otherwise, the fellow coder would probably just think these were taken out of seemingly thin air.
Peter Penz [Tue, 3 Feb 2009 06:24:39 +0000 (06:24 +0000)]
* no general settings are read -> invoking loadSettings has no effect in restoreDefaults()
* use constants for the defaults, as hardcoding the defaults in 2 methods might be error-prone when changing the defaults in future
Shaun Reich [Tue, 3 Feb 2009 03:20:47 +0000 (03:20 +0000)]
String change - Added clarification in the displayed message box for when the settings are applied in the Startup page, and there is an error. This is under the home folder setting. It now says that "the home folder is invalid or does not exist" as opposed to just saying it is invalid. I believe that it was kind of misleading as to what was wrong, so I figured it should give them _some_ hint as to what the problem is.
Shaun Reich [Mon, 2 Feb 2009 22:23:06 +0000 (22:23 +0000)]
A few more fixes...mostly cleanups.
*Grouped some statements that it didn't make sense to put after a certain block of code (giving the impression that it had to be after this block).
*There is no need to set the value of the QSpinBox equal to that of the slider, when loading settings... their valueChanges() signals are connected to the opposite one's slot.
*Made a now unused variable be used, it was inconsistent in this code block, two times '1' was used, but other times a var set to '1' would be used.
*Moved some blocks of code from the loadSettings() method, into the constructor, since the loadSettings() method is called more than once, so it's more resource-friendly to do it this way.
Shaun Reich [Mon, 2 Feb 2009 21:35:37 +0000 (21:35 +0000)]
We were calling methods within loadSettings() which should have been moved to inside the constructor instead. Examples include setting up a slider's notch-type(bottom or top). Especially significant since loadSettings() gets called more often than the constructor.
Shaun Reich [Mon, 2 Feb 2009 20:14:42 +0000 (20:14 +0000)]
Changed group config reference pertaining to the "kcminputrc" file. The Navigation page setting of whether to use single/double click navigation now saves itself properly, instead of insisting on using single-click. :)
P.S. Bear in mind that the setting still does not apply itself until a restart of Dolphin.
Shaun Reich [Mon, 2 Feb 2009 14:44:25 +0000 (14:44 +0000)]
Confirmations of the following settings now reset themselves to their defaults:
*Move to Trash
*Delete
These are located in the General page->Context Menu tab of the settings dialog.
Hovering over blank space in a view while dragging would trigger the FolderExpander on the folder represented by the view, which we don't want. Detect and prevent it.
Shaun Reich [Sun, 1 Feb 2009 20:43:26 +0000 (20:43 +0000)]
Now when you click the button "Defaults" in the settings dialog, it will push the settings to the UI, then the user can apply, cancel, or modify them from there. Also removed the message box prompt. Use settings->useDefaults(true), then set it back to false after you are done loading settings in the restoreDefaults() method calls. Don't use ->setDefaults() normally, anymore.
Peter Penz [Sun, 1 Feb 2009 14:08:40 +0000 (14:08 +0000)]
Replace patch for bug 181226 by a different approach, as the previous patch resulted in a changed behavior when using the double-click mode (-> a treeview item had to be pressed twice to show it in the main view).
Peter Penz [Sat, 31 Jan 2009 13:04:40 +0000 (13:04 +0000)]
Postpone the creating of the media object until the play- or stop-button has been pressed. This solves the issue that Dolphin might get blocked during hovering media files. Dolphin still gets blocked when requesting a media object the first time, but for the user this "just" means that after pressing the play-button the first time, that the playing starts a little bit later.
Shaun Reich [Wed, 28 Jan 2009 21:27:16 +0000 (21:27 +0000)]
Default size and Preview size sliders, were using wrong signal to notify that settings have changed. The keyboard, when used on the slider, wouldn't enable the apply button, nor clicking to either side of the slider to change it. sliderMoved signal emission changed to valueChanged. Effects all tabs in Settings Dialog->View Modes.
Initial import of Matthias's draft patch for adding video and audio previewing (similar to the file dialog) to Dolphin's metadata panel. Since Phonon is currently in-process only with the memory/ stability issues that come with this, this might have to be disabled by default - we'll see how it goes. Thanks, Matthias!
Shaun Reich [Tue, 27 Jan 2009 01:13:03 +0000 (01:13 +0000)]
The apply button in the settings dialog now disables itself when settings are applied, as per all of the other KDE applications, added in DolphinSettingsDialog::applySettings(). It was already setup to re-enable on a settings change.
David Faure [Mon, 26 Jan 2009 15:45:39 +0000 (15:45 +0000)]
Don't crash if parentWidget is 0 (even though I don't recommend setting it to 0, the dirlister mainwindow won't be set if you reparent the widget later on)
BUG: 161681
Refactor the folder expansion system. Main effect: instead of having a list of m_expandedViews which cannot yet be deleted, we more accurately identify the current source of the drag operation if any and store only this for later deletion.
This also fixes folder-expansion not working in Column view.
In rare circumstances (a very narrow viewport is a necessary, but not sufficient, condition) DolphinDetailsView::resizeColumns() is called with an empty model so that sizeHintForColumn(...) returns -1 and so the name column ultimately has width -1. Detect and prevent this.
Two KFilePreviewGenerator's operating on the same KDirModel can lead to infinite loops of preview generation. If view is not delete'd (e.g. as a result of a FolderExpander), then m_previewGenerator won't be either: delete it manually to prevent having two active at once.
David Faure [Mon, 19 Jan 2009 14:33:10 +0000 (14:33 +0000)]
Fix lack of error handling in RMB/Move To... (e.g. when src is root-owned) because the parent for KonqOperations
was the popupmenu, which gets deleted before the job finishes.
Peter Penz [Mon, 19 Jan 2009 14:25:08 +0000 (14:25 +0000)]
Use a custom SearchWidget instead directly using a KLineEdit. Currently the DolphinSearchWidget acts as "playground" to test some ideas. If it works well it might be a good idea moving this widget as KSearchBox (?) to kdelibs, so that it can be used by the file dialog or other applications.
Peter Penz [Mon, 19 Jan 2009 13:17:33 +0000 (13:17 +0000)]
Provide a search box for the nepomuksearch:/ KIO slave. This is just an initial prototype to get some feedback, the search box and the URL navigator still need some love for this usecase...
Harald Sitter [Sat, 17 Jan 2009 23:07:46 +0000 (23:07 +0000)]
Fix Dolphin's desktop file. The additional quotation of %u made dolphin be started with an empty (but existing) location value which made it fall back to XDG's document path as of KDE 4.2. Without
quotation it doesn't get that empty value and starts using it's configured default location.
BUG: 169016
Peter Penz [Sat, 17 Jan 2009 18:42:06 +0000 (18:42 +0000)]
Relayout of the settings dialog, so that all Dolphin KPart relevant settings can be made available in Konqueror's settings dialog too. Further cleanups and layout fixes are required and will be done during the next week.
David Faure [Fri, 16 Jan 2009 13:21:33 +0000 (13:21 +0000)]
Repair redirections in DolphinPart, it used to notify of redirections by connecting to urlChanged,
but iirc there were recent changes which make dolphinview emit redirection instead of urlChanged in that case
Makes me wonder if urlChanged is still useful for anything?
CCMAIL: peter.penz@gmx.at
Peter Penz [Wed, 14 Jan 2009 20:14:36 +0000 (20:14 +0000)]
Cleanup panel related class names: The terms "sidebar"/"sidebarpage" are relicts from the KDE 3 version of Dolphin and are called "Panels" in the KDE 4 version of Dolphin. Yes, renaming classes may take more than 1 year ;-)
Peter Penz [Wed, 14 Jan 2009 19:26:23 +0000 (19:26 +0000)]
Group classes into folders, Dolphin is too big in the meantime for having a flat directory hierarchy. dolphin/src/CMakeLists.txt will be cleaned up later.
David Faure [Thu, 8 Jan 2009 20:46:10 +0000 (20:46 +0000)]
Small optimization found while having debug output in kfileitem: pass the KFileItem rather than the URL,
so that previewjob doesn't have to determine the item's mimetype again.
Peter Penz [Mon, 5 Jan 2009 18:21:34 +0000 (18:21 +0000)]
QAbstractItemView::scrollTo() may get called by QListView::keyPressEvent(), so m_enableScrollTo (which is checked in DolphinIconsView::scrollTo()) must be enabled before. This fixes the issue that the autoscrolling does not work if exactly one item is selected and an invisible item should get focused because of a key press.
Peter Penz [Sun, 4 Jan 2009 18:35:32 +0000 (18:35 +0000)]
Only expand the tree view if it has an enabled 'itemsExpandable' property. If this is not the case, the folder will get opened like in the icon view by exchanging the whole content.
Peter Penz [Sun, 4 Jan 2009 18:26:43 +0000 (18:26 +0000)]
Fixed issue that in combination with the "automatically open folders during drag operations" the details view is not drawn correctly in the following case: Drag an item in the icons view to a folder which uses the details view.
Peter Penz [Sun, 4 Jan 2009 18:19:48 +0000 (18:19 +0000)]
Don't set the mouse button state to NoButton, this is invalid e. g. during a drag operation. The mouse button state will be updated anyhow on each item-click. This fixes the regression that the feature "automatically open folders during drag operations" did not work anymore after one level.
contentsPos turned out to be a little broken - it would always return (0,0), except in a very unusual set of circumstances where it returned ... "different" values, causing very odd behaviour with the elastic band :) Remove it.
Peter Penz [Tue, 30 Dec 2008 14:48:18 +0000 (14:48 +0000)]
fixed crash when enabling grouping by date and having dates like
30 December 2008 (is "Week 1" (of 2009 , but for 2008 too))
28 December 2008 (is "Week 52" (of 2008) )
projects / dolphin.git / log