On the Information panel the further information such as "Date", "Size", "Type" was being cut off if it was being shrinked. That shouldn't happen. This prevents this
information to be hidden or cut off, and so this is always shown.
Albert: I also solved the previous bug you reported (places view not showing selected items at the first click) on a different commit
This fixes the problem that when you click the first time on a place
bookmarked it is not shown as selected, but if you click the second time
it is. Now this is fixed.
Peter Penz [Tue, 16 Oct 2007 22:24:52 +0000 (22:24 +0000)]
polish look of column view:
- don't show a focused border above all columns
- provide a small gap between the columns
- assure that the background of inactive columns works well with more complex styles like Oxygen
The sorting on dolphinview is no more needed, it is done automatically by KCategorizedSortFilterProxyModel when setCategorizedModel is changed.
Bug fixed for the categorized view: Details => Icons (with no categories) => Categorized was resulting in no items in the view or all items in the same position
David Faure [Wed, 10 Oct 2007 23:01:35 +0000 (23:01 +0000)]
DolphinPart: provide a way to switch between view modes in konqueror.
Factorized those actions between dolphinmainwindow and dolphinpart (see new methods in dolphinview), and simplified mainwindow code by using the signal from the action group and the QVariant data of the actions (standard Qt4 solution for a group of actions).
Peter Penz [Tue, 9 Oct 2007 22:32:54 +0000 (22:32 +0000)]
Allow filtering of items also for the column view. A filtering of directories is not done yet, but with the latest updates of the column view this could be added now (but it's more a question whether we really want this...).
Peter Penz [Tue, 9 Oct 2007 21:10:17 +0000 (21:10 +0000)]
column view fixes:
* assure that the history does not get messed up when changing the focus to an existing column
* fix issue that the status bar does not get updated when the focus is changed between the columns
David Faure [Sun, 7 Oct 2007 21:12:46 +0000 (21:12 +0000)]
Extracted the servicemenu code from KonqPopupMenu into KonqMenuActions, and used it from both KonqPopupMenu and DolphinContextMenu.
This isn't the port-to-ktrader yet, this will come later, but at least the code is factorized and the impl can be changed without affecting the dolphin+konqpopupmenu code
Should I also implement the "Open With..." actions in KonqMenuActions? Seems like another bit of similar code duplicated.
CCMAIL: peter.penz@gmx.at, aseigo@kde.org
Removed KonqBookmarkManager (was a two-liner call to KBookmarkManager)
Andreas Pakulat [Fri, 5 Oct 2007 22:21:25 +0000 (22:21 +0000)]
Merge the KConfig branch. This are the 3 main modules (+kdeadmin), which are
needed now because friday is the last BC day. The rest of the modules will
follow as fast as my laptop allows.
Peter Penz [Fri, 5 Oct 2007 21:00:44 +0000 (21:00 +0000)]
Refactored DolphinColumnWidget so that it does not need a hierarchical KDirLister. This simplifies the code a lot and also bypasses the current problems with the KDirLister cache when working on hierarchical directories in parallel. There are some minor regressions which will be fixed, but all in all some improvements are visible already:
- the loading of columns is a lot faster
- preview in columns is working
- no side effects in combination with the treeview-panel because of caching
Peter Penz [Fri, 5 Oct 2007 06:33:48 +0000 (06:33 +0000)]
Restoring the column view relies on the URL-history. It might be possible that the view properties have been changed or deleted in the meantime, so it cannot be asserted that really a column view has been created.
Changes related to the smooth scrolling. We can enable it since icefox has submitted his "division by zero" to Qt, so it should be safe. If we experience any division by
zero or report, we just disable them commenting them out and with a comment to remind ourselves to uncomment them after.
The smooth scrolling is being combined with a good behavior when using the mouse wheel.
Some investigation on QListView found nice stuff for KCategorizedView.
Peter, I have the smooth scrolling for KDirOperator too, let me that one... I have binary incompatible changes merged there with this ones and I am committing everything
together on friday.
Peter Penz [Tue, 2 Oct 2007 22:11:18 +0000 (22:11 +0000)]
As the additional information can be shown in parallel, a combobox selection is not sufficient anymore. To prevent bug-reports for the beta 3 release, all items are explicitly marked as TODO temporary.
Peter Penz [Tue, 2 Oct 2007 22:04:36 +0000 (22:04 +0000)]
Allow showing additional information like type, size and date in parallel for the icons view (thanks to Fredrik for the extension of KFileItemDelegate!).
David Faure [Mon, 1 Oct 2007 17:06:34 +0000 (17:06 +0000)]
Ported KonqPopupMenu away from xmlgui to make things debuggable (we had code that dynamically created XML, and then passed it for gui merging with KonqPopupMenu's own generated XML, that was too much magic and headaches).
There are now unit tests for KonqPopupMenu, and its code has a bit less magic hacks than before.
There is no more KonqPopupMenuPlugin though, but I'm happy to re-create it once there's a real use case for it.
Peter Penz [Thu, 27 Sep 2007 07:02:35 +0000 (07:02 +0000)]
Remove ScrollPerPixel again. Beside a crash with a non-patched version of Qt it also decreases the usability when using the mouse wheel: one full rotation of the mouse wheel only leads to a scrolling of 1 or 2 items...
Peter Penz [Thu, 27 Sep 2007 06:20:39 +0000 (06:20 +0000)]
* moved the loading of the settings into a separate method
* assure that the "show in groups" action gets disabled when no categorization is allowed for the current view
Peter Penz [Thu, 27 Sep 2007 06:19:30 +0000 (06:19 +0000)]
Use case: categorized sorting is enabled, the current view mode is icons-view. When switching to the details-view (which does not support categorized sorting yet), the 'categorized sorting' action should get only disabled to indicate that it is not available, not get unchecked (currently it gets disabled AND unchecked). This patch assures that always the stored categorization state is returned for the menu actions, but internally the categorization is turned off for the proxy model for the details view and column view.
Peter Penz [Wed, 26 Sep 2007 15:26:30 +0000 (15:26 +0000)]
Assure that the categorized sorting is applied correctly to the proxy model if the view does not support the categorization feature (currently only the icons view supports this). Take care that switching between e. g. the icons-view and the details-view does not change the stored categorized sorting. Thanks to Rafael for the initial patch!
Peter Penz [Wed, 26 Sep 2007 11:46:49 +0000 (11:46 +0000)]
* Fix memory leak (DolphinCategoryDrawer is leaking...)
* There is no need to explicitly turning on the category, as this is done automatically when reading out the view properties. @Rafael: I tested your error description and could not reproduce the problem anymore. If I miss something, please let me know, so that we can work together to fix this :-)
projects / dolphin.git / log