]> cloud.milkyroute.net Git - dolphin.git/commitdiff
FoldersTabsSettingsPage: Remove double cast, remove unnecessary variable
authorAkseli Lahtinen <akselmo@akselmo.dev>
Wed, 13 Nov 2024 09:46:32 +0000 (11:46 +0200)
committerAkseli Lahtinen <akselmo@akselmo.dev>
Wed, 13 Nov 2024 12:51:55 +0000 (12:51 +0000)
This uses only qobject_cast here, having static_cast after it is
redundant.

Also remove the topLevelWidgets variable, since we can just
call the method instead.

src/settings/interface/folderstabssettingspage.cpp

index 0212f624c2bac4bacc082c40418bd4c4b5e7baed..c4bc0d7404b4db58e3b27f591817466822d892c5 100644 (file)
@@ -248,10 +248,9 @@ void FoldersTabsSettingsPage::useCurrentLocation()
 {
 #ifndef IS_KCM
     DolphinMainWindow *mainWindow = nullptr;
-    const auto topLevelWidgets = QApplication::allWidgets();
-    for (const auto widget : topLevelWidgets) {
-        if (qobject_cast<DolphinMainWindow *>(widget)) {
-            mainWindow = static_cast<DolphinMainWindow *>(widget);
+    for (const auto widget : QApplication::topLevelWidgets()) {
+        mainWindow = qobject_cast<DolphinMainWindow *>(widget);
+        if (mainWindow) {
             break;
         }
     }