GeneralViewSettingsPage: Initialize variables in header, avoid unused variable depend...

diff --git a/src/settings/viewmodes/generalviewsettingspage.cpp b/src/settings/viewmodes/generalviewsettingspage.cpp
index 0b2a96cb599d80d7a1613e500896616633b1e767..a81d46dd2616caa8596590c2cb9673ff260a3dd7 100644 (file)
--- a/src/settings/viewmodes/generalviewsettingspage.cpp
+++ b/src/settings/viewmodes/generalviewsettingspage.cpp
@@ -19,11 +19,6 @@
 GeneralViewSettingsPage::GeneralViewSettingsPage(const QUrl &url, QWidget *parent)
     : SettingsPageBase(parent)
     , m_url(url)
-    , m_localViewProps(nullptr)
-    , m_globalViewProps(nullptr)
-    , m_showToolTips(nullptr)
-    , m_showSelectionToggle(nullptr)
-    , m_renameInline(nullptr)
 {
     QFormLayout *topLayout = new QFormLayout(this);
 

diff --git a/src/settings/viewmodes/generalviewsettingspage.h b/src/settings/viewmodes/generalviewsettingspage.h
index 47838b9394092678d7ceaee92ce377700066bdd0..c0e40db59110824fef25ebf2413ab9aee81cc3cd 100644 (file)
--- a/src/settings/viewmodes/generalviewsettingspage.h
+++ b/src/settings/viewmodes/generalviewsettingspage.h
@@ -6,6 +6,7 @@
 #ifndef GENERALVIEWSETTINGSPAGE_H
 #define GENERALVIEWSETTINGSPAGE_H
 
+#include "config-dolphin.h"
 #include "settings/settingspagebase.h"
 #include <qradiobutton.h>
 
@@ -37,14 +38,15 @@ private:
 
 private:
     QUrl m_url;
-    QRadioButton *m_localViewProps;
-    QRadioButton *m_globalViewProps;
-    QCheckBox *m_showToolTips;
-    QLabel *m_configureToolTips;
-    QCheckBox *m_showSelectionToggle;
-    QCheckBox *m_renameInline;
-    QCheckBox *m_openArchivesAsFolder;
-    QCheckBox *m_autoExpandFolders;
+    QRadioButton *m_localViewProps = nullptr;
+    QRadioButton *m_globalViewProps = nullptr;
+#if HAVE_BALOO
+    QCheckBox *m_showToolTips = nullptr;
+#endif
+    QCheckBox *m_showSelectionToggle = nullptr;
+    QCheckBox *m_renameInline = nullptr;
+    QCheckBox *m_openArchivesAsFolder = nullptr;
+    QCheckBox *m_autoExpandFolders = nullptr;
 };
 
 #endif