]> cloud.milkyroute.net Git - dolphin.git/commitdiff
[DolphinViewActionHandler] Rename createDirectory signal
authorElvis Angelaccio <elvis.angelaccio@kde.org>
Wed, 24 Oct 2018 20:49:01 +0000 (22:49 +0200)
committerElvis Angelaccio <elvis.angelaccio@kde.org>
Wed, 24 Oct 2018 20:49:01 +0000 (22:49 +0200)
Signals should be named after an event that happened.

src/dolphinmainwindow.cpp
src/dolphinpart.cpp
src/views/dolphinviewactionhandler.cpp
src/views/dolphinviewactionhandler.h

index 75a340f0a5e14aa0b7b7432158cbb99384ff0337..d9adde66bcde47f7264a42de05e4d64a7af223d6 100644 (file)
@@ -142,7 +142,7 @@ DolphinMainWindow::DolphinMainWindow() :
 
     m_actionHandler = new DolphinViewActionHandler(actionCollection(), this);
     connect(m_actionHandler, &DolphinViewActionHandler::actionBeingHandled, this, &DolphinMainWindow::clearStatusBar);
-    connect(m_actionHandler, &DolphinViewActionHandler::createDirectory, this, &DolphinMainWindow::createDirectory);
+    connect(m_actionHandler, &DolphinViewActionHandler::createDirectoryTriggered, this, &DolphinMainWindow::createDirectory);
 
     m_remoteEncoding = new DolphinRemoteEncoding(this, m_actionHandler);
     connect(this, &DolphinMainWindow::urlChanged,
index 2e7f7639f16871d94fb7206ba0214a0f6fae2866..f5d4f95b64e95ed21713147ac8a3346c422bb5cc 100644 (file)
@@ -115,7 +115,7 @@ DolphinPart::DolphinPart(QWidget* parentWidget, QObject* parent, const QVariantL
 
     m_actionHandler = new DolphinViewActionHandler(actionCollection(), this);
     m_actionHandler->setCurrentView(m_view);
-    connect(m_actionHandler, &DolphinViewActionHandler::createDirectory, this, &DolphinPart::createDirectory);
+    connect(m_actionHandler, &DolphinViewActionHandler::createDirectoryTriggered, this, &DolphinPart::createDirectory);
 
     m_remoteEncoding = new DolphinRemoteEncoding(this, m_actionHandler);
     connect(this, &DolphinPart::aboutToOpenURL,
index 95c140cc50f79c602eed8a3fffe9258554be4f77..5697c7f4121607079113f7288a6df1eaac41b64e 100644 (file)
@@ -95,7 +95,7 @@ void DolphinViewActionHandler::createActions()
     m_actionCollection->setDefaultShortcut(newDirAction, Qt::Key_F10);
     newDirAction->setIcon(QIcon::fromTheme(QStringLiteral("folder-new")));
     newDirAction->setEnabled(false);    // Will be enabled in slotWriteStateChanged(bool) if the current URL is writable
-    connect(newDirAction, &QAction::triggered, this, &DolphinViewActionHandler::createDirectory);
+    connect(newDirAction, &QAction::triggered, this, &DolphinViewActionHandler::createDirectoryTriggered);
 
     // File menu
 
index be22739178df787ddda5f644b7f05960b944e093..fa0487e1bebec853ca04d880a63c5e212fe71755 100644 (file)
@@ -93,7 +93,7 @@ Q_SIGNALS:
      * The receiver of the signal (DolphinMainWindow or DolphinPart) invokes
      * the method createDirectory of their KNewFileMenu instance.
      */
-    void createDirectory();
+    void createDirectoryTriggered();
 
 private Q_SLOTS:
     /**