]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Fix accessibility regression on the Dolphin Control button
authorElvis Angelaccio <elvis.angelaccio@kde.org>
Sun, 24 Nov 2019 13:56:53 +0000 (14:56 +0100)
committerElvis Angelaccio <elvis.angelaccio@kde.org>
Sun, 24 Nov 2019 18:06:36 +0000 (19:06 +0100)
9cd042a86c removed the text from the Control button without setting an
accessibleName property, which is a regression for screen-reader users.

This breaks the 19.12 string freeze, but since it's the same string we
were translating before 9cd042a86c, hopefully it's not going to be too
much of a burden for translators.

CCBUG: 414271
CCMAIL: kde-i18n-doc@kde.org

src/dolphinmainwindow.cpp

index e28b18cd3dc120e4b7858757e832afafa31c5b24..56ea93e1043e8408f925d2a4cece8615d8f53f73 100644 (file)
@@ -1880,6 +1880,7 @@ void DolphinMainWindow::createControlButton()
     Q_ASSERT(!m_controlButton);
 
     m_controlButton = new QToolButton(this);
     Q_ASSERT(!m_controlButton);
 
     m_controlButton = new QToolButton(this);
+    m_controlButton->setAccessibleName(i18nc("@action:intoolbar", "Control"));
     m_controlButton->setIcon(QIcon::fromTheme(QStringLiteral("application-menu")));
     m_controlButton->setToolTip(i18nc("@action", "Show menu"));
     m_controlButton->setAttribute(Qt::WidgetAttribute::WA_CustomWhatsThis);
     m_controlButton->setIcon(QIcon::fromTheme(QStringLiteral("application-menu")));
     m_controlButton->setToolTip(i18nc("@action", "Show menu"));
     m_controlButton->setAttribute(Qt::WidgetAttribute::WA_CustomWhatsThis);