Do not emit DolphinView's urlChanged(const KUrl&) signal if the view

is activated, as discussed with Peter. This fixes a crash on a failed
assert if the DolphinView's and the KUrlNavigator's URLs are slightly
different (i.e., if a slash has been added to the navigator's URL by
KDirLister).

I could not find any regressions caused by this change so far, but
even if there are side effects, the upcoming beta and RC releases
should give enough user feedback and time to fix them.

BUG: 180494

svn path=/trunk/KDE/kdebase/apps/; revision=961519

diff --git a/src/dolphinview.cpp b/src/dolphinview.cpp
index f2f23d27301da839a03cb323993ccf2cfaba164d..48df3e20f7073510c74e60271b7a5fd7a6408eda 100644 (file)
--- a/src/dolphinview.cpp
+++ b/src/dolphinview.cpp
@@ -187,10 +187,6 @@ void DolphinView::setActive(bool active)
 
     QColor color = KColorScheme(QPalette::Active, KColorScheme::View).background().color();
     if (active) {
-        // TODO: emitting urlChanged() is a hack, as the URL hasn't really changed. It
-        // bypasses the problem when having a split view and changing the active view to
-        // update the some URL dependent states. A nicer approach should be no big deal...
-        emit urlChanged(url());
         emit selectionChanged(selectedItems());
     } else {
         color.setAlpha(150);