]> cloud.milkyroute.net Git - dolphin.git/commitdiff
Make target_link_libraries for kdeinit_dolphin PRIVATE
authorAlexander Miller <alex.miller@gmx.de>
Fri, 18 May 2018 20:44:52 +0000 (22:44 +0200)
committerAndreas Sturmlechner <asturm@gentoo.org>
Fri, 18 May 2018 20:44:57 +0000 (22:44 +0200)
Summary:
There is no need to add all of kdeinit_dolphin's
dependencies (including the static archive) when
linking dolphin; kdemain is the only needed symbol.
Mark the link libraries PRIVATE to simplify the
link command for dolphin.

Reviewers: #dolphin, elvisangelaccio

Reviewed By: elvisangelaccio

Subscribers: asturmlechner, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D12931

src/CMakeLists.txt

index e8fe719a43c2bf7b11cbd1333a8a0b5cfecece37..beaa0ec50059cc95ace982b974ea7ec958e5e79b 100644 (file)
@@ -299,7 +299,7 @@ ecm_add_app_icon(dolphin_SRCS ICONS ${ICONS_SRCS})
 kf5_add_kdeinit_executable(dolphin ${dolphin_SRCS})
 
 
-target_link_libraries(kdeinit_dolphin
+target_link_libraries(kdeinit_dolphin PRIVATE
     dolphinstatic
     dolphinprivate
 )