]> cloud.milkyroute.net Git - dolphin.git/log
dolphin.git
14 years agoContext menu cleanups
Peter Penz [Sat, 8 Oct 2011 19:40:34 +0000 (21:40 +0200)]
Context menu cleanups

- Open the context menu on the mouse-press event, not on the
  mouse-release event.
- Provide an explicit position-information and don't use
  QCursor::pos(). This fixes the issue that opening a context-menu
  by the keyboard opens below the cursor.
- Provide different signals in the KItemListController for
  the different context-menu types (item vs. view vs. header).
- Implement turning on/off roles by the header-context-menu.

14 years agoAssure that the rubberband is drawn above the items and not below
Peter Penz [Thu, 6 Oct 2011 21:14:04 +0000 (23:14 +0200)]
Assure that the rubberband is drawn above the items and not below

14 years agoProvide alternating background colors for the details-view
Peter Penz [Thu, 6 Oct 2011 21:02:43 +0000 (23:02 +0200)]
Provide alternating background colors for the details-view

14 years agoUse QFontMetrics::height() instead of averageCharWidth()
Peter Penz [Thu, 6 Oct 2011 14:41:29 +0000 (16:41 +0200)]
Use QFontMetrics::height() instead of averageCharWidth()

QFontMetrics::averageCharWidth() is quite slow and does not work
well on fonts with broken characters. In the
usecases required by Dolphin QFontMetrics::height() is a better
and faster alternative to get a font-dependent minimum width.

Thanks go to Christoph Feck for this hint!

14 years agoDon't apply an empty item-size to the layout
Peter Penz [Wed, 5 Oct 2011 15:12:01 +0000 (17:12 +0200)]
Don't apply an empty item-size to the layout

This fixes strange layout-issues when turning on/off previews in the
details-view.

CCBUG: 278899

14 years agoAdd function KItemListSelectionManager::isSelected(int index)
Frank Reininghaus [Mon, 3 Oct 2011 14:42:02 +0000 (16:42 +0200)]
Add function KItemListSelectionManager::isSelected(int index)

This function is used in KItemListView::updateWidgetProperties()
to find out if an item is selected in a more efficient way.
The new function is tested in KItemListSelectionManagerTest.
I've factored out some code from
KItemListSelectionManagerTest::testChangeSelection() to a new
member to simplify the test.

14 years agoRemove TODO-comment which isn't needed anymore
Frank Reininghaus [Mon, 3 Oct 2011 14:22:29 +0000 (16:22 +0200)]
Remove TODO-comment which isn't needed anymore

14 years agoKeep current item and selection when resorting, part 2
Frank Reininghaus [Mon, 3 Oct 2011 14:12:18 +0000 (16:12 +0200)]
Keep current item and selection when resorting, part 2

This commit adds the missing pieces to KItemListView and makes
KFileItemModel::resortAllItems() only emit the itemsMoved() signal.

14 years agoElide the texts if the user shrinks the column-widths
Peter Penz [Sun, 2 Oct 2011 15:33:41 +0000 (17:33 +0200)]
Elide the texts if the user shrinks the column-widths

14 years agoFix layout when the header has been adjusted by the user
Peter Penz [Sun, 2 Oct 2011 14:42:26 +0000 (16:42 +0200)]
Fix layout when the header has been adjusted by the user

14 years agoFix itemsMoved() signal/slot signature: KItemRangeList -> KItemRange
Frank Reininghaus [Fri, 30 Sep 2011 22:50:38 +0000 (00:50 +0200)]
Fix itemsMoved() signal/slot signature: KItemRangeList -> KItemRange

14 years agoImplement smooth-scrolling for horizontal and vertical scrollbars
Peter Penz [Fri, 30 Sep 2011 21:22:56 +0000 (23:22 +0200)]
Implement smooth-scrolling for horizontal and vertical scrollbars

Currently only a smoothscrolling was provided into the
scroll-direction, but not in case of the details-view where a
horizontal scrollbar might be shown too.

Some minor adjustments of the private KItemListSmoothScroller interface
will be done later...

14 years agoKeep current item and selection when resorting, part 1
Frank Reininghaus [Thu, 29 Sep 2011 18:50:00 +0000 (20:50 +0200)]
Keep current item and selection when resorting, part 1

KFileItemModel now emits the itemsMoved signal when the model
is resorted, and KItemListSelectionManager has a new function
itemsMoved() which will be called indirectly when this signal
is emitted. Unit tests for the new functionality are included.
The following things are still needed to make the feature
work:
1. KFileItemMdel::resortAllItems() should not emit
   itemsAdded/itemsRemoved any more.
2. KItemListView::itemsMoved() must update the view according
   to the changes in the model, and it must call
   KItemListSelectionManager::itemsMoved().

14 years agoDetails view: Improve performance when expanding items
Peter Penz [Wed, 28 Sep 2011 18:04:31 +0000 (20:04 +0200)]
Details view: Improve performance when expanding items

Prevent unnecessary calls to visibleRolesSizes() when
expanding items. Also the performance has been improved when
resizing the window.

14 years agoDetails view: Improve performance
Peter Penz [Tue, 27 Sep 2011 18:42:58 +0000 (20:42 +0200)]
Details view: Improve performance

When inserting items or when updating the item-roles there is no
need to recalculate the column-widths for all items to get an
optimized column-width.

14 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Tue, 27 Sep 2011 14:41:03 +0000 (16:41 +0200)]
SVN_SILENT made messages (.desktop file)

14 years agoProvide scrollbar for large items
Peter Penz [Sun, 25 Sep 2011 17:52:33 +0000 (19:52 +0200)]
Provide scrollbar for large items

If an item does not fit into the available width/height a scrollbar
should be provided (e.g. typically this represents the horizontal
scrollbar in the details-view where the width can be larger than
the than the visible width).

Currently the interaction with the scrollbar is not implemented but
this will be a quite minor task in comparison to this patch.

14 years agoFix a spelling mistake in Dolphin.
Andrius Štikonas [Sun, 25 Sep 2011 11:46:38 +0000 (14:46 +0300)]
Fix a spelling mistake in Dolphin.

14 years agoFixed selection of directories with a trailing slash used with --select
Chirag Anand [Sat, 24 Sep 2011 19:36:33 +0000 (01:06 +0530)]
Fixed selection of directories with a trailing slash used with --select
parameter.

As QHash would not match a KUrl key with it's value if the key had a
trailing slash, so it would return -1, hence the file won't get
selected.
Changed the UpdateViewState slot to remove the trailing slash before
calling the index function for the selected URL. Also modified
DolphinView to use KUrl list instead of KFileItemList to maintain
simplicity.

14 years agoUpdate the layout asynchronously when items are changed
Peter Penz [Fri, 23 Sep 2011 22:33:31 +0000 (00:33 +0200)]
Update the layout asynchronously when items are changed

This results in less overhead if item-changes are done rather fast
(e.g. when applying the number of sub directories for the "size"
role).

14 years agoFix size-hint calculation in KFileItemListView
Peter Penz [Fri, 23 Sep 2011 22:18:09 +0000 (00:18 +0200)]
Fix size-hint calculation in KFileItemListView

The current approach works fine but should be replaced in the longterm
by a helper class shared by KFileItemListWidget and
KFileItemListView to share information that is required to
calculate the size hints in KFileItemListView and to represent
the actual data in KFileItemListWidget.

14 years agoIncrease the width of the first column automatically
Peter Penz [Fri, 23 Sep 2011 21:37:42 +0000 (23:37 +0200)]
Increase the width of the first column automatically

Additionally it is assured that on role-changes the size-hints
get updated if necessary.

14 years agoAllow resizing of columns by the user
Peter Penz [Fri, 23 Sep 2011 17:09:01 +0000 (19:09 +0200)]
Allow resizing of columns by the user

Still open:
- Column content is not clipped correctly
- First column is not automatically increased to the available
  width like in Dolphin 1.7

14 years agoUpdate the layout periodically when resizing the window
Peter Penz [Thu, 22 Sep 2011 20:15:40 +0000 (22:15 +0200)]
Update the layout periodically when resizing the window

Up to now the layout has only been updated when the geometry has
not been changed for at least 300 ms. This has been changed so
that at least each 300 ms the layout is updated to give a better
visual feedback when resizing the window.

14 years agoKItemListHeader: Allow resizing and change of the sorting
Peter Penz [Thu, 22 Sep 2011 19:32:59 +0000 (21:32 +0200)]
KItemListHeader: Allow resizing and change of the sorting

KItemListView does not react on the resizing yet. Toggling the
sort order and changing the sort role is already possible.

14 years agoRemove debugging output
Peter Penz [Thu, 22 Sep 2011 16:54:57 +0000 (18:54 +0200)]
Remove debugging output

14 years agoFixed bug for selecting files with --select parameter.
Chirag Anand [Thu, 22 Sep 2011 12:38:49 +0000 (18:08 +0530)]
Fixed bug for selecting files with --select parameter.

Files selected via --select parameter did not get current item focus.
And if files were deleted while being current item, updating the view
would select the next item instead of the first item in the list.

BUG: 257805
CCMAIL: peter.penz19@gmail.com
CCMAIL: frank78ac@googlemail.com

14 years agoImprove drawing of list-header
Peter Penz [Wed, 21 Sep 2011 21:40:51 +0000 (23:40 +0200)]
Improve drawing of list-header

14 years agoShow the role-description in the header of the details view
Peter Penz [Tue, 20 Sep 2011 16:00:39 +0000 (18:00 +0200)]
Show the role-description in the header of the details view

14 years agoChange signature of setVisibleRoles()
Peter Penz [Tue, 20 Sep 2011 13:19:11 +0000 (15:19 +0200)]
Change signature of setVisibleRoles()

Simply use a QList<QByteArray> instead of QHash<QByteArray, int>.

14 years agoFixed documentation of KItemModelBase::itemsMoved()
Peter Penz [Mon, 19 Sep 2011 18:43:00 +0000 (20:43 +0200)]
Fixed documentation of KItemModelBase::itemsMoved()

14 years agoDraw styled header for the details-view
Peter Penz [Mon, 19 Sep 2011 18:34:17 +0000 (20:34 +0200)]
Draw styled header for the details-view

14 years agoRough draft for getting back the header for the details-view
Peter Penz [Mon, 19 Sep 2011 14:38:07 +0000 (16:38 +0200)]
Rough draft for getting back the header for the details-view

14 years agoImplement 'Sort By Size'
Frank Reininghaus [Sun, 18 Sep 2011 14:46:40 +0000 (16:46 +0200)]
Implement 'Sort By Size'

It only works for files so far. The sorting of folders
by the number of items is more tricky to get right because
this number is retrieved asynchronously by
KFileItemModelRolesUpdater.

14 years agoFix crash in version-control-observer
Peter Penz [Sun, 18 Sep 2011 13:06:35 +0000 (15:06 +0200)]
Fix crash in version-control-observer

The returned file-item of the root might be null.

BUG: 282108

14 years agoImplement some missing sorting options
Frank Reininghaus [Sun, 18 Sep 2011 13:03:45 +0000 (15:03 +0200)]
Implement some missing sorting options

Changing the sort order and enabling/disabling the
"Sort Folders First" option works now.

14 years agoImplement DolphinView::sorting()
Frank Reininghaus [Sat, 17 Sep 2011 15:49:20 +0000 (17:49 +0200)]
Implement DolphinView::sorting()

This fixes the problem that changing the sorting criterion
from 'Name' to 'Date' and then back to 'Name' doesn't work.

14 years agoImplement restoring expanded folders in Details View
Frank Reininghaus [Sat, 17 Sep 2011 12:35:25 +0000 (14:35 +0200)]
Implement restoring expanded folders in Details View

14 years agoFix crash when expanding/closing a sub-tree
Peter Penz [Fri, 16 Sep 2011 20:33:00 +0000 (22:33 +0200)]
Fix crash when expanding/closing a sub-tree

m_pendingItems and m_pendingInvisibleItems might contain already
removed items. Take care to delete them before starting to resolve
the roles.

Thanks to Frank Reininghaus for finding out the root-cause.

14 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Mon, 12 Sep 2011 07:37:32 +0000 (09:37 +0200)]
SVN_SILENT made messages (.desktop file)

14 years agoFix possible crash in KFileItemModel::slotRefreshItems()
Frank Reininghaus [Sat, 10 Sep 2011 19:55:27 +0000 (21:55 +0200)]
Fix possible crash in KFileItemModel::slotRefreshItems()

If the changed items have been created recently, they might not be in
m_items yet.  In that case, the list 'indexes' might be empty, which
leads to a crash later on (I saw the crash in KFileItemModel's unit
test).

14 years agoProvide KVersionControlPlugin version 2
Peter Penz [Sat, 10 Sep 2011 16:08:03 +0000 (18:08 +0200)]
Provide KVersionControlPlugin version 2

Based on the work of Vishesh Yadav some extensions where required
for the KVersionControlPlugin interface that have found there way
now into KVersionControlPlugin2.

Beside some interface cleanups it is now possible that a version
control plugin may also provide context actions for directories or
files that are not versioned yet.

REVIEW: 102541

14 years agoImprove cache handling in KItemListWidget
Peter Penz [Fri, 9 Sep 2011 18:34:55 +0000 (20:34 +0200)]
Improve cache handling in KItemListWidget

Provide a hook for derived KItemListWidget where the cache
can be updated.

14 years agoVersion control: Show context menu entries of plugins
Peter Penz [Fri, 9 Sep 2011 17:21:22 +0000 (19:21 +0200)]
Version control: Show context menu entries of plugins

14 years agoVersion control: Get rid of PendingThreadsMaintainer
Peter Penz [Fri, 9 Sep 2011 10:27:11 +0000 (12:27 +0200)]
Version control: Get rid of PendingThreadsMaintainer

14 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Fri, 9 Sep 2011 07:18:36 +0000 (09:18 +0200)]
SVN_SILENT made messages (.desktop file)

14 years agoKFileItemModel: emit itemsChanged() signal
Peter Penz [Thu, 8 Sep 2011 19:16:14 +0000 (21:16 +0200)]
KFileItemModel: emit itemsChanged() signal

14 years agoVersion control: show pixmap overlays for the version state
Peter Penz [Thu, 8 Sep 2011 18:28:41 +0000 (20:28 +0200)]
Version control: show pixmap overlays for the version state

14 years agoVersion control: Apply text-color if an item is versioned
Peter Penz [Thu, 8 Sep 2011 16:57:52 +0000 (18:57 +0200)]
Version control: Apply text-color if an item is versioned

14 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Thu, 8 Sep 2011 07:00:21 +0000 (09:00 +0200)]
SVN_SILENT made messages (.desktop file)

14 years agoFirst step to reactivate version control plugin functionality
Peter Penz [Tue, 6 Sep 2011 21:42:42 +0000 (23:42 +0200)]
First step to reactivate version control plugin functionality

- Add a DolphinFileItemListWidget that provides icon-overlays
  and colored text for the version state (implementation is
  missing yet)
- Allow KFileItemListWidget to have custom text colors
- Update interface of VersionControlObserver to work with
  KFileItemModel instead of the old model-interface.

14 years agoImproved drag and drop support
Peter Penz [Sun, 4 Sep 2011 15:40:44 +0000 (17:40 +0200)]
Improved drag and drop support

14 years agoSimplified code for the viewmode settings
Peter Penz [Fri, 2 Sep 2011 17:48:57 +0000 (19:48 +0200)]
Simplified code for the viewmode settings

14 years agoImprove autoscrolling
Peter Penz [Thu, 1 Sep 2011 21:08:22 +0000 (23:08 +0200)]
Improve autoscrolling

- Start autoscrolling when doing a dragging
- Start autoscrolling with a small delay

14 years agoPreserve extensions when renaming multiple files
Peter Penz [Thu, 1 Sep 2011 16:56:53 +0000 (18:56 +0200)]
Preserve extensions when renaming multiple files

Thanks to Chiraq Anand for the patch! The commit is based on the
patch at https://git.reviewboard.kde.org/r/102495/ with some
minor modifications.

REVIEW: 102495

14 years agoRemoved warning, minor coding style update
Peter Penz [Thu, 1 Sep 2011 13:56:54 +0000 (15:56 +0200)]
Removed warning, minor coding style update

14 years agoFix issue when moving items to trash
Peter Penz [Thu, 1 Sep 2011 13:43:59 +0000 (15:43 +0200)]
Fix issue when moving items to trash

KDirLister does not emit a completed() signal when deleting files,
only when files are listed.

14 years agoItems are expandable in the Details View.
Frank Reininghaus [Wed, 31 Aug 2011 10:17:08 +0000 (12:17 +0200)]
Items are expandable in the Details View.

14 years agoImplement DolphinView::simplifiedSelectedUrls()
Frank Reininghaus [Tue, 30 Aug 2011 17:03:39 +0000 (19:03 +0200)]
Implement DolphinView::simplifiedSelectedUrls()

Makes it possible to trash and delete items.

14 years agoKItemListKeyboardSearchManager improvements and unit tests
Frank Reininghaus [Tue, 30 Aug 2011 11:10:38 +0000 (13:10 +0200)]
KItemListKeyboardSearchManager improvements and unit tests

This commit implements a 'repeated key search' feature, similar
to QAbstractItemView, and adds unit tests for keyboard searching.

14 years agoMade items a const.
Tirtha Chatterjee [Tue, 30 Aug 2011 08:02:00 +0000 (13:32 +0530)]
Made items a const.

14 years agoDolphinView zoom with CTRL+MouseWheel REVIEW: 102490
Vishesh Yadav [Tue, 30 Aug 2011 12:46:27 +0000 (18:16 +0530)]
DolphinView zoom with CTRL+MouseWheel REVIEW: 102490

14 years agoUsing selectedItems() method already present in DolphinView for slotItemActivated()
Tirtha Chatterjee [Tue, 30 Aug 2011 06:47:36 +0000 (12:17 +0530)]
Using selectedItems() method already present in DolphinView for slotItemActivated()

14 years agoFix context-menu selection issue
Peter Penz [Mon, 29 Aug 2011 18:45:46 +0000 (20:45 +0200)]
Fix context-menu selection issue

When requesting a context menu above a non-selected item, the
existing selection must be cleared.

14 years agoRenamed some signals for consistency with KItemViews classes
Peter Penz [Mon, 29 Aug 2011 18:13:39 +0000 (20:13 +0200)]
Renamed some signals for consistency with KItemViews classes

14 years agoFixed a trivial bug that was breaking build.
Tirtha Chatterjee [Mon, 29 Aug 2011 15:48:23 +0000 (21:18 +0530)]
Fixed a trivial bug that was breaking build.

14 years agoAdded the functionality to activate items by pressing 'enter' or 'return' key on...
Tirtha Chatterjee [Mon, 29 Aug 2011 15:43:36 +0000 (21:13 +0530)]
Added the functionality to activate items by pressing 'enter' or 'return' key on them, equivalent to a mouse click.

REVIEW: 102450

14 years agoRemoved a warning of unused variable
Tirtha Chatterjee [Mon, 29 Aug 2011 08:59:19 +0000 (14:29 +0530)]
Removed a warning of unused variable

14 years agoAdded support for highlighting items by typing their name on the keyboard.
Tirtha Chatterjee [Sun, 28 Aug 2011 22:42:05 +0000 (04:12 +0530)]
Added support for highlighting items by typing their name on the keyboard.

14 years agoControl-rubberband selection toggles the selection state
Frank Reininghaus [Sun, 28 Aug 2011 17:16:14 +0000 (19:16 +0200)]
Control-rubberband selection toggles the selection state

14 years agoAdjust the current item when selecting an expansion toggle
Peter Penz [Sat, 27 Aug 2011 21:37:28 +0000 (23:37 +0200)]
Adjust the current item when selecting an expansion toggle

14 years agoImprove the autoscrolling for the rubberband selection
Peter Penz [Sat, 27 Aug 2011 18:12:03 +0000 (20:12 +0200)]
Improve the autoscrolling for the rubberband selection

This modifications will also allow to do an autoscrolling in an
easy way for drag and drop operations (not fully implemented yet).

14 years agoMinor simplification
Peter Penz [Sat, 27 Aug 2011 11:37:49 +0000 (13:37 +0200)]
Minor simplification

14 years agoRespect the KGlobalSettings::singleClick() attribute, function accordingly
Tirtha Chatterjee [Sat, 27 Aug 2011 10:25:29 +0000 (15:55 +0530)]
Respect the KGlobalSettings::singleClick() attribute, function accordingly

REVIEW: 102447

14 years agoRemove unneded function KItemListSelectionManager::anchorItem()
Frank Reininghaus [Sat, 27 Aug 2011 08:23:40 +0000 (10:23 +0200)]
Remove unneded function KItemListSelectionManager::anchorItem()

14 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sat, 27 Aug 2011 08:02:42 +0000 (10:02 +0200)]
SVN_SILENT made messages (.desktop file)

14 years agoSimplify KItemListSelectionManager
Frank Reininghaus [Fri, 26 Aug 2011 16:39:32 +0000 (18:39 +0200)]
Simplify KItemListSelectionManager

1. The anchorChanged() signal is not needed.
2. The only place where setAnchorItem() is called is in
   beginAnchoredSelection() -> merge both functions.

14 years agoImplement DolphinView::selectionMimeData()
Frank Reininghaus [Fri, 26 Aug 2011 15:34:54 +0000 (17:34 +0200)]
Implement DolphinView::selectionMimeData()

BUG:280456

14 years agoFix issue that removing an item is not recognized
Peter Penz [Fri, 26 Aug 2011 06:08:11 +0000 (08:08 +0200)]
Fix issue that removing an item is not recognized

Thanks to Tirtha Chatterjee for the patch!

REVIEW: 102435

14 years agoFix smooth-scrolling issue in combination with key-presses
Peter Penz [Thu, 25 Aug 2011 14:52:14 +0000 (16:52 +0200)]
Fix smooth-scrolling issue in combination with key-presses

If e.g. the down-arrow-key is pressed constantly the view does not
scroll as the animation always will get restarted. Assure that
the animation proceeds in this case.

14 years agoFix smooth-scrolling issue
Peter Penz [Thu, 25 Aug 2011 13:42:39 +0000 (15:42 +0200)]
Fix smooth-scrolling issue

The smooth-scrolling may only get turned off after finishing the
animation, if the scrollbar is not currently modified by the user.

14 years agoFix issues with the anchor selection
Peter Penz [Wed, 24 Aug 2011 20:36:05 +0000 (22:36 +0200)]
Fix issues with the anchor selection

Don't change the selection if the anchor is invalid. This fixes
the issue that items might get selected during changing a directory.

14 years agoDragging and selection fixes
Peter Penz [Wed, 24 Aug 2011 19:28:46 +0000 (21:28 +0200)]
Dragging and selection fixes

- Don't clear the selection on mouse-press events, do it (if
  allowed) in the mouse-release-event. Otherwise dragging of
  multiple selected items would not be possible.
- Don't clear the selection when the context-menu gets opened
  by a right-click.
- Fix issue that dragging is not possible after the first
  drop that has been canceled.

14 years agoImprove KFileItemModel::createMimeData()
Peter Penz [Wed, 24 Aug 2011 18:23:53 +0000 (20:23 +0200)]
Improve KFileItemModel::createMimeData()

Use the same approach like in KDirModel::mimeData().

14 years agoInterface cleanups for drag and drop support
Peter Penz [Wed, 24 Aug 2011 16:11:55 +0000 (18:11 +0200)]
Interface cleanups for drag and drop support

14 years agoSetting accessible name to zoom slider in Dolphin
José Millán Soto [Fri, 12 Aug 2011 09:32:35 +0000 (11:32 +0200)]
Setting accessible name to zoom slider in Dolphin

14 years agoMaking KonqStatusBarMessageLabel accessible
José Millán Soto [Fri, 12 Aug 2011 12:57:56 +0000 (14:57 +0200)]
Making KonqStatusBarMessageLabel accessible

14 years agoRough draft for getting back drag and drop support
Peter Penz [Tue, 23 Aug 2011 18:55:41 +0000 (20:55 +0200)]
Rough draft for getting back drag and drop support

Includes a lot of TODOs but is a base for getting back full drag
and drop support quite soon.

14 years agoFix rubberband-issue in combination with Shift- and Control-key
Peter Penz [Sat, 20 Aug 2011 21:26:07 +0000 (23:26 +0200)]
Fix rubberband-issue in combination with Shift- and Control-key

The old selection must be remembered before starting the rubberband
selection, otherwise it would not be possible anymore to deselect
items that have been selected by the rubberband itself.

14 years agoRespect Shift- and Control-key for the rubberband selection
Peter Penz [Sat, 20 Aug 2011 21:11:55 +0000 (23:11 +0200)]
Respect Shift- and Control-key for the rubberband selection

If the user has pressed the Shift- or Control-key during the
rubberband selection, the previous selection should not be cleared.

14 years agoSimplify rubberband selection for views that have only one column
Peter Penz [Sat, 20 Aug 2011 21:02:02 +0000 (23:02 +0200)]
Simplify rubberband selection for views that have only one column

In this case the rubberband automatically uses the whole width of
the view.

14 years agoSelect items when using the rubberband
Peter Penz [Sat, 20 Aug 2011 20:52:45 +0000 (22:52 +0200)]
Select items when using the rubberband

14 years agoRespect rubberband direction when autoscrolling
Peter Penz [Sat, 20 Aug 2011 12:20:08 +0000 (14:20 +0200)]
Respect rubberband direction when autoscrolling

The autoscrolling should not be triggered if the rubberband
direction is different from the autoscroll direction

14 years agoFix possible endless recursion when using the rubberband
Peter Penz [Sat, 20 Aug 2011 11:52:36 +0000 (13:52 +0200)]
Fix possible endless recursion when using the rubberband

If the autoscrolling has been activated when using the rubberband,
it was possible that an endless recursion occured as the
autoscrolling triggered a change of the rubberband which triggered
a change of the autoscrolling etc.

14 years agoProvide basic rubberband functionality
Peter Penz [Thu, 18 Aug 2011 21:11:16 +0000 (23:11 +0200)]
Provide basic rubberband functionality

This is just a rough draft: The rubberband gets visible and an
automatic scrolling is done if the autoscroll-margins have been
reached. However currently no items get selected yet. Currently
the autoscrolling has a severe bug if the scrollbars are manually
changed before or after a rubberband selection.

14 years agoAdd unit test for expanding folders in KFileItemModel
Frank Reininghaus [Mon, 15 Aug 2011 19:06:06 +0000 (21:06 +0200)]
Add unit test for expanding folders in KFileItemModel

14 years agoAllow to adjust start-index when renaming a various number of items
Peter Penz [Mon, 15 Aug 2011 18:34:28 +0000 (20:34 +0200)]
Allow to adjust start-index when renaming a various number of items

Review: http://git.reviewboard.kde.org/r/102328/
Thanks to Chirag Anand for the patch!

CCMAIL: anand.chirag@gmail.com

14 years agoFix for KFileItemModel::expansionLevelsCompare
Frank Reininghaus [Mon, 15 Aug 2011 11:05:53 +0000 (13:05 +0200)]
Fix for KFileItemModel::expansionLevelsCompare

Before this commit, expanding and collapsing folders in the details
view would lead to strange results in a folder with the items "a",
"a/a/", "a/a/1", "a/a-1/", and "a/a-1/1".  The problem was that the
comparison between "a/a/1" and "a/a-1/1" went wrong: the first
character in which the paths differ is a "/" in one of the items, such
that the code that reduces this 'index' in
KFileItemModel::expansionLevelsCompare in order to find the 'common
path' did nothing because it checked that only *one* of the two items
does not have an "/" at the position 'index'.

14 years agoRemove incorrect asserts
Frank Reininghaus [Sun, 14 Aug 2011 17:35:06 +0000 (19:35 +0200)]
Remove incorrect asserts

They could lead to crashes if the Details View is used and the
view is not wide enough to show all columns for the items.

14 years agoKeep the current item visible in the view
Frank Reininghaus [Sun, 14 Aug 2011 15:20:33 +0000 (17:20 +0200)]
Keep the current item visible in the view