Peter Penz [Thu, 13 May 2010 22:06:10 +0000 (22:06 +0000)]
If an information entry will be added to KFileItemDelegate (like done recently), adjusting the corresponding code in Dolphin is a real pain, as the new information will be shown in Dolphin the following way:
- As additional columns in the details view
- As additional lines in the icons view
- As menu entries in the "Sort By" and "Additional Information" groups
- As popup menu entries in the details view header popup
- As checkable entries in the View Properties dialog
To prevent similar painful transitions in future, the class AdditionalInfoManager has been introduced. All parts in Dolphin that access/show/store additional information, use the AdditionalInfoManager now. If a new information entry will be added in KFileItemDelegate in future, only a small adjustment in AdditionalInfoManager will be required.
Still open currently:
- AdditionalInfoDialog does not use AdditionalInfoManager yet
- DolphinView::Sorting should be replaced by KFileItemDelegate::Information, so that the sorting can also be done in a generic way.
- The data for KFileItemDelegate::PathOrUrl is not determined
The open issues will get fixed during the next days.
Kudos to the brave warriors Sebastian and Frank, that tried to add a new information ;-)
Peter Penz [Mon, 3 May 2010 17:49:49 +0000 (17:49 +0000)]
Create QActionGroup like done for other sub menus for consistency. Although a few more lines of code are required, this approach is more flexible.bar, but as the group "Panels" can be added instead, this should be no issue.
Peter Penz [Mon, 3 May 2010 17:46:34 +0000 (17:46 +0000)]
Use the dock widgets actions directly, as they are capable of showing the toggle state. Drawback: The actions cannot be added directly to the toolbar, but as the group "Panels" can be added instead, this should be no issue.
David Faure [Mon, 26 Apr 2010 15:50:59 +0000 (15:50 +0000)]
use KFileItemActions::runPreferredApplications to handle Key_Enter on multiple selected files.
Rewritten to make a direct method call rather than using a signal from 'this'.
REVIEW: 3163
CCMAIL: toddrme2178@gmail.com
Peter Penz [Sun, 4 Apr 2010 20:45:09 +0000 (20:45 +0000)]
Invert default behavior regarding loading of version control plugins: Only load plugins that have been explicitly enabled by the user instead of loading all plugins per default.
Most users won't use version control plugins at all and there is no need in wasting memory and performance. A user interface has been added in the "Services" settings for version control plugins. The user interface is only shown, if at least one plugin is available on the system.
Peter Penz [Sat, 3 Apr 2010 08:48:35 +0000 (08:48 +0000)]
Cleanup of statusbar widgets:
- Provide proper size hints instead of hiding extensions on small widths
- Provide context menu, which allows to enable/disable the zoom level extension and the space info extension. Also copying the status bar text is possible (useful e. g. for error messages).
Peter Penz [Tue, 30 Mar 2010 20:19:32 +0000 (20:19 +0000)]
Split the class DolphinController into the two classes DolphinViewController and ViewModeController.
The ViewModeController offers a defined interface to control view mode implementations like icons view, details view and column view. The DolphinViewController allows those view mode implementations to control the parent DolphinView in a limited way.
Peter Penz [Wed, 24 Mar 2010 22:41:06 +0000 (22:41 +0000)]
Renamed methods and improved documentation, as in the previous patch the wrong mutex has been used accidently because of the confusing naming of the methods.
Peter Penz [Wed, 24 Mar 2010 22:21:09 +0000 (22:21 +0000)]
Version control: Move the maintainance of pending threads into a custom class. Also the UpdateItemStatesThread differs now between protecting the globally shared plugin and the locally shared data.
Peter Penz [Mon, 22 Mar 2010 18:48:12 +0000 (18:48 +0000)]
Use the default keyboard shortcuts for next-tab/previous-tab as primary key, but use the commonly used shortcuts Ctrl+Tab/Ctrl+Shift+Tab as secondary keys.
Of course it is still possible that the user defines custom shortcuts.
Get back names, and use "using" keyword to keep GCC silent on "method foo on base class hidden y method foo on derived class". Thanks to André for pointing out this trick.
Peter Penz [Sun, 14 Mar 2010 16:21:35 +0000 (16:21 +0000)]
Fix issue that the current terminal line does not get cleared before sending a cd command.
The terminal interface does not provide an API for this, so as workaround backspaces are send. Not nice, but as the issue can lead to data loss, this solution is better than having nothing.
Peter Penz [Tue, 9 Mar 2010 07:13:51 +0000 (07:13 +0000)]
Port patch 1098976 for Konqueror by David Faure to Dolphin: When the user clicks on a Type=Link desktop files that point to a directory, let's open that
directory in the current view, rather than starting a new Konqueror.
As requested by LukasLT for http://forum.kde.org/viewtopic.php?f=14&t=66660
Peter Penz [Thu, 4 Mar 2010 16:24:20 +0000 (16:24 +0000)]
Rename NfoTranslator to KNfoTranslator, so that KMetaDataWidget can be moved to kdelibs for KDE SC 4.5 (some interfaces of KMetaDataWidget need to be cleaned up first).
KNfoTranslator is marked as private class, as it is not clear yet whether it should be used by other classes like KFileMetaInfo.
Peter Penz [Fri, 26 Feb 2010 22:03:32 +0000 (22:03 +0000)]
Meta data configuration cleanups:
- Use RDF labels internally.
- Provide better default settings, which meta data are hidden.
- Allow to configure which meta data is shown also if Nepomuk is turned off.
Peter Penz [Fri, 26 Feb 2010 14:42:47 +0000 (14:42 +0000)]
The number of fixed meta-info items may vary dependent on whether Nepomuk is enabled or not. Avoid the nasty hack to hardcode the value within the slotLoadingFinished() method.
Peter Penz [Thu, 25 Feb 2010 20:54:02 +0000 (20:54 +0000)]
Request the activation of the view, even if the column is marked as active already: The activation state of a column is independent from from the activation state of the view.
This fixes the regression that items for inactive views containing columns get triggered.
Peter Penz [Thu, 25 Feb 2010 19:36:36 +0000 (19:36 +0000)]
Forward port of SVN commit 1096089: Fix regression that columns stay empty when switching between URLs that differ by more than one sub directory. Thanks to Frank Reininghaus for the analysis.
Remove all code that is related to DolphinController's
requestUrlChange signal. This signal was removed in r1080351, so the
code isn't needed any more.
Peter Penz [Sun, 21 Feb 2010 13:29:32 +0000 (13:29 +0000)]
Forward port of SVN commit 1093803: Assure that the changed selection model is reconnected when changing columns. This fixes the regression that some operations have been disabled on sub columns. Thanks to Frank Reininghaus for the analyses.