Peter Penz [Sat, 14 Jan 2012 20:44:50 +0000 (21:44 +0100)]
Fix "general settings" issues
If the general settings for the "selection toggle" or "expanding folders during
drag operations" are changed, those changes must be applied to the engine.
Peter Penz [Mon, 9 Jan 2012 21:10:12 +0000 (22:10 +0100)]
Prevent generating previews all the time during downloading a large file
When downloading a large file the preview should not be recreated each time
a change-notification has been received. Create the preview after getting
the first file change, but postpone creating the next previews until no change
has been done during a longer period of time.
Peter Penz [Mon, 9 Jan 2012 21:10:12 +0000 (22:10 +0100)]
Prevent generating previews all the time during downloading a large file
When downloading a large file the preview should not be recreated each time
a change-notification has been received. Create the preview after getting
the first file change, but postpone creating the next previews until no change
has been done during a longer period of time.
Peter Penz [Sat, 7 Jan 2012 11:32:06 +0000 (12:32 +0100)]
Use the native graphicssystem per default
The scaling of pixmaps is just way too slow with the raster graphicssystem (see KPixmapModifier::scalePixmap()). It is of course still possible to run Dolphin
with the raster graphicssystem, but this has to be done explicitly then.
Peter Penz [Sat, 7 Jan 2012 11:32:06 +0000 (12:32 +0100)]
Use the native graphicssystem per default
The scaling of pixmaps is just way too slow with the raster graphicssystem (see KPixmapModifier::scalePixmap()). It is of course still possible to run Dolphin
with the raster graphicssystem, but this has to be done explicitly then.
Peter Penz [Thu, 5 Jan 2012 20:37:58 +0000 (21:37 +0100)]
Temporary skip 2 unit-tests in KFileItemModel
KFileItemModel::resortAllItems() always emits a itemsMoved() signal since some
time. Before blindly adjusting the tests lets discuss first whether
resortAllItems() should be used in this context.
Peter Penz [Thu, 5 Jan 2012 20:37:58 +0000 (21:37 +0100)]
Temporary skip 2 unit-tests in KFileItemModel
KFileItemModel::resortAllItems() always emits a itemsMoved() signal since some
time. Before blindly adjusting the tests lets discuss first whether
resortAllItems() should be used in this context.
Peter Penz [Thu, 29 Dec 2011 23:02:17 +0000 (00:02 +0100)]
Fix inconsistency in selection manager
When a selection has been done with non-linear ranges, it was possible that
the anchor item pointed to an invalid index that resulted into an invalid
selection.
As part of this fix the sorting for DolphinView::selectedItems() has been
disabled (if the caller assumes a sorted selection he must manually adjust it).
Peter Penz [Thu, 29 Dec 2011 23:02:17 +0000 (00:02 +0100)]
Fix inconsistency in selection manager
When a selection has been done with non-linear ranges, it was possible that
the anchor item pointed to an invalid index that resulted into an invalid
selection.
As part of this fix the sorting for DolphinView::selectedItems() has been
disabled (if the caller assumes a sorted selection he must manually adjust it).
Peter Penz [Mon, 26 Dec 2011 21:28:54 +0000 (22:28 +0100)]
Improve item offset scrolling
Don't check whether the m_layoutTimer is active: Changing the
item offset must always trigger a synchronous layout, otherwise
the smooth-scrolling might get jerky.
Peter Penz [Mon, 26 Dec 2011 21:28:54 +0000 (22:28 +0100)]
Improve item offset scrolling
Don't check whether the m_layoutTimer is active: Changing the
item offset must always trigger a synchronous layout, otherwise
the smooth-scrolling might get jerky.
Peter Penz [Sun, 25 Dec 2011 21:34:45 +0000 (22:34 +0100)]
Fix grouping issue
When switching to a group that is not shown currently, the group headers
won't be updated. The root-cause was that the m_groups-cache must be reset
when the roles have been changed.
Peter Penz [Sun, 25 Dec 2011 21:34:45 +0000 (22:34 +0100)]
Fix grouping issue
When switching to a group that is not shown currently, the group headers
won't be updated. The root-cause was that the m_groups-cache must be reset
when the roles have been changed.
Peter Penz [Sun, 25 Dec 2011 10:35:05 +0000 (11:35 +0100)]
Fix wrong grouping of types
- Uninitialized types count as one group
- Let the receiver of the signal itemsMoved() decide whether unmoved items
really result in an unchanged visual appearance. This might e.g. be the case
if the grouping is turned on and the group-names change although the items
themselves have not changed their position.
Peter Penz [Sun, 25 Dec 2011 10:35:05 +0000 (11:35 +0100)]
Fix wrong grouping of types
- Uninitialized types count as one group
- Let the receiver of the signal itemsMoved() decide whether unmoved items
really result in an unchanged visual appearance. This might e.g. be the case
if the grouping is turned on and the group-names change although the items
themselves have not changed their position.
Peter Penz [Sat, 24 Dec 2011 13:12:09 +0000 (14:12 +0100)]
Fix sort-issue for trees
If a protocol like fish is used, the sorting of sub-trees was wrong. The root
cause was a wrong comparing of URLs where the protocol was not initialized.
Peter Penz [Sat, 24 Dec 2011 13:12:09 +0000 (14:12 +0100)]
Fix sort-issue for trees
If a protocol like fish is used, the sorting of sub-trees was wrong. The root
cause was a wrong comparing of URLs where the protocol was not initialized.
Peter Penz [Fri, 23 Dec 2011 22:05:08 +0000 (23:05 +0100)]
Introduce "isExpandable" role
The role is used to determine whether a directory can be expanded at all. This
is e.g. not the case if a directory has 0 items or the target-URL is different
from the item-URL.
The expansion toggle will get hidden if a directory is not expandable.
Peter Penz [Fri, 23 Dec 2011 22:05:08 +0000 (23:05 +0100)]
Introduce "isExpandable" role
The role is used to determine whether a directory can be expanded at all. This
is e.g. not the case if a directory has 0 items or the target-URL is different
from the item-URL.
The expansion toggle will get hidden if a directory is not expandable.
Peter Penz [Fri, 23 Dec 2011 20:10:32 +0000 (21:10 +0100)]
Fix possible double entries in details view
The patch 30ae57ba807ecadfdef833a4895621fc330badc9 did not resolve the
issue completely: The pending items to insert must be dispatched before
checking for duplicates.
Related to this report the expanding for the remote-protocol has been
disabled.
Peter Penz [Fri, 23 Dec 2011 20:10:32 +0000 (21:10 +0100)]
Fix possible double entries in details view
The patch 30ae57ba807ecadfdef833a4895621fc330badc9 did not resolve the
issue completely: The pending items to insert must be dispatched before
checking for duplicates.
Related to this report the expanding for the remote-protocol has been
disabled.
Peter Penz [Fri, 23 Dec 2011 15:01:23 +0000 (16:01 +0100)]
The key "space" should select the current item
Also in case if only one item is shown the navigation-keys should
trigger a selection of the current item. This works now consistent
within all view-modes (there have been been behavior differences
in Dolphin 1.7 depending on the used mode).
Peter Penz [Fri, 23 Dec 2011 15:01:23 +0000 (16:01 +0100)]
The key "space" should select the current item
Also in case if only one item is shown the navigation-keys should
trigger a selection of the current item. This works now consistent
within all view-modes (there have been been behavior differences
in Dolphin 1.7 depending on the used mode).
Peter Penz [Thu, 22 Dec 2011 20:46:17 +0000 (21:46 +0100)]
Don't show child items of collapsed parent items
If a parent item got expanded and collapsed again, KDirLister keeps
the items of the previously expanded directory. Hence inserting new
items there will result in emitting the signal newItems() and a check
must be done whether the parent is still expanded.
Peter Penz [Thu, 22 Dec 2011 20:46:17 +0000 (21:46 +0100)]
Don't show child items of collapsed parent items
If a parent item got expanded and collapsed again, KDirLister keeps
the items of the previously expanded directory. Hence inserting new
items there will result in emitting the signal newItems() and a check
must be done whether the parent is still expanded.
KFileItemModel: Always use upper case letters to group by name
This fixes the following problems:
1. In a folder containing the items ~a and b, the first group,
containing ~a, is named "Others".
2. In a folder containing the items a, ~b, ~c, and ~d, the first group
"A" contains a and ~b, and the other two items are in the group
"Others".
Peter Penz [Fri, 16 Dec 2011 22:55:48 +0000 (23:55 +0100)]
Animation finetuning
If dynamic item sizes are used don't animate the size of the widget
in along the dynamic direction. This prevents unnecessary animations when
increasing the window width in combination with e.g. the details view.
Peter Penz [Fri, 16 Dec 2011 22:37:49 +0000 (23:37 +0100)]
Minor layout and coding style cleanups
- Disable performance debugging output
- Force a synchronous layout during scrolling. This prevents having a jerky
scroll-animation if there are pending operations ongoing in parallel.
- Minor coding style cleanups