]> cloud.milkyroute.net Git - dolphin.git/log
dolphin.git
16 years agoSVN_SILENT: coding style fix
Peter Penz [Tue, 3 Mar 2009 20:59:11 +0000 (20:59 +0000)]
SVN_SILENT: coding style fix

svn path=/trunk/KDE/kdebase/apps/; revision=934820

16 years agodon't show the phonon widget, if more than one file is selected
Peter Penz [Tue, 3 Mar 2009 20:38:07 +0000 (20:38 +0000)]
don't show the phonon widget, if more than one file is selected

svn path=/trunk/KDE/kdebase/apps/; revision=934812

16 years agoreset the information panel if an item is shown that got deleted
Peter Penz [Tue, 3 Mar 2009 20:20:44 +0000 (20:20 +0000)]
reset the information panel if an item is shown that got deleted

BUG: 186071

svn path=/trunk/KDE/kdebase/apps/; revision=934807

16 years agoonly add the service to the list, if there is no other service using the same name
Peter Penz [Tue, 3 Mar 2009 19:39:36 +0000 (19:39 +0000)]
only add the service to the list, if there is no other service using the same name

svn path=/trunk/KDE/kdebase/apps/; revision=934788

16 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Tue, 3 Mar 2009 14:52:10 +0000 (14:52 +0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/KDE/kdebase/apps/; revision=934676

16 years agoChanged activated() signal usages... to currentIndexChanged();
Shaun Reich [Tue, 3 Mar 2009 01:07:55 +0000 (01:07 +0000)]
Changed activated() signal usages... to currentIndexChanged();

svn path=/trunk/KDE/kdebase/apps/; revision=934414

16 years agoFixed a security bug in dolphin when handling malformed http urls.
Jose Carlos Norte [Mon, 2 Mar 2009 00:03:21 +0000 (00:03 +0000)]
Fixed a security bug in dolphin when handling malformed http urls.

svn path=/trunk/KDE/kdebase/apps/; revision=933947

16 years agoUse currentIndexChanged() signal instead of activated(), the latter does not always...
Shaun Reich [Sun, 1 Mar 2009 21:11:12 +0000 (21:11 +0000)]
Use currentIndexChanged() signal instead of activated(), the latter does not always do what you would think.

svn path=/trunk/KDE/kdebase/apps/; revision=933889

16 years agoChanged deprecated use of signal closeRequested(int) to tabCloseRequested(int)
Shaun Reich [Sun, 1 Mar 2009 18:19:38 +0000 (18:19 +0000)]
Changed deprecated use of signal closeRequested(int) to tabCloseRequested(int)

svn path=/trunk/KDE/kdebase/apps/; revision=933837

16 years agoSVN_SILENT made messages (.desktop file, second try)
Script Kiddy [Sun, 1 Mar 2009 14:50:50 +0000 (14:50 +0000)]
SVN_SILENT made messages (.desktop file, second try)

svn path=/trunk/KDE/kdebase/apps/; revision=933737

16 years agoSVN_SILENT: minor coding style cleanups
Peter Penz [Sun, 1 Mar 2009 12:42:51 +0000 (12:42 +0000)]
SVN_SILENT: minor coding style cleanups

svn path=/trunk/KDE/kdebase/apps/; revision=933598

16 years agoremoved Quick-View code (it has already been disabled before)
Peter Penz [Sun, 1 Mar 2009 12:23:05 +0000 (12:23 +0000)]
removed Quick-View code (it has already been disabled before)

svn path=/trunk/KDE/kdebase/apps/; revision=933591

16 years agodon't make the struct ClosedTab accessible for other classes
Peter Penz [Sun, 1 Mar 2009 12:20:23 +0000 (12:20 +0000)]
don't make the struct ClosedTab accessible for other classes

CCMAIL: predator106@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=933589

16 years agoFixed a bug in the "Recently Closed Tabs" menu that would cause it to show more recen...
Shaun Reich [Sun, 1 Mar 2009 02:27:35 +0000 (02:27 +0000)]
Fixed a bug in the "Recently Closed Tabs" menu that would cause it to show more recent tabs at the bottom.

The most recent tab will now always be shown right below the separator, which is right below the "Clear Recently Closed Tabs" action.

svn path=/trunk/KDE/kdebase/apps/; revision=933487

16 years agoClosed tabs are now remembered within Dolphin, so if you accidentally close them...
Shaun Reich [Sun, 1 Mar 2009 01:38:20 +0000 (01:38 +0000)]
Closed tabs are now remembered within Dolphin, so if you accidentally close them, or need to reopen a previous one-go crazy.

Closed tabs now become stored in the "Go"->"Recently Closed Tabs" menu.

To clear this list, there is an action within that menu.

Clicking on a remembered tab's action, will remove that entry, restore that tab, and focus it.

svn path=/trunk/KDE/kdebase/apps/; revision=933483

16 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sat, 28 Feb 2009 13:35:50 +0000 (13:35 +0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/KDE/kdebase/apps/; revision=933233

16 years agoFix warning about shortcut
Laurent Montel [Sat, 28 Feb 2009 12:50:34 +0000 (12:50 +0000)]
Fix warning about shortcut

svn path=/trunk/KDE/kdebase/apps/; revision=933227

16 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Fri, 27 Feb 2009 15:36:31 +0000 (15:36 +0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/KDE/kdebase/apps/; revision=932916

16 years agoadd KCM for the services settings, so that they are also accessible in Konqueror
Peter Penz [Thu, 26 Feb 2009 20:38:42 +0000 (20:38 +0000)]
add KCM for the services settings, so that they are also accessible in Konqueror

svn path=/trunk/KDE/kdebase/apps/; revision=932520

16 years agoadjust size hints of group boxes
Peter Penz [Thu, 26 Feb 2009 20:10:27 +0000 (20:10 +0000)]
adjust size hints of group boxes

svn path=/trunk/KDE/kdebase/apps/; revision=932509

16 years agoCalling the "Show" group "hiddenGroup" is a bit surprising to the casual reader ;)
David Faure [Thu, 26 Feb 2009 20:08:22 +0000 (20:08 +0000)]
Calling the "Show" group "hiddenGroup" is a bit surprising to the casual reader ;)

svn path=/trunk/KDE/kdebase/apps/; revision=932508

16 years agoremember which service menus should be shown in the context menu
Peter Penz [Thu, 26 Feb 2009 19:58:22 +0000 (19:58 +0000)]
remember which service menus should be shown in the context menu

CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=932504

16 years agoProvide a basic UI for the "Services" settings dialog. It's open yet whether installi...
Peter Penz [Wed, 25 Feb 2009 20:53:17 +0000 (20:53 +0000)]
Provide a basic UI for the "Services" settings dialog. It's open yet whether installing services by the internet will make it into Dolphin/Konqueror for KDE 4.3, but at least turning off services (without deinstalling applications...) will be supported.

svn path=/trunk/KDE/kdebase/apps/; revision=931854

16 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Wed, 25 Feb 2009 19:33:07 +0000 (19:33 +0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/KDE/kdebase/apps/; revision=931776

16 years agoRestore support for pasting clipboard data (e.g. text) into a file, like konq-kde3...
David Faure [Wed, 25 Feb 2009 11:47:37 +0000 (11:47 +0000)]
Restore support for pasting clipboard data (e.g. text) into a file, like konq-kde3 could do.
CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=931496

16 years agoKUrl::path() != KUrl::toLocalFile() - at least not on windows
Christian Ehrlicher [Tue, 24 Feb 2009 19:20:14 +0000 (19:20 +0000)]
KUrl::path() != KUrl::toLocalFile() - at least not on windows

svn path=/trunk/KDE/kdebase/apps/; revision=931093

16 years agoStupid me: The inconsistent behavior between QListView::scrollTo() and QTreeView...
Peter Penz [Tue, 24 Feb 2009 08:25:01 +0000 (08:25 +0000)]
Stupid me: The inconsistent behavior between QListView::scrollTo() and QTreeView::scrollTo() has been fixed in Qt 4.5 :-) I should have tested this _before_ committing the huge patch for bug 185191... So:
* Remove the workaround in DolphinIconsView::scrollTo() to bypass an issue in Qt 4.4 (-> fixed in Qt 4.5)
* Revert the "use the DolphinController"-parts of commit 930754 and just use QAbstractItemView::scrollTo() instead.

CCBUG: 185191

svn path=/trunk/KDE/kdebase/apps/; revision=930777

16 years agoAfter renaming an item the view should be scrolled in a way to still have a fully...
Peter Penz [Tue, 24 Feb 2009 08:09:35 +0000 (08:09 +0000)]
After renaming an item the view should be scrolled in a way to still have a fully visible renamed item. The implementation required a lot of more code changes as such a fix should require: QAbstractItemView::scrollTo() cannot be used directly (inconsistent default behavior in QListView and QTreeView, a special case for the column view), so the communication has to be done with the DolphinController...

BUG: 185191

svn path=/trunk/KDE/kdebase/apps/; revision=930754

16 years ago* Remove deprecated use of KTabBar::setCloseButtonEnabled(), use qt-provided method...
Shaun Reich [Sun, 22 Feb 2009 17:06:15 +0000 (17:06 +0000)]
* Remove deprecated use of KTabBar::setCloseButtonEnabled(), use qt-provided method-QTabBar::setTabsClosable().

* Enable dragging of tabs thanks to the new feature in Qt 4.5, QTabBar::setMovable(), now that the KTabBar has been ported. The dragging is a very neat effect.

BUG: 164313

svn path=/trunk/KDE/kdebase/apps/; revision=930077

16 years agoclear the selection when Escape has been pressed (= same behavior like in Konqueror...
Peter Penz [Sun, 22 Feb 2009 14:07:46 +0000 (14:07 +0000)]
clear the selection when Escape has been pressed (= same behavior like in Konqueror for KDE 3)

BUG: 185184

svn path=/trunk/KDE/kdebase/apps/; revision=929983

16 years agoSVN_SILENT: removed spaces from end of line
Peter Penz [Sun, 22 Feb 2009 14:06:10 +0000 (14:06 +0000)]
SVN_SILENT: removed spaces from end of line

svn path=/trunk/KDE/kdebase/apps/; revision=929981

16 years agoSVN_SILENT: removed kDebugs
Peter Penz [Sun, 22 Feb 2009 13:21:08 +0000 (13:21 +0000)]
SVN_SILENT: removed kDebugs

svn path=/trunk/KDE/kdebase/apps/; revision=929967

16 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sun, 22 Feb 2009 13:03:29 +0000 (13:03 +0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/KDE/kdebase/apps/; revision=929949

16 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sat, 21 Feb 2009 14:07:30 +0000 (14:07 +0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/KDE/kdebase/apps/; revision=929498

16 years agoRemove preview icon, it isn't used, pollutes the hicolour namespace
Jonathan Riddell [Fri, 20 Feb 2009 17:07:59 +0000 (17:07 +0000)]
Remove preview icon, it isn't used, pollutes the hicolour namespace
and Oxygen already has a preview icon which Dolphin already uses (view-preview).

svn path=/trunk/KDE/kdebase/apps/; revision=929116

16 years agoRemember the used URL completion mode of the URL navigator. Thanks to Frank Reiningha...
Peter Penz [Fri, 20 Feb 2009 16:55:25 +0000 (16:55 +0000)]
Remember the used URL completion mode of the URL navigator. Thanks to Frank Reininghaus for the patch!

BUG: 170502

svn path=/trunk/KDE/kdebase/apps/; revision=929111

16 years agouse an icon for the "Rename" icon like the Folder View Plasmoid
Peter Penz [Wed, 18 Feb 2009 00:09:22 +0000 (00:09 +0000)]
use an icon for the "Rename" icon like the Folder View Plasmoid

svn path=/trunk/KDE/kdebase/apps/; revision=927646

16 years agoassure that the size hint calculation and the painting code are consistent
Peter Penz [Tue, 17 Feb 2009 22:24:14 +0000 (22:24 +0000)]
assure that the size hint calculation and the painting code are consistent

svn path=/trunk/KDE/kdebase/apps/; revision=927623

16 years agoDon't rely on the m_isHovered flag, explicitely check the left mouse button instead.
Peter Penz [Tue, 17 Feb 2009 21:54:25 +0000 (21:54 +0000)]
Don't rely on the m_isHovered flag, explicitely check the left mouse button instead.

svn path=/trunk/KDE/kdebase/apps/; revision=927602

16 years agoSVN_SILENT: forgot to remove this include after doing some tests
Peter Penz [Tue, 17 Feb 2009 21:27:17 +0000 (21:27 +0000)]
SVN_SILENT: forgot to remove this include after doing some tests

svn path=/trunk/KDE/kdebase/apps/; revision=927585

16 years agoFixed issue that invoking Dolphin with a specified path is ignored when another Dolph...
Peter Penz [Tue, 17 Feb 2009 20:43:15 +0000 (20:43 +0000)]
Fixed issue that invoking Dolphin with a specified path is ignored when another Dolphin window is open already. Thanks to Frank Reininghaus for the patch.

BUG: 169016

svn path=/trunk/KDE/kdebase/apps/; revision=927544

16 years ago* Use Nepomuk for getting the meta data instead of KFileMetaInfo.
Peter Penz [Tue, 17 Feb 2009 20:37:34 +0000 (20:37 +0000)]
* Use Nepomuk for getting the meta data instead of KFileMetaInfo.
* Use a QScrollArea widget to embedd the meta data, as Nepomuk provides so much meta information that it might not fit into the panel.

Open issues:
* Add the possibility to configure which kind of meta information should be shown.
* Check whether the receiving of the meta data for one file also might block the UI like when using KFileMetaInfo in combination with strigi.

CCMAIL: sebastian@trueg.de
BUG: 180742
BUG: 181592

svn path=/trunk/KDE/kdebase/apps/; revision=927542

16 years agoremoved m_minimumSizeHint member, it is redundant
Peter Penz [Tue, 17 Feb 2009 20:22:04 +0000 (20:22 +0000)]
removed m_minimumSizeHint member, it is redundant

svn path=/trunk/KDE/kdebase/apps/; revision=927537

16 years agoWhen the selection toggle is clicked and the mouse gets moved outside the selection...
Peter Penz [Tue, 17 Feb 2009 17:12:31 +0000 (17:12 +0000)]
When the selection toggle is clicked and the mouse gets moved outside the selection toggle boundaries, a rubberband with a random start position will get visible. Bypass this issue by consuming the mouse-move events.

BUG: 184178

svn path=/trunk/KDE/kdebase/apps/; revision=927488

16 years agoThe tab order of the View Properties Dialog now moves in a logical and coherent manne...
Shaun Reich [Tue, 17 Feb 2009 16:40:59 +0000 (16:40 +0000)]
The tab order of the View Properties Dialog now moves in a logical and coherent manner (it no longer skips out of order).

svn path=/trunk/KDE/kdebase/apps/; revision=927483

16 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Tue, 17 Feb 2009 12:09:45 +0000 (12:09 +0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/KDE/kdebase/apps/; revision=927390

16 years agoImplement TODO - show the action "expandable folders" in the RMB popup over detailed...
David Faure [Tue, 17 Feb 2009 10:57:23 +0000 (10:57 +0000)]
Implement TODO - show the action "expandable folders" in the RMB popup over detailed listview.

svn path=/trunk/KDE/kdebase/apps/; revision=927297

16 years agoApplied patches to filterbar as discussed on review request 91 and 93.
Sascha Peilicke [Mon, 16 Feb 2009 12:00:19 +0000 (12:00 +0000)]
Applied patches to filterbar as discussed on review request 91 and 93.

svn path=/trunk/KDE/kdebase/apps/; revision=926845

16 years agoSVN_SILENT: Fixed another accidental doxygen highlight.
Shaun Reich [Mon, 16 Feb 2009 05:04:01 +0000 (05:04 +0000)]
SVN_SILENT: Fixed another accidental doxygen highlight.

svn path=/trunk/KDE/kdebase/apps/; revision=926759

16 years agoI forgot to change these connection statements to both send and receive boolean value...
Shaun Reich [Mon, 16 Feb 2009 04:40:17 +0000 (04:40 +0000)]
I forgot to change these connection statements to both send and receive boolean values in my prior commit(s). Now the View Properties Dialog will enable the apply button when the affected (4) widget values are changed.

svn path=/trunk/KDE/kdebase/apps/; revision=926757

16 years agoSVN_SILENT: A header comment was being accidentally interpreted as a doxygen comment.
Shaun Reich [Sun, 15 Feb 2009 18:46:07 +0000 (18:46 +0000)]
SVN_SILENT: A header comment was being accidentally interpreted as a doxygen comment.

svn path=/trunk/KDE/kdebase/apps/; revision=926579

16 years agoAdded the Trash KCM to Dolphin, it's visible in the Settings Dialog, in the 'Trash...
Shaun Reich [Sun, 15 Feb 2009 18:06:04 +0000 (18:06 +0000)]
Added the Trash KCM to Dolphin, it's visible in the Settings Dialog, in the 'Trash" page.

Konqueror has it, we should too =)

svn path=/trunk/KDE/kdebase/apps/; revision=926571

16 years agoThe View Properties dialog now correctly disables/enables the Apply button, instead...
Shaun Reich [Sun, 15 Feb 2009 17:30:00 +0000 (17:30 +0000)]
The View Properties dialog now correctly disables/enables the Apply button, instead of it just being enabled all the time, even after you apply it, so it's similar to the Settings Dialog now.

svn path=/trunk/KDE/kdebase/apps/; revision=926562

16 years agoChanged connections of the signals activated(), to currentIndexChanged() as used...
Shaun Reich [Sat, 14 Feb 2009 19:45:25 +0000 (19:45 +0000)]
Changed connections of the signals activated(), to currentIndexChanged() as used in 3 QComboBoxes. Remember that activated() is not always triggered when the selected item is changed.

svn path=/trunk/KDE/kdebase/apps/; revision=926180

16 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sat, 14 Feb 2009 16:04:31 +0000 (16:04 +0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/KDE/kdebase/apps/; revision=926053

16 years agoSVN_SILENT: documentation fix (the selection manager might also useful in the double...
Peter Penz [Fri, 13 Feb 2009 16:46:38 +0000 (16:46 +0000)]
SVN_SILENT: documentation fix (the selection manager might also useful in the double-click mode)

svn path=/trunk/KDE/kdebase/apps/; revision=925615

16 years agohide the tooltip when the context menu is opened in the columns view
Peter Penz [Wed, 11 Feb 2009 21:27:36 +0000 (21:27 +0000)]
hide the tooltip when the context menu is opened in the columns view

BUG: 184053
CCMAIL: predator106@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=924889

16 years ago- allow the view implementations to attach custom actions to the context menu
Peter Penz [Wed, 11 Feb 2009 20:45:12 +0000 (20:45 +0000)]
- allow the view implementations to attach custom actions to the context menu
- let the "details view" show the "[x] Expandable Folders" action in the context menu

CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=924867

16 years agoMiddle-clicking on tabs will now close them.
Shaun Reich [Tue, 10 Feb 2009 20:48:16 +0000 (20:48 +0000)]
Middle-clicking on tabs will now close them.

svn path=/trunk/KDE/kdebase/apps/; revision=924467

16 years agoFixed issue that the 'Create New' menu might be disabled although creating of files...
Peter Penz [Tue, 10 Feb 2009 07:09:49 +0000 (07:09 +0000)]
Fixed issue that the 'Create New' menu might be disabled although creating of files is allowed. Thanks to Frank Reininghaus for the patch!

BUG: 183812

svn path=/trunk/KDE/kdebase/apps/; revision=924120

16 years agoThe Column Widget would not disconnect it's connection to request a tab(seen with...
Shaun Reich [Mon, 9 Feb 2009 11:23:40 +0000 (11:23 +0000)]
The Column Widget would not disconnect it's connection to request a tab(seen with a middle-click on a folder). So it would actually open 2 or more tabs, but only in the Column View mode.

svn path=/trunk/KDE/kdebase/apps/; revision=923757

16 years ago* open folders always on single click
Peter Penz [Sun, 8 Feb 2009 18:32:44 +0000 (18:32 +0000)]
* open folders always on single click
* open files/select files dependent from the global single click/double click setting
* open a new column when pressing the Key_Right

Thanks to Shaun Michael Reich for the original patches!

CCMAIL: predator106@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=923423

16 years agoAllow the view implementations to directly trigger an item without mouse interaction...
Peter Penz [Sun, 8 Feb 2009 18:26:23 +0000 (18:26 +0000)]
Allow the view implementations to directly trigger an item without mouse interaction. This is e. g. necessary when the column view wants to implement a custom key handling where a folder should be triggered.

svn path=/trunk/KDE/kdebase/apps/; revision=923417

16 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sun, 8 Feb 2009 14:11:41 +0000 (14:11 +0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/KDE/kdebase/apps/; revision=923249

16 years agoRevert SVN commit 923057: This code should not be part of DolphinController, it shoul...
Peter Penz [Sun, 8 Feb 2009 07:15:26 +0000 (07:15 +0000)]
Revert SVN commit 923057: This code should not be part of DolphinController, it should be handled in the column view itself.

CCMAIL: predator106@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=923072

16 years agoAdded right arrow key usage when in the Column View mode. When a directory is selecte...
Shaun Reich [Sun, 8 Feb 2009 04:33:00 +0000 (04:33 +0000)]
Added right arrow key usage when in the Column View mode. When a directory is selected, and the right arrow is used, it will navigate into it (like double/single clicking a directory). Note, this only works on directories, not files, it was made this way by intention.

svn path=/trunk/KDE/kdebase/apps/; revision=923057

16 years agoThe layout algorithm of QListView in Qt4.5 also respects the style-hint QStyle::SH_Sc...
Peter Penz [Sat, 7 Feb 2009 18:56:28 +0000 (18:56 +0000)]
The layout algorithm of QListView in Qt4.5 also respects the style-hint QStyle::SH_ScrollView_FrameOnlyAroundContents. To assure that Dolphin uses the maximum available width for the size hint of the items, the style-hint must be included too for Qt 4.5.

I tested this fix also with Qt4.4 and it seems that the style-hint returns always 0 in this case -> this patch seems to be backward compatible...

svn path=/trunk/KDE/kdebase/apps/; revision=922900

16 years agoChanged the order of the shortcut for opening a new tab from Ctrl+Shift+N to Ctrl...
Shaun Reich [Sat, 7 Feb 2009 04:47:04 +0000 (04:47 +0000)]
Changed the order of the shortcut for opening a new tab from Ctrl+Shift+N to Ctrl+T, so the latter is now the default, and is shown like that. It now shows up like the other items in the file menu. (it doesn't have a shift key modifier in it).

svn path=/trunk/KDE/kdebase/apps/; revision=922452

16 years agoSVN_SILENT Added newline at EOF.
Shaun Reich [Sat, 7 Feb 2009 02:01:18 +0000 (02:01 +0000)]
SVN_SILENT Added newline at EOF.

svn path=/trunk/KDE/kdebase/apps/; revision=922440

16 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Fri, 6 Feb 2009 15:34:47 +0000 (15:34 +0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/KDE/kdebase/apps/; revision=922231

16 years agoReverted r921975, I wasn't aware that the lack of reading the double-click setting...
Shaun Reich [Fri, 6 Feb 2009 11:53:14 +0000 (11:53 +0000)]
Reverted r921975, I wasn't aware that the lack of reading the double-click setting was intentional, I originally wanted the double-click setting to apply only to files, and the single click apply to only folders :) .

CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=922070

16 years agoThe column view did not obey single/double-click navigation settings, it does now...
Shaun Reich [Fri, 6 Feb 2009 02:52:23 +0000 (02:52 +0000)]
The column view did not obey single/double-click navigation settings, it does now. The signals were only connected to the singleClick(), not the doubleClick() method. They are now also connected/disconnected according to the setting that is set globally.

svn path=/trunk/KDE/kdebase/apps/; revision=921975

16 years agoSVN_SILENT: Added a comment.
Shaun Reich [Fri, 6 Feb 2009 02:39:31 +0000 (02:39 +0000)]
SVN_SILENT: Added a comment.

svn path=/trunk/KDE/kdebase/apps/; revision=921970

16 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Thu, 5 Feb 2009 14:09:41 +0000 (14:09 +0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/KDE/kdebase/apps/; revision=921684

16 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Wed, 4 Feb 2009 16:27:07 +0000 (16:27 +0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/KDE/kdebase/apps/; revision=921220

16 years agoThe Home folder location, when set via loadSettings(), and when set via the 'Use...
Shaun Reich [Wed, 4 Feb 2009 03:44:13 +0000 (03:44 +0000)]
The Home folder location, when set via loadSettings(), and when set via the 'Use Default Location' button, now will use KUrl::prettyUrl(); Prior to this, saving an address of '/home/user/' would be changed to 'file:///home/user' (on Linux) normally (through applySettings()). However, when the listed methods were called, the text of the line edit would be just '/home/user/'. It will now (basically) be set to 'file:///'... all throughout.

svn path=/trunk/KDE/kdebase/apps/; revision=920943

16 years agoAdded const bools for a few settings that were referenced more than once. Otherwise...
Shaun Reich [Wed, 4 Feb 2009 01:24:38 +0000 (01:24 +0000)]
Added const bools for a few settings that were referenced more than once. Otherwise, the fellow coder would probably just think these were taken out of seemingly thin air.

svn path=/trunk/KDE/kdebase/apps/; revision=920920

16 years agoCheck whether the global single-click/double-click setting has been changed during...
Peter Penz [Tue, 3 Feb 2009 18:40:59 +0000 (18:40 +0000)]
Check whether the global single-click/double-click setting has been changed during runtime and assure that the behavior of the view is adjusted.

CCMAIL: predator106@gmail.com
BUG: 175635
BUG: 175280

svn path=/trunk/KDE/kdebase/apps/; revision=920754

16 years agoDon't differ between single-click and double-click in the column view, stay consisten...
Peter Penz [Tue, 3 Feb 2009 18:35:19 +0000 (18:35 +0000)]
Don't differ between single-click and double-click in the column view, stay consistent with the behavior like the Places Panel or Folders Panel.

svn path=/trunk/KDE/kdebase/apps/; revision=920753

16 years agorename the checkbox "Browse through archives" to "Open archives as folder"
Peter Penz [Tue, 3 Feb 2009 17:54:33 +0000 (17:54 +0000)]
rename the checkbox "Browse through archives" to "Open archives as folder"

CCBUG: 182991

svn path=/trunk/KDE/kdebase/apps/; revision=920733

16 years agoSVN_SILENT: updated comment
Peter Penz [Tue, 3 Feb 2009 17:49:27 +0000 (17:49 +0000)]
SVN_SILENT: updated comment

svn path=/trunk/KDE/kdebase/apps/; revision=920731

16 years agoSVN_SILENT made messages (.desktop file, second try)
Script Kiddy [Tue, 3 Feb 2009 14:52:58 +0000 (14:52 +0000)]
SVN_SILENT made messages (.desktop file, second try)

svn path=/trunk/KDE/kdebase/apps/; revision=920635

16 years ago* no general settings are read -> invoking loadSettings has no effect in restoreDefau...
Peter Penz [Tue, 3 Feb 2009 06:24:39 +0000 (06:24 +0000)]
* no general settings are read -> invoking loadSettings has no effect in restoreDefaults()
* use constants for the defaults, as hardcoding the defaults in 2 methods might be error-prone when changing the defaults in future

CCMAIL: predator106@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=920531

16 years agoString change - Added clarification in the displayed message box for when the setting...
Shaun Reich [Tue, 3 Feb 2009 03:20:47 +0000 (03:20 +0000)]
String change - Added clarification in the displayed message box for when the settings are applied in the Startup page, and there is an error. This is under the home folder setting. It now says that "the home folder is invalid or does not exist" as opposed to just saying it is invalid. I believe that it was kind of misleading as to what was wrong, so I figured it should give them _some_ hint as to what the problem is.

svn path=/trunk/KDE/kdebase/apps/; revision=920501

16 years agoSVN_SILENT Small update to a comment.
Shaun Reich [Tue, 3 Feb 2009 01:40:30 +0000 (01:40 +0000)]
SVN_SILENT Small update to a comment.

svn path=/trunk/KDE/kdebase/apps/; revision=920497

16 years agoBoth the 'preview size' slider and the 'embed thumbnails in files' settings now resto...
Shaun Reich [Tue, 3 Feb 2009 01:20:53 +0000 (01:20 +0000)]
Both the 'preview size' slider and the 'embed thumbnails in files' settings now restore to defaults when asked to.

svn path=/trunk/KDE/kdebase/apps/; revision=920491

16 years agoA few more fixes...mostly cleanups.
Shaun Reich [Mon, 2 Feb 2009 22:23:06 +0000 (22:23 +0000)]
A few more fixes...mostly cleanups.

*Grouped some statements that it didn't make sense to put after a certain block of code (giving the impression that it had to be after this block).
*There is no need to set the value of the QSpinBox equal to that of the slider, when loading settings... their valueChanges() signals are connected to the opposite one's slot.
*Made a now unused variable be used, it was inconsistent in this code block, two times '1' was used, but other times a var set to '1' would be used.
*Moved some blocks of code from the loadSettings() method, into the constructor, since the loadSettings() method is called more than once, so it's more resource-friendly to do it this way.

svn path=/trunk/KDE/kdebase/apps/; revision=920441

16 years agoWe were calling methods within loadSettings() which should have been moved to inside...
Shaun Reich [Mon, 2 Feb 2009 21:35:37 +0000 (21:35 +0000)]
We were calling methods within loadSettings() which should have been moved to inside the constructor instead. Examples include setting up a slider's notch-type(bottom or top). Especially significant since loadSettings() gets called more often than the constructor.

svn path=/trunk/KDE/kdebase/apps/; revision=920419

16 years agoSVN_SILENT Fix to avoid accidental doxygen-highlighted header license.
Shaun Reich [Mon, 2 Feb 2009 20:51:15 +0000 (20:51 +0000)]
SVN_SILENT Fix to avoid accidental doxygen-highlighted header license.

svn path=/trunk/KDE/kdebase/apps/; revision=920402

16 years agoNavigation click type (single/double-click) now gets set to it's default when asked...
Shaun Reich [Mon, 2 Feb 2009 20:40:33 +0000 (20:40 +0000)]
Navigation click type (single/double-click) now gets set to it's default when asked (the default is single-click).

svn path=/trunk/KDE/kdebase/apps/; revision=920400

16 years agoChanged group config reference pertaining to the "kcminputrc" file. The Navigation...
Shaun Reich [Mon, 2 Feb 2009 20:14:42 +0000 (20:14 +0000)]
Changed group config reference pertaining to the "kcminputrc" file. The Navigation page setting of whether to use single/double click navigation now saves itself properly, instead of insisting on using single-click.  :)

P.S. Bear in mind that the setting still does not apply itself until a restart of Dolphin.

CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=920390

16 years agoReverted my previous commit(919897), I was incorrect, it looked to work like this...
Shaun Reich [Mon, 2 Feb 2009 19:43:02 +0000 (19:43 +0000)]
Reverted my previous commit(919897), I was incorrect, it looked to work like this, but didn't.

svn path=/trunk/KDE/kdebase/apps/; revision=920374

16 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Mon, 2 Feb 2009 15:35:50 +0000 (15:35 +0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/KDE/kdebase/apps/; revision=920235

16 years agoConfirmations of the following settings now reset themselves to their defaults:
Shaun Reich [Mon, 2 Feb 2009 14:44:25 +0000 (14:44 +0000)]
Confirmations of the following settings now reset themselves to their defaults:
*Move to Trash
*Delete
These are located in the General page->Context Menu tab of the settings dialog.

svn path=/trunk/KDE/kdebase/apps/; revision=920205

16 years agoThe "Show 'Delete' Command" checkbox now gets restored to it's default (false).
Shaun Reich [Mon, 2 Feb 2009 02:38:42 +0000 (02:38 +0000)]
The "Show 'Delete' Command" checkbox now gets restored to it's default (false).

svn path=/trunk/KDE/kdebase/apps/; revision=919996

16 years agoThese radio buttons are paired, when you enable one, you inherently disable the other...
Shaun Reich [Mon, 2 Feb 2009 02:34:57 +0000 (02:34 +0000)]
These radio buttons are paired, when you enable one, you inherently disable the other, so we're just repeating ourselves by doing this manually.

svn path=/trunk/KDE/kdebase/apps/; revision=919995

16 years agoHovering over blank space in a view while dragging would trigger the FolderExpander...
Simon Paul St James [Sun, 1 Feb 2009 22:03:04 +0000 (22:03 +0000)]
Hovering over blank space in a view while dragging would trigger the FolderExpander on the folder represented by the view, which we don't want.  Detect and prevent it.

BUG:182618

Shipped! ;)

svn path=/trunk/KDE/kdebase/apps/; revision=919950

16 years agoI forgot to change these three tabs to the new method usage also. Effected was the...
Shaun Reich [Sun, 1 Feb 2009 21:01:06 +0000 (21:01 +0000)]
I forgot to change these three tabs to the new method usage also. Effected was the View Modes page.

svn path=/trunk/KDE/kdebase/apps/; revision=919919

16 years agoNow when you click the button "Defaults" in the settings dialog, it will push the...
Shaun Reich [Sun, 1 Feb 2009 20:43:26 +0000 (20:43 +0000)]
Now when you click the button "Defaults" in the settings dialog, it will push the settings to the UI, then the user can apply, cancel, or modify them from there. Also removed the message box prompt. Use settings->useDefaults(true), then set it back to false after you are done loading settings in the restoreDefaults() method calls. Don't use ->setDefaults() normally, anymore.

svn path=/trunk/KDE/kdebase/apps/; revision=919897

16 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sun, 1 Feb 2009 16:24:40 +0000 (16:24 +0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/KDE/kdebase/apps/; revision=919783