Shaun Reich [Tue, 10 Mar 2009 00:35:59 +0000 (00:35 +0000)]
The tab icon now obeys the icon of the folder that it is currently browsing. Before it would just use the "folder" icon, but it now finds the icon of that folder, and uses it.
Shaun Reich [Mon, 9 Mar 2009 18:10:35 +0000 (18:10 +0000)]
The "Recently Closed Tabs" action menu now has a limit of 10, before it could just go on for practically ever, which would yield an annoyingly huge list of closed tabs.
Shaun Reich [Mon, 9 Mar 2009 02:31:41 +0000 (02:31 +0000)]
There is no point in setting the text of a tab, each time a tab is selected, the only time we should have to do that is when we are using a split view.
This also kind of hides the Qt 4.5 tab bug (a very ugly one) from "regular" users (who don't use the split view).
Peter Penz [Wed, 25 Feb 2009 20:53:17 +0000 (20:53 +0000)]
Provide a basic UI for the "Services" settings dialog. It's open yet whether installing services by the internet will make it into Dolphin/Konqueror for KDE 4.3, but at least turning off services (without deinstalling applications...) will be supported.
Peter Penz [Tue, 24 Feb 2009 08:25:01 +0000 (08:25 +0000)]
Stupid me: The inconsistent behavior between QListView::scrollTo() and QTreeView::scrollTo() has been fixed in Qt 4.5 :-) I should have tested this _before_ committing the huge patch for bug 185191... So:
* Remove the workaround in DolphinIconsView::scrollTo() to bypass an issue in Qt 4.4 (-> fixed in Qt 4.5)
* Revert the "use the DolphinController"-parts of commit 930754 and just use QAbstractItemView::scrollTo() instead.
Peter Penz [Tue, 24 Feb 2009 08:09:35 +0000 (08:09 +0000)]
After renaming an item the view should be scrolled in a way to still have a fully visible renamed item. The implementation required a lot of more code changes as such a fix should require: QAbstractItemView::scrollTo() cannot be used directly (inconsistent default behavior in QListView and QTreeView, a special case for the column view), so the communication has to be done with the DolphinController...
Shaun Reich [Sun, 22 Feb 2009 17:06:15 +0000 (17:06 +0000)]
* Remove deprecated use of KTabBar::setCloseButtonEnabled(), use qt-provided method-QTabBar::setTabsClosable().
* Enable dragging of tabs thanks to the new feature in Qt 4.5, QTabBar::setMovable(), now that the KTabBar has been ported. The dragging is a very neat effect.
Peter Penz [Tue, 17 Feb 2009 20:43:15 +0000 (20:43 +0000)]
Fixed issue that invoking Dolphin with a specified path is ignored when another Dolphin window is open already. Thanks to Frank Reininghaus for the patch.
Peter Penz [Tue, 17 Feb 2009 20:37:34 +0000 (20:37 +0000)]
* Use Nepomuk for getting the meta data instead of KFileMetaInfo.
* Use a QScrollArea widget to embedd the meta data, as Nepomuk provides so much meta information that it might not fit into the panel.
Open issues:
* Add the possibility to configure which kind of meta information should be shown.
* Check whether the receiving of the meta data for one file also might block the UI like when using KFileMetaInfo in combination with strigi.
Peter Penz [Tue, 17 Feb 2009 17:12:31 +0000 (17:12 +0000)]
When the selection toggle is clicked and the mouse gets moved outside the selection toggle boundaries, a rubberband with a random start position will get visible. Bypass this issue by consuming the mouse-move events.
Shaun Reich [Mon, 16 Feb 2009 04:40:17 +0000 (04:40 +0000)]
I forgot to change these connection statements to both send and receive boolean values in my prior commit(s). Now the View Properties Dialog will enable the apply button when the affected (4) widget values are changed.
Shaun Reich [Sun, 15 Feb 2009 17:30:00 +0000 (17:30 +0000)]
The View Properties dialog now correctly disables/enables the Apply button, instead of it just being enabled all the time, even after you apply it, so it's similar to the Settings Dialog now.
Shaun Reich [Sat, 14 Feb 2009 19:45:25 +0000 (19:45 +0000)]
Changed connections of the signals activated(), to currentIndexChanged() as used in 3 QComboBoxes. Remember that activated() is not always triggered when the selected item is changed.
Peter Penz [Wed, 11 Feb 2009 20:45:12 +0000 (20:45 +0000)]
- allow the view implementations to attach custom actions to the context menu
- let the "details view" show the "[x] Expandable Folders" action in the context menu
Shaun Reich [Mon, 9 Feb 2009 11:23:40 +0000 (11:23 +0000)]
The Column Widget would not disconnect it's connection to request a tab(seen with a middle-click on a folder). So it would actually open 2 or more tabs, but only in the Column View mode.
Peter Penz [Sun, 8 Feb 2009 18:32:44 +0000 (18:32 +0000)]
* open folders always on single click
* open files/select files dependent from the global single click/double click setting
* open a new column when pressing the Key_Right
Thanks to Shaun Michael Reich for the original patches!
Peter Penz [Sun, 8 Feb 2009 18:26:23 +0000 (18:26 +0000)]
Allow the view implementations to directly trigger an item without mouse interaction. This is e. g. necessary when the column view wants to implement a custom key handling where a folder should be triggered.
Shaun Reich [Sun, 8 Feb 2009 04:33:00 +0000 (04:33 +0000)]
Added right arrow key usage when in the Column View mode. When a directory is selected, and the right arrow is used, it will navigate into it (like double/single clicking a directory). Note, this only works on directories, not files, it was made this way by intention.
Peter Penz [Sat, 7 Feb 2009 18:56:28 +0000 (18:56 +0000)]
The layout algorithm of QListView in Qt4.5 also respects the style-hint QStyle::SH_ScrollView_FrameOnlyAroundContents. To assure that Dolphin uses the maximum available width for the size hint of the items, the style-hint must be included too for Qt 4.5.
I tested this fix also with Qt4.4 and it seems that the style-hint returns always 0 in this case -> this patch seems to be backward compatible...
Shaun Reich [Sat, 7 Feb 2009 04:47:04 +0000 (04:47 +0000)]
Changed the order of the shortcut for opening a new tab from Ctrl+Shift+N to Ctrl+T, so the latter is now the default, and is shown like that. It now shows up like the other items in the file menu. (it doesn't have a shift key modifier in it).
Shaun Reich [Fri, 6 Feb 2009 11:53:14 +0000 (11:53 +0000)]
Reverted r921975, I wasn't aware that the lack of reading the double-click setting was intentional, I originally wanted the double-click setting to apply only to files, and the single click apply to only folders :) .
Shaun Reich [Fri, 6 Feb 2009 02:52:23 +0000 (02:52 +0000)]
The column view did not obey single/double-click navigation settings, it does now. The signals were only connected to the singleClick(), not the doubleClick() method. They are now also connected/disconnected according to the setting that is set globally.
Shaun Reich [Wed, 4 Feb 2009 03:44:13 +0000 (03:44 +0000)]
The Home folder location, when set via loadSettings(), and when set via the 'Use Default Location' button, now will use KUrl::prettyUrl(); Prior to this, saving an address of '/home/user/' would be changed to 'file:///home/user' (on Linux) normally (through applySettings()). However, when the listed methods were called, the text of the line edit would be just '/home/user/'. It will now (basically) be set to 'file:///'... all throughout.
Shaun Reich [Wed, 4 Feb 2009 01:24:38 +0000 (01:24 +0000)]
Added const bools for a few settings that were referenced more than once. Otherwise, the fellow coder would probably just think these were taken out of seemingly thin air.
Peter Penz [Tue, 3 Feb 2009 06:24:39 +0000 (06:24 +0000)]
* no general settings are read -> invoking loadSettings has no effect in restoreDefaults()
* use constants for the defaults, as hardcoding the defaults in 2 methods might be error-prone when changing the defaults in future
Shaun Reich [Tue, 3 Feb 2009 03:20:47 +0000 (03:20 +0000)]
String change - Added clarification in the displayed message box for when the settings are applied in the Startup page, and there is an error. This is under the home folder setting. It now says that "the home folder is invalid or does not exist" as opposed to just saying it is invalid. I believe that it was kind of misleading as to what was wrong, so I figured it should give them _some_ hint as to what the problem is.
Shaun Reich [Mon, 2 Feb 2009 22:23:06 +0000 (22:23 +0000)]
A few more fixes...mostly cleanups.
*Grouped some statements that it didn't make sense to put after a certain block of code (giving the impression that it had to be after this block).
*There is no need to set the value of the QSpinBox equal to that of the slider, when loading settings... their valueChanges() signals are connected to the opposite one's slot.
*Made a now unused variable be used, it was inconsistent in this code block, two times '1' was used, but other times a var set to '1' would be used.
*Moved some blocks of code from the loadSettings() method, into the constructor, since the loadSettings() method is called more than once, so it's more resource-friendly to do it this way.