Robert Knight [Wed, 5 Sep 2007 19:33:08 +0000 (19:33 +0000)]
Remove reference to a slot which does not exist. Almost identical code can be found in the DolphinView constructor, which does have an updateCutItems() slot.
David Faure [Tue, 28 Aug 2007 21:47:20 +0000 (21:47 +0000)]
dolphinview fix: don't emit urlChanged twice in DolphinView::setUrl (it's already emitted by the controller, and we forward that)
dolphinpart fix: don't let the konq wheel spin forever when clicking on the Home button and we're already viewing $HOME.
Peter Penz [Thu, 16 Aug 2007 15:28:30 +0000 (15:28 +0000)]
preview did not work anymore (KDirLister emits the signal newItems(const KFileItemList&) -> generatePreviews() from Dolphin must have the same signature)
Peter Penz [Thu, 16 Aug 2007 05:22:39 +0000 (05:22 +0000)]
Readded correct Q_ASSERT(m_fileInfo.isNull()) (the previous Q_ASSERT(!m_fileInfo.isNull()) accidentally has been added due to the 'use KFileItem by value instead of pointer' change...)
Peter Penz [Wed, 15 Aug 2007 22:08:00 +0000 (22:08 +0000)]
Smoother animations for the pixmap viewer if the pixmap is changed constantly during small time slots (thanks to Rafael Fernández López for the original patch!).
David Faure [Mon, 13 Aug 2007 10:17:57 +0000 (10:17 +0000)]
KParts::URLArgs split up [merged from branches/work/kparts_urlargs_split]
into KParts::OpenUrlArguments and KParts::BrowserArguments.
This also allows the part to set arguments().mimeType() is the host didn't set it.
Peter Penz [Sun, 12 Aug 2007 17:48:29 +0000 (17:48 +0000)]
* fixed issue that when having a split view, that both views get the same color after OK or Apply has been pressed inside the Dolphin settings dialog
* prepare for toggling the view icon depending from the activation state
Peter Penz [Mon, 6 Aug 2007 16:09:06 +0000 (16:09 +0000)]
* toggle selection when using CTRL modifier
* assure that the selection model of the column is synchronized when triggering "Select All" or "Invert Selection"
Peter Penz [Mon, 6 Aug 2007 06:56:36 +0000 (06:56 +0000)]
Fixed 'Select All' and 'Invert Selection' for the column view (only the items of the currently active column will be selected, not the whole tree). The current implementation is quite slow, but this will be fixed later.
Peter Penz [Sun, 29 Jul 2007 15:33:52 +0000 (15:33 +0000)]
Assure that the view properties of a column view are always stored in the folder represented by the first column. It is assured now, that all columns use the same view properties. Although one reason is because of technical 'restrictions' (KDirLister properties like 'show dot files' are applied to all sub directories too), I personally think it also makes sense from a usability point of view.
Peter Penz [Thu, 26 Jul 2007 19:57:37 +0000 (19:57 +0000)]
remove strange copy/paste issue which was responsible that Dolphin forgot the general settings (it seems those lines have been copied from GeneralViewSettingsPage::restoreDefaults() per accident)
ok, second try: make use of KDirSortFilterProxyModel. 'Show in Groups' still works, haven't tested nepomuk part though.
NOTE to dolphin devs: please, consider using 'left.column()' instead of 'sortRole()' in lessThan methods, and 'sorting()' instead of 'sortRole()' in other places.
Didn't make switch by myself because it needs nepomk testing (shouldn't be too hard though).
Robert Knight [Mon, 23 Jul 2007 23:08:47 +0000 (23:08 +0000)]
Fix a couple of crashes. First was to avoid problem caused by KIconLoader::global()->theme() returning 0 (which according to the API, it can do). Second was to fix the 'lastIndex' member of KCategorizedView::Private being out of date when used. According to the comments this member existed as an optimization. However in the only function where it is used, scrollbar updates are also performed. This will be several orders of magnitude more expensive than the 3 constant-time operations on Qt containers (QHash,QList) which the optimization avoided. So I removed the 'lastIndex' member and moved the calculation to where the data is needed.
change XDG_APPS_DIR -> XDG_APPS_INSTALL_DIR, XDG_DIRECTORY_DIR->XDG_DIRECTORY_INSTALL_DIR, DBUS_INTERFACES_DIR->DBUS_INTERFACES_INSTALL_ DIR, DBUS_SERVICES_DIR->DBUS_SERVICES_INSTALL_DIR to have same naming convention as discussed with Alex.
Peter Penz [Sun, 22 Jul 2007 19:28:47 +0000 (19:28 +0000)]
Use KDirSortFilterProxyModel::naturalCompare() to prevent code duplication. DolphinSortFilterProxyModel::lessThan() still contains similar code like KDirSortFilterProxyModel::lessThan(), but we will discuss this with Rafael in August (it's open yet whether KSortFilterProxyModel should be derived from KDirSortFilterProxyModel or not...).
Peter Penz [Wed, 18 Jul 2007 21:05:47 +0000 (21:05 +0000)]
QAbstractItemView::viewOptions() only returns an instance of the class QStyleOptionViewItem, so the text wrapping property of QStyleOptionViewItemV3 will never be set -> check whether wrapping has been enabled inside QListView
Peter Penz [Wed, 18 Jul 2007 20:34:40 +0000 (20:34 +0000)]
When derived classes overwrite KCategorizedView::visualRect() to adjust the visual width or height, drawing errors occur as internally always d->visualRect() is used -> always use KCategorizedView::visualRect()...